KotJohansson/MyPal
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[html parser] Check for integer overflow when computing new buffer sizes.

Browse Source
This commit is contained in:
Fedor
2021-03-06 20:56:43 +02:00
parent 3626db09ca
commit c0d00a8e0d
7 changed files with 36 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
parser/html/nsHtml5Tokenizer.cpp
+2 -2
View File
@@ -1,7 +1,7 @@
/*
* Copyright (c) 2005-2007 Henri Sivonen
* Copyright (c) 2007-2015 Mozilla Foundation
* Copyright (c) 2018-2020 Moonchild Productions
* Copyright (c) 2018-2021 Moonchild Productions
* Copyright (c) 2020 Binary Outcast
* Portions of comments Copyright 2004-2010 Apple Computer, Inc., Mozilla
* Foundation, and Opera Software ASA.
@@ -249,7 +249,7 @@ nsHtml5Tokenizer::emitStrBuf()
void
nsHtml5Tokenizer::appendStrBuf(char16_t* buffer, int32_t offset, int32_t length)
{
int32_t newLen = strBufLen + length;
int32_t newLen = nsHtml5Portability::checkedAdd(strBufLen, length);
MOZ_ASSERT(newLen <= strBuf.length, "Previous buffer length insufficient.");
if (MOZ_UNLIKELY(strBuf.length < newLen)) {
if (MOZ_UNLIKELY(!EnsureBufferSpace(length))) {