Commit Graph

71 Commits

Author SHA1 Message Date
Moonchild 528abd534e Issue #80 - De-unify layout/base 2020-05-06 19:05:49 +02:00
wolfbeast 8bd941d4e3 Issue #1507 - Remove nsRefreshDriver's use of high res system timers.
Since we are using vsync for timing anyway in the layout refresh driver,
there is no need to bump the system timer resolution down to 1 ms.

This resolves #1507.
2020-04-14 13:23:48 +02:00
wolfbeast dba09fa5c4 Revert "Issue #1355 - Better way to create display items for column backgrounds"
This reverts commit 44c47c5038.
2020-04-14 12:59:57 +02:00
win7-7 cbb61ab832 Issue #1355 - Better way to create display items for column backgrounds
Part 1: Remove current table item, as it's never set.

Part 2: Get rid of generic table painting code, and handle each class separately.

Part 4: Hoist outline skipping into col(group) frame code.

Part 5: Skip box-shadow for table column and column groups.

Part 6: Store column and column group backgrounds separately, and then append them before the rest of the table contents.

Part 7: Pass rects in display list coordinates to AppendBackgroundItemsToTop.

Part 8: Create column and column group background display items as part of the cell's BuildDisplayList.

Part 9: Used cached values instead of calling nsDisplayListBuilder::ToReferenceFrame when possible, since it can be expensive when the requested frame isn't the builder's current frame.

Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position.

Part 11: Create an AutoBuildingDisplayList when we create background items for table columns and column groups, so that we initialize the invalidation state correctly.
2020-04-14 12:58:11 +02:00
wolfbeast 8ffe533b3d [CSS] Only emit non-GC chrome wrapped XUL box warnings in debug builds. 2020-04-14 12:44:16 +02:00
athenian200 563dc95cdb Issue #1356 - Remove -moz-user-input disabled to improve event handling. 2020-04-14 12:16:31 +02:00
wolfbeast f1e40aaa5b Issue #1360 - Part 2: Update tests for changed preferences. 2020-04-14 12:14:27 +02:00
wolfbeast dfa7af70ce Issue #1118 - Part 5: Change the way document.open() works
This changes the work we do for document.open() in the following ways:
- We no longer create a new Window when doing document.open().
  We use the same Window but remove all the event listeners on the
  existing DOM tree and Window before removing the document's existing
  children to provide a clean slate document to use for .write().
- We no longer create a session history entry (previously would be a
  wyciwyg URI). We now replace the current one, effectively losing the
  entry for the original document.
- We now support document.open() on windowless documents.
2019-12-22 19:57:30 +01:00
wolfbeast 0f001155aa Issue #1308 - Create nsDisplayTableBackgroundColor to avoid display
list collisions when processing the background color of a table.

This is effectively #146 Part 3c to go along with the other 2 there.

This resolves #1308.
2019-12-01 06:20:05 +01:00
wolfbeast 5ab2da7004 Issue #146 - Part 6: Allow position: sticky on table elements. 2019-11-03 19:43:51 +01:00
wolfbeast ee663e2930 Issue #146 - Part 3: Create nsDisplayTableBackgroundImage to avoid
display list collisions when processing the background image of a table.
2019-11-03 17:25:37 +01:00
wolfbeast db98e3efff Issue #146 - Part 3: Create nsDisplayTableFixedPosition to avoid display
list collisions when processing the background image of a table.
2019-11-03 15:12:34 +01:00
wolfbeast 0de40040f0 Issue #146 - Part 2: Remove custom table painting component.
Since we're now putting table borders and backgrounds properly in the
display lists, we no longer need this custom component to do this work
for us.
2019-11-02 23:10:06 +01:00
wolfbeast 1455272075 Issue #146 - Part 1: Draw each table's background on their own display
list items.

This patch does the following things:
1. Creates nsDisplayTableBorderCollapse that draws all collapse border
of tables.
2. Stops the use of nsDisplayTableBorderBackground.
3. Lets column and column group frames generate display items.
4. When traversing the table, also traverses the column and column group
frames.
5. For each type of table frame (col group, col, row group, row and
cell), draws their own background.
2019-11-02 22:42:07 +01:00
Gaming4JC 8ff295747e Issue #1230 - Part 1: Fix Back-computing percentages for intrinsic sizing in Layout CSS-Grid
List of relevant patches applied:

1398537 part 2 - [css-multicol] Implement percentages for 'column-gap' (Gecko part).

1434478 part 1 - [css-grid] Stop back-computing percentage grid gaps when the percentage basis is indefinite. Treat them as zero sized instead.

1434478 part 2 - Stop back-computing percentage padding/margin when the percentage basis is indefinite. Treat them as zero sized instead.

1434478 part 3 - Remove IntrinsicISizeOffsetData::hPctPadding/hPctMargin members since they are now unused.

1434478 part 4 - Factor out constants like NS_UNCONSTRAINEDSIZE so they can be used in headers without needing nsIFrame.h (idempotent patch).

1434478 part 5 - Create nsLayoutUtils::ResolveToLength for resolving CSS <length-percentage> (idempotent patch).

1434478 part 6 - Propagate a percentage basis to nsIFrame::IntrinsicISizeOffsets for resolving padding/margin.

This is needed only for CSS Grid since in other cases we're only using IntrinsicISizeOffsets in the inline-axis and the percentage basis is always indefinite for *intrinsic sizing*. When calculating the intrinsic size of grid items in the grid container's block axis however, we do have a definite size for the grid area in the inline-axis and it should be used per: https://drafts.csswg.org/css-grid/#algo-overview "2. Next, the track sizing algorithm resolves the sizes of the grid rows, using the grid column sizes calculated in the previous step." (Percentage padding/margin for grid items is always resolved against the grid area's inline-size nowadays.)
2019-09-28 23:47:05 -04:00
wolfbeast c8666d1565 Issue #438: Rename coord/coords to originValue/transformOrigin.
For clarity and to prevent typoes.
2019-08-14 13:46:25 +02:00
wolfbeast 4bb5a957fb Issue #438: Pixel-snap subpixel value for outer SVG and anon child.
This doesn't solve the blurriness yet, but is part of the problem.
2019-08-14 13:38:25 +02:00
wolfbeast 0d530b1ca2 Issue #438: Do not round the translation of an SVG frame.
This doesn't solve the blurriness yet, but is part of the problem.
2019-08-14 13:35:08 +02:00
win7-7 248476f94e Outdated comment removal (no code changes)
No code changes.
2019-08-02 16:31:54 +03:00
wolfbeast 7979df5512 Revert "Capture delayed events and cancel as necessary."
Tag #1052 (backout).
Backed out for creating issues like #1191 and other issue-less problems
with e.g. losing the caret from text boxes. Of note: this was also
backed out from m-c for similar reasons in Bug 1332433.
This fixes #1191.
This reverts commit 3424afccae.
2019-07-18 19:21:07 +02:00
win7-7 a059b0688b Fix comments for Frameproperties
https://bugzilla.mozilla.org/show_bug.cgi?id=1373884

Fixes comments for Frameproperties.

These comments went unnoticed earlier.

No code changes.
2019-07-12 00:30:22 +03:00
win7-7 570cad8279 Iterate the frame property list once to collect which child list properties we have
Look into optimizing out the hashtable lookups from nsContainerFrame
2019-07-08 19:19:56 +03:00
win7-7 e0598b0ae2 Avoid multiple hashtable lookups in DisplayItemData destructor
UXP has:

MOZ_RELEASE_ASSERT(sAliveDisplayItemDatas && sAliveDisplayItemDatas >Contains(this));
  sAliveDisplayItemDatas->RemoveEntry(this);

and this gets hit during frame destruction.

Combine these checks.
2019-07-07 20:02:35 +03:00
win7-7 00812e30df Attach FrameProperties to each frame instead of using a shared hashtable
Dispense the shared hashtable and instead attach the frame property list directly to nsIFrame.
2019-06-26 01:51:45 +03:00
wolfbeast f47d45be4b Revert "Improve origin-clean algorithm"
This reverts commit e69b3f567c.
2019-06-04 23:58:47 +02:00
wolfbeast fb1b45e5fc Improve origin-clean algorithm 2019-05-27 19:19:27 +02:00
win7-7 622ad88c5d Lots of time spent maintaining nsDisplayLayerEventRegions (#1116)
* Simplify the dispatch-to-content region

Simplify the dispatch-to-content region in nsDisplayLayerEventRegions::AddFrame() and AddInactiveScrollPort() if it starts to get large.

* tabs to spaces
2019-05-24 17:00:07 +00:00
Moonchild 650585f03c Merge pull request #1071 from win7-7/nsDisplayListBuilder
nsFrameList::GetLength() calls in nsDisplayListBuilder::MarkFramesForDisplayList() are slow
2019-05-03 00:44:28 +00:00
win7-7 99d111ad89 unnecessary space at the end removed 2019-05-02 16:53:08 +03:00
win7-7 9b750203d0 patch to Bug 1377329 2019-05-02 16:51:25 +03:00
win7-7 7975665f6a patch to Bug 1363423 2019-05-02 16:47:23 +03:00
wolfbeast 3424afccae Capture delayed events and cancel as necessary.
Tag #1052
2019-04-26 14:13:32 +02:00
wolfbeast 5ea1d913c2 Grab caching capturing content with local variable. 2019-03-23 10:20:01 +01:00
JustOff 96dfb2e6df The result of adding any percentage factor to a size that is zero should also be zero 2019-03-21 21:45:08 +02:00
wolfbeast 3029dee77b Add nullcheck for frames in FindNearestCommonAncestorFrame
This resolves #978.
2019-02-18 22:24:29 +01:00
yami b241a84d88 issue #908 - implement missing parts of CSS mask 2019-02-02 18:06:10 +01:00
adeshkp 5335681cd2 Telemetry: Remove stubs and related code 2019-01-12 06:20:31 -05:00
trav90 96258a022a Only disallow lazy frame construction for direct children of display: contents elements 2018-12-09 09:45:24 -06:00
wolfbeast 6e48f5e140 Make caret width normal/thick behind CJK char configurable.
Fixes #820 (regression).
2018-10-07 19:46:00 +02:00
wolfbeast 81b341a9b3 Clean up a number of unused variables.
Tag #21.
2018-09-29 23:20:36 +02:00
wolfbeast 69b88dfccc Bug 1470260 - Part 2: Make RefreshDriverTimer ref-counted and hold a strong ref on it on the stack when nsRefreshDriver::Tick can be reached. 2018-09-10 22:22:16 +02:00
wolfbeast 4c1f33b169 Bug 1470260 - Part 1: Ensure that 'this' stays alive for the duration of the TickRefreshDriver call. 2018-09-10 22:12:07 +02:00
wolfbeast 93cae908bc Remove all C++ telemetry autotimers 2018-09-04 09:41:24 +02:00
wolfbeast ab961aeb54 Remove all C++ Telemetry Accumulation calls.
This creates a number of stubs and leaves some surrounding code that may be irrelevant (eg. recorded time stamps, status variables).
Stub resolution/removal should be a follow-up to this.
2018-09-03 10:11:38 +02:00
trav90 26f02a2001 Avoid using memset on a not-trivial type like nsTabSizes
nsTabSizes is non-trivial only because of the user-defined constructor.  The idea desired here is certainly to zero all the members without listing them -- but the very act of doing so with a user-defined constructor, makes the idea impossible.

Arguably this is something that is permissible in the language, and that the warning should be tailored to permit.  I don't think this falls afoul of any of the issues flagged in https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01527.html for example.  In the meantime, just explicitly zeroing the three member fields is easy and fixes the warnings.
2018-08-18 15:10:01 -05:00
wolfbeast dc9d933d81 Add pref to control CanOptimizeToImageLayer for large downscale factors.
This resolves #626
2018-07-14 07:45:06 +02:00
janekptacijarabaci 71a1c47759 Fix Build Bustage - with "--enable-debug" 2018-07-12 12:34:59 +02:00
wolfbeast ac25827a87 Remove SPS profiler.
- Conditionals and code blocks. (MOZ_ENABLE_PROFILER_SPS)
- Stub out several profiler-only functions.
2018-05-24 14:06:04 +02:00
janekptacijarabaci d1184bfb49 Bug 1379762 part 2. Use a more reliable test to figure out when we can skip firing onload in nsDocumentViewer::LoadComplete
Issue #357
2018-05-15 22:45:40 +02:00
janekptacijarabaci e968422d29 Bug 1379762 part 1. Don't call MediaFeaturesChanged if our override device pixel ratio is set to its current value
Issue #357
2018-05-15 21:14:18 +02:00