Since these are just interpreted comments, there's 0 impact on actual code.
This removes all lines that match /* vim: set(.*)tw=80: */ with S&R -- there are
a few others scattered around which will be removed manually in a second part.
This creates a number of stubs and leaves some surrounding code that may be irrelevant (eg. recorded time stamps, status variables).
Stub resolution/removal should be a follow-up to this.
After calling mResult.SetLength(mData.Length() + 16) we should check
that the integer addition didn't overflow. It seems at the moment
impossible to create ArrayBuffers of size >= 0x0xfffffff0, however
adding a check here doesn't hurt.
mResult.Length() is passed to the PK11 API functions as a
maxOut parameter and should be checked by the
softoken crypto algorithm implementations.
AES-ECB and AES-GCM seem to do that correctly.
Brian Smith
Moonchild
wolfbeast
roytam1