import changes from `dev' branch of rmottola/Arctic-Fox:

- Bug 1166847 followup: Add 'override' annotation to some new overriding methods in jswrapper.h. rs=ehsan (20a3e9857)
- pointer style (b13f08224)
- Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj (c8fa9e836)
- Bug 1156398: Pass ProcessOrientation.cpp's unused-by-default bools to mozilla::unused. r=mwu (e1200be54)
- Bug 1159124 - Suppress -Wunused-exception-parameter warning in nsClipboard.mm. r=spohl (dc3c4c4d0)
- Bug 1152921 - Always initialize platform-specific booleans in PrintData before sending over IPC. r=mconley (45fb8cf07)
- Bug 1091112 - Serialize nsIPrintSettings options bitfield. r=jimm (17d38b152)
- Bug 1091112 - Add OS X-specific members to PrintData IPDL struct. r=jimm (62182eb24)
- Bug 1091112 - Proxy opening the print dialog on OS X to the parent. r=mstange (adf38a12a)
- Bug 1204398 - Fix -Wshadow warnings in widget/cocoa. r=spohl (9c4f43861)
- missing bits of Bug 1193038: Purposely leak StatisticsReport object and suppress the leak report r=glandium,mccr8,njn (cc0c1a908)
- Bug 1144580 - Whitelist pselect6 in content seccomp-bpf policy. r=kang (144c67d00)
- Bug 1144514 - Whitelist pread64 in content seccomp-bpf policy. r=kang (c01f7f65c)
- Bug 1055310 - Step 1: Convert seccomp-bpf policies to Chromium PolicyCompiler. r=kang (8fbf648ba)
- Bug 1055310 - Step 2: Move SIGSYS handling to Chromium TrapRegistry. r=kang (e80ff13a6)
- Bug 1055310 - Step 3: Move syscall interceptions into SandboxFilter.cpp. r=kang (59c0b2454)
- Bug 1004011 - Support SECCOMP_FILTER_FLAG_TSYNC if available. r=kang (cf97070a9)
- Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium. (c9df97498)
- Bug 1189125 - Allow xpcshell to use GTK (r=karlt) (e363a27aa)
- Bug 830801 - Part 1. Set NOMINMAX define as default. r=mshal (88fa52e9e)
- Bug 830801 - Part 3. Remove NOMINMAX define from cpp source. r=mshal (c841b399f)
- Bug 1169433 - Remove UnicharSelfTest and turn NormalizationTest into a gtest. r=glandium,smontagu (625dcaf32)
- Bug 1170072 - Part 1. Make GetCharProps1 as static function. r=jfkthame (6ab8b7c4f)
- Bug 1183209 patch 2: update data generation tools to Unicode 8, r=jfkthame (78e91de20)
- Bug 1183209 patch 3: update generated data files to Unicode 8, and adapt internal XIDMOD types to the new types in Unicode's xidmodifications.txt, r=jfkthame (c9fea054f)

python/mozbuild/mozbuild/frontend/context.py

@@ -608,6 +608,15 @@ SUBCONTEXTS = {cls.__name__: cls for cls in SUBCONTEXTS}
 # A value of None means the variable has no direct effect on any tier.
 
 VARIABLES = {
+    'ALLOW_COMPILER_WARNINGS': (bool, bool,
+        """Whether to allow compiler warnings (i.e. *not* treat them as
+        errors).
+
+        This is commonplace (almost mandatory, in fact) in directories
+        containing third-party code that we regularly update from upstream and
+        thus do not control, but is otherwise discouraged.
+        """, None),
+
     # Variables controlling reading of other frontend files.
     'ANDROID_GENERATED_RESFILES': (StrictOrderingOnAppendList, list,
         """Android resource files generated as part of the build.
@@ -848,10 +857,6 @@ VARIABLES = {
         ``BIN_SUFFIX``, the name will remain unchanged.
         """, None),
 
-    'FAIL_ON_WARNINGS': (bool, bool,
-        """Whether to treat warnings as errors.
-        """, None),
-
     'FORCE_SHARED_LIB': (bool, bool,
         """Whether the library in this directory is a shared library.
         """, None),

python/mozbuild/mozbuild/frontend/emitter.py

@@ -543,13 +543,13 @@ class TreeMetadataEmitter(LoggingMixin):
         # desired abstraction of the build definition away from makefiles.
         passthru = VariablePassthru(context)
         varlist = [
+            'ALLOW_COMPILER_WARNINGS',
             'ANDROID_GENERATED_RESFILES',
             'ANDROID_RES_DIRS',
             'DISABLE_STL_WRAPPING',
             'EXTRA_COMPONENTS',
             'EXTRA_DSO_LDOPTS',
             'EXTRA_PP_COMPONENTS',
-            'FAIL_ON_WARNINGS',
             'USE_STATIC_LIBS',
             'PYTHON_UNIT_TESTS',
             'RCFILE',

python/mozbuild/mozbuild/test/backend/data/variable_passthru/moz.build

@@ -5,7 +5,6 @@
 EXTRA_COMPONENTS = ['bar.js', 'foo.js']
 EXTRA_PP_COMPONENTS = ['bar.pp.js', 'foo.pp.js']
 
-FAIL_ON_WARNINGS = True
 NO_VISIBILITY_FLAGS = True
 
 DELAYLOAD_DLLS = ['foo.dll', 'bar.dll']
@@ -23,3 +22,5 @@ LDFLAGS += ['-framework Foo', '-x']
 WIN32_EXE_LDFLAGS += ['-subsystem:console']
 
 DISABLE_STL_WRAPPING = True
+
+ALLOW_COMPILER_WARNINGS = True

python/mozbuild/mozbuild/test/backend/test_recursivemake.py

@@ -260,6 +260,9 @@ class TestRecursiveMakeBackend(BackendTester):
         lines = [l.strip() for l in open(backend_path, 'rt').readlines()[2:]]
 
         expected = {
+            'ALLOW_COMPILER_WARNINGS': [
+                'ALLOW_COMPILER_WARNINGS := 1',
+            ],
             'DISABLE_STL_WRAPPING': [
                 'DISABLE_STL_WRAPPING := 1',
             ],
@@ -271,9 +274,6 @@ class TestRecursiveMakeBackend(BackendTester):
                 'EXTRA_PP_COMPONENTS += bar.pp.js',
                 'EXTRA_PP_COMPONENTS += foo.pp.js',
             ],
-            'FAIL_ON_WARNINGS': [
-                'FAIL_ON_WARNINGS := 1',
-            ],
             'VISIBILITY_FLAGS': [
                 'VISIBILITY_FLAGS :=',
             ],

python/mozbuild/mozbuild/test/frontend/data/variable-passthru/moz.build

@@ -5,8 +5,6 @@
 EXTRA_COMPONENTS=['fans.js', 'tans.js']
 EXTRA_PP_COMPONENTS=['fans.pp.js', 'tans.pp.js']
 
-FAIL_ON_WARNINGS = True
-
 DIST_INSTALL = False
 
 NO_VISIBILITY_FLAGS = True
@@ -26,3 +24,5 @@ LDFLAGS += ['-framework Foo', '-x']
 WIN32_EXE_LDFLAGS += ['-subsystem:console']
 
 DISABLE_STL_WRAPPING = True
+
+ALLOW_COMPILER_WARNINGS = True

python/mozbuild/mozbuild/test/frontend/test_emitter.py

@@ -159,10 +159,10 @@ class TestEmitterBasic(unittest.TestCase):
         self.assertIsInstance(objs[0], VariablePassthru)
 
         wanted = {
+            'ALLOW_COMPILER_WARNINGS': True,
             'DISABLE_STL_WRAPPING': True,
             'EXTRA_COMPONENTS': ['fans.js', 'tans.js'],
             'EXTRA_PP_COMPONENTS': ['fans.pp.js', 'tans.pp.js'],
-            'FAIL_ON_WARNINGS': True,
             'NO_DIST_INSTALL': True,
             'VISIBILITY_FLAGS': '',
             'RCFILE': 'foo.rc',