mirror of
https://github.com/roytam1/palemoon27.git
synced 2026-05-26 14:30:27 +00:00
3a02ab4d4d
- Bug 1131308 (part 0) - Fix minor problems with RemovingIterator. r=froydnj. (5c232c9ca)
- Bug 1176163 - Remove remaining uses of PL_DHashTableEnumerate() from xpcom/. r=froydnj. (bd2478b3a)
- Bug 1179657 - Remove PL_DHASHMETER. r=froydnj. (30f581478)
- Bug 1131308 (part 1) - Improve PLDHashTable's internal checking. r=froydnj. (faba4a3b9)
- Bug 1180084 - Convert TestPLDHash.cpp to a gtest. r=froydnj. (de6ee3c5c)
- Bug 1171578 - Avoid crashing if indexedDB is used at a particular point in the worker shutdown sequence, r=baku. (f325c218e)
- Bug 804975 - Part 1: Expose WritingMode bits. r=dbaron (0635d01dd)
- Bug 1072101 - Part 1: Implement FontFaceSet.size. r=peterv (7e0b4848a)
- Bug 1144977 - Part 1: Don't include FontFace objects in more than one loadingdone/loadingerror event. r=jdaggett (4d10b3269)
- Bug 1072101 - Part 2: Implement FontFaceSet.{entries,values}. r=peterv (1c636f4f1)
- Bug 1072101 - Part 3: Implement FontFaceSet.forEach. r=peterv (842a5cdbe)
- Bug 1072101 - Part 4: Implement FontFaceSet.{keys,@@iterator}. r=peterv (4dfb3afe9)
- Bug 1072101 - Part 5: Remove indexed property access on FontFaceSet. r=peterv (edef47d70)
- Bug 1072101 - Unified build fix; no review. (7c1538f6c)
- Bug 861449 - Incremental css::Rule destroyer. r=dbaron (5e60f4394)
- Bug 1175800 - Remove typedefs from nsComputedDOMStyle.cpp as they interfere with others under unified compilation. r=bzbarsky (2bd45e7ed)
- Bug 1147766 - Part 1: Add a mozilla::RangedArray class, for fixed length arrays with a non-zero base index. r=waldo (42be428bc)
- Bug 1147766 - Part 2: Replace FixedStyleStructArray with mozilla::RangedArray. r=dbaron (4d28a0a5e)
- Bug 1171282 - Avoid some unnecessary |operator new| null-checks in layout/. r=dholbert. (60e1690c1)
- Bug 1168664 - Stop mistakenly using the transform reference box's width to calculate the Z component in ProcessMatrix3D. r=mattwoodrow (18f9021b1)
- Bug 1171842 - Use jump table instead of nested if statements for peeking compute function of style struct. r=dbaron (a5160b962)
- Bug 1170173 - Parse CSS 'contain' property. r=dholbert (3d8a37dee)
- Bug 1144607 part 1 - Remove CounterStyleManager::BuildCounterStyle for anonymous counter styles. r=dbaron (331397d01)
- Bug 1144607 part 2 - Support string value for list-style-tyle. r=dbaron (0b4bca0c7)
- Bug 1144607 part 3 - Reftests for string value on list-style-type. r=dbaron (2a483f621)
- Bug 1144607 followup - Fix submitted reftest for string value of list-style-type. DONTBUILD (ad23ac443)
- Bug 1151220 - [css-grid] Fix a couple of typos in InitializeTrackSize. r=dholbert (840f3b8a4)
- Bug 1151201 - [css-grid] Update parsing of 'auto' in track-sizing functions to latest version of the spec. r=simon.sapin (abdb0c0ea)
278 lines
8.7 KiB
C++
278 lines
8.7 KiB
C++
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim:set ts=2 sw=2 sts=2 et cindent: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "pldhash.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
// This test mostly focuses on edge cases. But more coverage of normal
|
|
// operations wouldn't be a bad thing.
|
|
|
|
TEST(PLDHashTableTest, InitCapacityOk)
|
|
{
|
|
// Try the largest allowed capacity. With PL_DHASH_MAX_CAPACITY==1<<26, this
|
|
// would allocate (if we added an element) 0.5GB of entry store on 32-bit
|
|
// platforms and 1GB on 64-bit platforms.
|
|
//
|
|
// Ideally we'd also try (a) a too-large capacity, and (b) a large capacity
|
|
// combined with a large entry size that when multipled overflow. But those
|
|
// cases would cause the test to abort immediately.
|
|
//
|
|
// Furthermore, ideally we'd also try a large-but-ok capacity that almost but
|
|
// doesn't quite overflow, but that would result in allocating just under 4GB
|
|
// of entry storage. That's very likely to fail on 32-bit platforms, so such
|
|
// a test wouldn't be reliable.
|
|
//
|
|
PLDHashTable t(PL_DHashGetStubOps(), sizeof(PLDHashEntryStub),
|
|
PL_DHASH_MAX_INITIAL_LENGTH);
|
|
}
|
|
|
|
TEST(PLDHashTableTest, LazyStorage)
|
|
{
|
|
PLDHashTable t(PL_DHashGetStubOps(), sizeof(PLDHashEntryStub));
|
|
|
|
// PLDHashTable allocates entry storage lazily. Check that all the non-add
|
|
// operations work appropriately when the table is empty and the storage
|
|
// hasn't yet been allocated.
|
|
|
|
ASSERT_EQ(t.Capacity(), 0u);
|
|
ASSERT_EQ(t.EntrySize(), sizeof(PLDHashEntryStub));
|
|
ASSERT_EQ(t.EntryCount(), 0u);
|
|
ASSERT_EQ(t.Generation(), 0u);
|
|
|
|
ASSERT_TRUE(!PL_DHashTableSearch(&t, (const void*)1));
|
|
|
|
// No result to check here, but call it to make sure it doesn't crash.
|
|
PL_DHashTableRemove(&t, (const void*)2);
|
|
|
|
for (auto iter = t.Iter(); !iter.Done(); iter.Next()) {
|
|
ASSERT_TRUE(false); // shouldn't hit this on an empty table
|
|
}
|
|
|
|
for (auto iter = t.RemovingIter(); !iter.Done(); iter.Next()) {
|
|
ASSERT_TRUE(false); // shouldn't hit this on an empty table
|
|
}
|
|
|
|
// Using a null |mallocSizeOf| should be fine because it shouldn't be called
|
|
// for an empty table.
|
|
mozilla::MallocSizeOf mallocSizeOf = nullptr;
|
|
ASSERT_EQ(PL_DHashTableSizeOfExcludingThis(&t, nullptr, mallocSizeOf), 0u);
|
|
}
|
|
|
|
// A trivial hash function is good enough here. It's also super-fast for
|
|
// test_pldhash_grow_to_max_capacity() because we insert the integers 0..,
|
|
// which means it's collision-free.
|
|
static PLDHashNumber
|
|
TrivialHash(PLDHashTable *table, const void *key)
|
|
{
|
|
return (PLDHashNumber)(size_t)key;
|
|
}
|
|
|
|
static void
|
|
TrivialInitEntry(PLDHashEntryHdr* aEntry, const void* aKey)
|
|
{
|
|
auto entry = static_cast<PLDHashEntryStub*>(aEntry);
|
|
entry->key = aKey;
|
|
}
|
|
|
|
static const PLDHashTableOps trivialOps = {
|
|
TrivialHash,
|
|
PL_DHashMatchEntryStub,
|
|
PL_DHashMoveEntryStub,
|
|
PL_DHashClearEntryStub,
|
|
TrivialInitEntry
|
|
};
|
|
|
|
TEST(PLDHashTableTest, MoveSemantics)
|
|
{
|
|
PLDHashTable t1(&trivialOps, sizeof(PLDHashEntryStub));
|
|
PL_DHashTableAdd(&t1, (const void*)88);
|
|
PLDHashTable t2(&trivialOps, sizeof(PLDHashEntryStub));
|
|
PL_DHashTableAdd(&t2, (const void*)99);
|
|
|
|
t1 = mozilla::Move(t1); // self-move
|
|
|
|
t1 = mozilla::Move(t2); // empty overwritten with empty
|
|
|
|
PLDHashTable t3(&trivialOps, sizeof(PLDHashEntryStub));
|
|
PLDHashTable t4(&trivialOps, sizeof(PLDHashEntryStub));
|
|
PL_DHashTableAdd(&t3, (const void*)88);
|
|
|
|
t3 = mozilla::Move(t4); // non-empty overwritten with empty
|
|
|
|
PLDHashTable t5(&trivialOps, sizeof(PLDHashEntryStub));
|
|
PLDHashTable t6(&trivialOps, sizeof(PLDHashEntryStub));
|
|
PL_DHashTableAdd(&t6, (const void*)88);
|
|
|
|
t5 = mozilla::Move(t6); // empty overwritten with non-empty
|
|
|
|
PLDHashTable t7(&trivialOps, sizeof(PLDHashEntryStub));
|
|
PLDHashTable t8(mozilla::Move(t7)); // new table constructed with uninited
|
|
|
|
PLDHashTable t9(&trivialOps, sizeof(PLDHashEntryStub));
|
|
PL_DHashTableAdd(&t9, (const void*)88);
|
|
PLDHashTable t10(mozilla::Move(t9)); // new table constructed with inited
|
|
}
|
|
|
|
TEST(PLDHashTableTest, Clear)
|
|
{
|
|
PLDHashTable t1(&trivialOps, sizeof(PLDHashEntryStub));
|
|
|
|
t1.Clear();
|
|
ASSERT_EQ(t1.EntryCount(), 0u);
|
|
|
|
t1.ClearAndPrepareForLength(100);
|
|
ASSERT_EQ(t1.EntryCount(), 0u);
|
|
|
|
PL_DHashTableAdd(&t1, (const void*)77);
|
|
PL_DHashTableAdd(&t1, (const void*)88);
|
|
PL_DHashTableAdd(&t1, (const void*)99);
|
|
ASSERT_EQ(t1.EntryCount(), 3u);
|
|
|
|
t1.Clear();
|
|
ASSERT_EQ(t1.EntryCount(), 0u);
|
|
|
|
PL_DHashTableAdd(&t1, (const void*)55);
|
|
PL_DHashTableAdd(&t1, (const void*)66);
|
|
PL_DHashTableAdd(&t1, (const void*)77);
|
|
PL_DHashTableAdd(&t1, (const void*)88);
|
|
PL_DHashTableAdd(&t1, (const void*)99);
|
|
ASSERT_EQ(t1.EntryCount(), 5u);
|
|
|
|
t1.ClearAndPrepareForLength(8192);
|
|
ASSERT_EQ(t1.EntryCount(), 0u);
|
|
}
|
|
|
|
TEST(PLDHashTableIterator, Iterator)
|
|
{
|
|
PLDHashTable t(&trivialOps, sizeof(PLDHashEntryStub));
|
|
|
|
// Explicitly test the move constructor. We do this because, due to copy
|
|
// elision, compilers might optimize away move constructor calls for normal
|
|
// iterator use.
|
|
{
|
|
PLDHashTable::Iterator iter1(&t);
|
|
PLDHashTable::Iterator iter2(mozilla::Move(iter1));
|
|
}
|
|
|
|
// Iterate through the empty table.
|
|
for (PLDHashTable::Iterator iter(&t); !iter.Done(); iter.Next()) {
|
|
(void) iter.Get();
|
|
ASSERT_TRUE(false); // shouldn't hit this
|
|
}
|
|
|
|
// Add three entries.
|
|
PL_DHashTableAdd(&t, (const void*)77);
|
|
PL_DHashTableAdd(&t, (const void*)88);
|
|
PL_DHashTableAdd(&t, (const void*)99);
|
|
|
|
// Check the iterator goes through each entry once.
|
|
bool saw77 = false, saw88 = false, saw99 = false;
|
|
int n = 0;
|
|
for (auto iter(t.Iter()); !iter.Done(); iter.Next()) {
|
|
auto entry = static_cast<PLDHashEntryStub*>(iter.Get());
|
|
if (entry->key == (const void*)77) {
|
|
saw77 = true;
|
|
}
|
|
if (entry->key == (const void*)88) {
|
|
saw88 = true;
|
|
}
|
|
if (entry->key == (const void*)99) {
|
|
saw99 = true;
|
|
}
|
|
n++;
|
|
}
|
|
ASSERT_TRUE(saw77 && saw88 && saw99 && n == 3);
|
|
}
|
|
|
|
TEST(PLDHashTableTest, RemovingIterator)
|
|
{
|
|
PLDHashTable t(&trivialOps, sizeof(PLDHashEntryStub));
|
|
|
|
// Explicitly test the move constructor. We do this because, due to copy
|
|
// elision, compilers might optimize away move constructor calls for normal
|
|
// iterator use.
|
|
{
|
|
PLDHashTable::RemovingIterator iter1(&t);
|
|
PLDHashTable::RemovingIterator iter2(mozilla::Move(iter1));
|
|
}
|
|
|
|
// First, we insert 64 items, which results in a capacity of 128, and a load
|
|
// factor of 50%.
|
|
for (intptr_t i = 0; i < 64; i++) {
|
|
PL_DHashTableAdd(&t, (const void*)i);
|
|
}
|
|
ASSERT_EQ(t.EntryCount(), 64u);
|
|
ASSERT_EQ(t.Capacity(), 128u);
|
|
|
|
// The first removing iterator does no removing; capacity and entry count are
|
|
// unchanged.
|
|
for (PLDHashTable::RemovingIterator iter(&t); !iter.Done(); iter.Next()) {
|
|
(void) iter.Get();
|
|
}
|
|
ASSERT_EQ(t.EntryCount(), 64u);
|
|
ASSERT_EQ(t.Capacity(), 128u);
|
|
|
|
// The second removing iterator removes 16 items. This reduces the load
|
|
// factor to 37.5% (48 / 128), which isn't low enough to shrink the table.
|
|
for (auto iter = t.RemovingIter(); !iter.Done(); iter.Next()) {
|
|
auto entry = static_cast<PLDHashEntryStub*>(iter.Get());
|
|
if ((intptr_t)(entry->key) % 4 == 0) {
|
|
iter.Remove();
|
|
}
|
|
}
|
|
ASSERT_EQ(t.EntryCount(), 48u);
|
|
ASSERT_EQ(t.Capacity(), 128u);
|
|
|
|
// The third removing iterator removes another 16 items. This reduces
|
|
// the load factor to 25% (32 / 128), so the table is shrunk.
|
|
for (auto iter = t.RemovingIter(); !iter.Done(); iter.Next()) {
|
|
auto entry = static_cast<PLDHashEntryStub*>(iter.Get());
|
|
if ((intptr_t)(entry->key) % 2 == 0) {
|
|
iter.Remove();
|
|
}
|
|
}
|
|
ASSERT_EQ(t.EntryCount(), 32u);
|
|
ASSERT_EQ(t.Capacity(), 64u);
|
|
|
|
// The fourth removing iterator removes all remaining items. This reduces
|
|
// the capacity to the minimum.
|
|
for (auto iter = t.RemovingIter(); !iter.Done(); iter.Next()) {
|
|
iter.Remove();
|
|
}
|
|
ASSERT_EQ(t.EntryCount(), 0u);
|
|
ASSERT_EQ(t.Capacity(), unsigned(PL_DHASH_MIN_CAPACITY));
|
|
}
|
|
|
|
// See bug 931062, we skip this test on Android due to OOM. Also, it's slow,
|
|
// and so should always be last.
|
|
#ifndef MOZ_WIDGET_ANDROID
|
|
TEST(PLDHashTableTest, GrowToMaxCapacity)
|
|
{
|
|
// This is infallible.
|
|
PLDHashTable* t =
|
|
new PLDHashTable(&trivialOps, sizeof(PLDHashEntryStub), 128);
|
|
|
|
// Keep inserting elements until failure occurs because the table is full.
|
|
size_t numInserted = 0;
|
|
while (true) {
|
|
if (!PL_DHashTableAdd(t, (const void*)numInserted, mozilla::fallible)) {
|
|
break;
|
|
}
|
|
numInserted++;
|
|
}
|
|
|
|
// We stop when the element count is 96.875% of PL_DHASH_MAX_SIZE (see
|
|
// MaxLoadOnGrowthFailure()).
|
|
if (numInserted != PL_DHASH_MAX_CAPACITY - (PL_DHASH_MAX_CAPACITY >> 5)) {
|
|
delete t;
|
|
ASSERT_TRUE(false);
|
|
}
|
|
|
|
delete t;
|
|
}
|
|
#endif
|
|
|