I don't want this merged as soon as, I'd just rather normal drones to go away if no-one offers to fix their broken state.
Going to see if I can find out from someone how to edit maps tomorrow to remove the dispensers from them since you can't make them and I swear I've seen them before.
remove any way to obtain drones outside the dispenser
remove dispenser from maps
Edit: To better explain for the sake of a good PR body and a lack of a link to the PR a day ago, drones have been in the code in roughly the same state for 3 years (dispenser PR by Xhuis is missing from GitHub) and have gained laws admins enforce when they notice drones doing the wrong thing due to it being a ghost role. The code verbally dictates this will happen. The role hasn't been coded to prevent these many wrong things and has weak balance to begin with being a monkey with a vent ready backpack.
Administration hasn't stopped caring about this role. It should be in their direct hands until the role is clearly not an administration problem and fixed to represent that.
The component is initialized with any combination of three flags, EMP_PROTECT_SELF protects against effects that target the object itself, EMP_PROTECT_WIRES protects against wires being messed with similar to the NO_EMP_WIRES_1 flag which this PR removes, EMP_PROTECT_CONTENTS protects against things that are inside the object like organs, internal "non-virtual" power cells and the like
This enables (but doesn't introduce) new mechanics such as adding EMP shielding at runtime to any atom, or taking it away.
* patch-2
* does everything on the TODO list
FUCK YEAH
*breaks up the engineering node design ID's for readability
*linking the device via multitool is possible
*The machinery construction "recipes" are less shit and make a bit more sense
* coil
* did somebody say RUNTIMES?
*fixed runtimes when there is no link on the stacking machine console
*added feedback for unlinked consoles
*it's -> its
*proper typecheck
* achieved with [src]
The experimentor is less likely to produce food when it transforms an item
The experimentor no longer breaks when the toxic waste malfunction occurs multiple times and isn't cleaned up
The experimentor irridiate function actually chooses what item to make properly rather than picking from the start of the list
The food weight change is because the probweight var wasn't effective because food was added to the list before anything that would increase the var, it's so low because there's a ton of food and it should be possible to get other things. I tested it in game and food is still the most common thing to get, I could bump up the prob for non-food things if needed.
The toxic waste runtime would make the experimentor unfixable except for reconstructing, and that resets the experiments.
The previous method of picking was broken and pretty poorly coded, I moved it to an associative list and the existing and non-broken pickweight function (not sure if this is also a code change).
The total number of assets to be sent has been reduced from 1532 to 76, with time between first asset and last going from about 112s to about 7s (a 93% reduction) by my measure. The following assets have been coalesced:
705 pipe images (used by RPD) -> 1 spritesheet + css
595 research design icons (used by R&D console) -> 3 spritesheets + css
116 OOC emoji + 15 language icons -> 1 spritesheet + css
27 PDA icons -> 1 spritesheet + css
11 paperwork stamps -> 1 spritesheet + css
Why: Anomaly cores have few uses, science could use something combat related as a bribe for RnD now that they dont get any guns, and I want to see engineering pushing the engine towards near meltdown to try and harvest anomalies (would obviously need a way to make those capturable though).
I dont know where to put the node in the "web" really, so suggestions are welcome.
The reactive armour shell accepts anomaly cores to build various armours as follows
Flux - Tesla armour
Pyro - Fire armour
Gravity - Repulse armour (new in this PR)
Bluespace - Teleport Armour
Everything else - Defaults to stealth armour as a fallback
This removal is motivated by both gameplay and technical reasons.
Gameplay:
The stock market being a part of a station's Cargo department does not make sense, for either practical or lore purposes. The mechanic is bad because players are receiving cargo points from literally nothing. There no kind of freight handling or any other sort of bottleneck at all, just number entry on a computer from a seat. The stock market code is quite complex and a good attempt was made at simulating a stock market. However the attempt falls short, as it is still quite easy to manage stocks to grow points passively and safely. The stock market is also a multiplicative source of income so any other cargo point source gets extra scrutiny over balance, undeservedly so. Other aspects of cargo have already repeatedly taken hits. Such nerfs include the decreasing marginal returns for most exports and the base export price of plasma. I've noticed cargo doesn't care as much about exporting plasma as much as they used to.
Technical:
There seems to be a major issue with stock growth, particularly one bug in particular that grows stock prices to astronomical levels. As I mentioned before, the stock market code is quite complex, not to mention long. @Iamgoofball himself does not seem to making an earnest attempt to properly maintain and fix the issues, instead constantly making controversial band-aid fixes and removals (pot, kettle here I know). I would normally make a fix attempt as the code seems interesting but I do not agree with the stock market being a part of the game for gameplay reasons and thus have no interest. I have other ideas for cargo but they are still in the ideas stage so they are worth nothing. Still, I think removing the stock market and making room for other cargo features is the best move.
* kill BANG_PROTECT_2
* let's put this back in
* dirty
* kill OMNITONGUE_2
This is a write-only variable, probably leftover from some refactor years ago
* kill flags_2
only human and lizard synthetic limbs will have should_draw_greyscale set to true
added /improper and uncapitalised synthetic limb names
removed plasmaman parts from human_parts_greyscale.dmi
Tad Hardesty
Jordan Brown
vuonojenmustaturska
Dax Dupont
ShizCalev
Firecage
CosmicScientist
kevinz000
KorPhaeron
pubby
iksyp
AlexTheSysop42
Denton
FrozenGuy5
YPOQ
pigeons
Grandmother of 50
erwgd
oranges
81Denton