About The Pull Request
machines and consoles that previously required an inserted ID now check access on worn and inhand ids. They otherwise function identically.
Affected things:
ORM: click claim to claim cash to connected ID (also fixes it)
Mining vendor: uses ID on person or in hand.
medical console: checks worn ID
security records console: checks worn ID
gulag consoles: claim points to worn ID, checks access and point requirements from worn ID
Also some backend refactoring to prisoner management and gulag teleporter consoles
hop console will be next to strip out the shitcode entirely but this at least gets things functional in the mean time, but fully tested this time. It's very late here and I need to sleep. Due to the nature of it it's more elaborate of a rework.
Changelog
cl
tweak: Medical and Security consoles now check access on worn or inhand ID instead of requiring an inserted ID
tweak: mining vendor now reads from ID in hand or on person instead of requiring an inserted ID
fix: ORM is functional again (for real this time)
tweak: ORM claim points button transfers points to worn/inhand ID instead of to an inserted ID, no longer accepts insertions
tweak: Same for gulag consoles
/cl
About The Pull Request
repaths clothing/under to be more sane
Also fixed a couple of bugs relating to pathing being incorrect, and modified a couple of bad descriptions and names
Also adds a map path updating script, which also helps show the full repath.
Why It's Good For The Game
improves maintainability, makes mapping easier, stages for a clothing dmi split
Changelog
cl
refactor: repathed all under clothing, keep an eye out for errors
/cl
Ever since the big BoH nerf, BoH bombing is kind of a joke. The damage it does is not really huge, and it's lame for traitors - it lacks emotion and their target may not even die, as they can use the ladders to get away.
So, what this does is add back some soul into BoH bombing, while not making it too round-ending and adding some degree of damage control for admins in case of griefing.
When BoH bombing, a stationary singulo with custom sprite will spawn. Its gravitational pull is REALLY strong, so people near it are probably going to get eaten, and there will be some real damage to the hull. The singulo will cease existing after 5 seconds.
For antags, I think this becomes much more interesting than the current BoH bombing. In the case of griefers, the damage to the station isn't too big because the singulo is stationary and fades away after some seconds. And then, admins can click a button in their chat to bring back everything the singulo ate into the game (the button expires in 10 minutes, however, but this can be changed if you think it is needed).
Settings like gravitational pull can be tweaked if yall find it to be too strong or something.
Changelog
cl
tweak: BoH bombing changed again. Now it's more violent.
/cl
* Adds adjustLiverLoss & getLiverLoss procs to carbon
* Adds trophazole
Adds trophazole, a brute healer that makes doctors take a more holistic approach to heal, It is highly reagent efficient by converting nutriment to healing peptides. Creates an avenue for cooperation between kitchen and medbay.
* Adds rhigoxane
Rhigoxane is a chilly burn healer that works best in a spray bottle and is capable of extinguishing fires.
* Adds thializid
This tox healer has great potential and mixability, balanced by requiring the doctor to take note of the patients liver health as well as using proper dilution and an iv pole; that wont fit in a powergamers pocket.
* Charcoal + trans_to changes
Makes charcoal only work when ingested, and adds a new proc in reagent holder, lets trans_to react the transferred reagents if a method is chosen.
* Medical + Syndicate spray bottles
Medical spray bottles have been added to techweb under the biotech node for medical vapor application, alt click to change their skin.
Two suspicious spray bottles have been added as expensive contraband items in the chemdrobe. They have one extra spray range and a random suspicious skin from a pool of 8.
The large spray bottle and the space cleaner bottle also have new icons.
In addition trophazole and MMF have new colors.
* Adds chempacks
the IV medicine bag, or chem pack is the blood pack analogue for chems, it is easy to fill like a beaker but can also be permanently sealed to prevent spillage and mitigate tampering. It can be renamed with a pen. Both the new chem pack and the old blood pack have been added to the medical lathe and biotech node.
* Adds recipes to thializid and trophazole
Also fixes the rhigoxane recipe
* Medsprays are now medigels + fixes
chem packs can now be stored in the smartfridge and chem bag.
Medsprays were renamed medigels to reduce confusion. Calling them medical sprays made no sense since they apply chems through the patch method.
The lore for the new medigels is that they spray a thick gel onto the skin that dries into a film.
* minor fixes + mint frosting
I have tried to fix the problems people have pointed out. And the peptides now taste like mint frosting.
* Readds my cleaner sprites
* Adds liver damage to thializid + adds on_transfer proc
Thializid has a liver cost, the cost is worse if you have already sustained liver damage. Fixes weirdness by moving the reagent conversion effects from reaction_mob to on_transfer
* Fixes chem bag examine
The chem bag examine now werks, also fixed a typo in the description.
* Adds a clumsy check to sealing the chem pack
* Makes kelo, bicard and anti-tox unmixable.
I have retained the tricord recipe for now in case someone manages to collect all 3 through non-dispenser means. Think of it like collecting all the dragon balls but lame.
* Makes damp rag apply on_transfer effects
* glass and food now work with trophazole
glasses and food now call the on_transfer proc via trans_to
* Another round of fixes
Replaces 0/1 values with TRUE/FALSE where appropriate. Removes the debug printout from the spray bottle reskin. Replaces one instance of L.damage with C.GetLiverLoss().
* Rhigoxane recipe is now COOLER
200k was too warm since cryostylane cools down so much by itself upon mixing.
Now the chemist has to choose between adding oxygen for instant cooling or using the heater/cooler to conserve energy.
* Removes the seal() proc and moves its guts into AltClick
* Item_state switching moved to reskin_obj
* Fixes missing medical sprayer left inhand
the sprayer_med_yellow inhand sprite now has the correct name.
* Fixes inhand updating
* Update code/modules/mob/living/carbon/damage_procs.dm
Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
* Update code/modules/mob/living/carbon/damage_procs.dm
Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
* Tries to add typecache
* Moves the typecache and makes it static
The donut AI chamber SMES was missing a cable underneath it; that way,
it wouldn't connect to the local APC.
CentCom vault is now secured by the old vault door plus indestructible
shutters that can be removed or opened by admins. In case someone uses
one of the 314432 exploits to get to CentCom, I made the ERT shutters
indestructible and replaced the all access IDs with a box of ID cards.
Fixes medbay intercoms
DoNUT
Delta rad collectors
no free loot, bad powergamer
more duplicate pipes
even more duplicate garbage
I've about had it with these fucking duplicates
donut pipe fix pt2
Cables now autoconnect on cardinal directions. All cable placement has been completely stripped out and replaced with simple single cable per tile logic.
Low effort demo: https://www.youtube.com/watch?v=fXp8s6ORWbA
Yes I am aware that cutting it is not dropping wire, that version was bugged.
Cables no longer need a knot specifically placed to link to power objects. The sprite is automatically changed to represent this.
The only exception to this logic is that on smes units, due to the terminal being next to the output, they will not link there.
On a technical powernet side, this is the same as old cables once actually placed. They still use the existing powernet system, just the placement and connection works differently.
Old cables have been turned into "pipe cleaners" for wire art purposes. they work just like the old ones, just missing all the powernet functionality, and also you can put them on top of the floor.
Why It's Good For The Game
How obnoxious cables were to both map and work with in game has been something that has annoyed me for a really long time now.
This is both easier for new players to learn, and easier for experienced players to work with.
Along with making in game much more intuitive and easier, it makes mapping much easier as well. Mad lad wjohn was able to rip out all the mapping conversion in one day because of how much faster it is to work with.
cl actioninja and wjohn
add: Cables have been completely reworked. Simple per tile connection logic, automatically connects to things above it. Think minecraft redstone.
add: Old cables have been kept as pipe cleaner. They are non-functional in terms of power, but otherwise have the same connection logic. Also can go on top of tiles.
remove: mech cable layer has been removed because it was terrible shitcode nobody used
tweak: (sort of balance) cable stack sized has been reduced to 15.
/cl
Like it says on the tin, mappers no longer need to set the stationary
dock area type as it will use the area type of whatever it starts on.
This is how they all worked anyway, but you can still set it yourself if
you find some very strange usecase for having a different area type.
About The Pull Request
With this PR, the nukies get their TC pre-distributed instead of having to do a complicated song-and-dance routine where people who sort-of know what they're trying try to convince people who don't to put their uplinks into the machines at roughly the same time to press some buttons.
Why It's Good For The Game
The TC donation/distribution cycle is completely unneeded, realistically everyone is going to distribute their TC.
* Adds the rasta beanie
* Added Bishop Mitre
* Added some more religious headgear
Clown Mitre (Hat of the Honkmother)
Kippah
White and Red Taqiyahs
Medieval Jewish Hat
* Fixes icon_state for the Hat of the Honkmother
* Added some new chaplain outfits
Bishop Robe
Monk's Frock (with hood)
Eastern Monk's Robe
White Robe
* Added Robes of the Honkmother
* Added new religion hat icons
Bishop Mitre
Clown Mitre
Kippah
Red and White Taqiyahs
Medieval Jew Hat
Rasta Beanie
* Added new religion suit icons
Bishop Robe
Monk's frock
Eastern Monk's Robe
White robe
* Added new religious suits
* Added new religious headgear
* Added in-hand sprites for new religious suits
* Added new religious clothing to the chaplaindrobe
Includes new premium and contraband objects.
* Added clown priest's robes to premium
* Added some religion follower hats
Kippah
Taqiyah (red)
* Added rastacap to the chaplain vendor
* Fixed obj directory for red taqiyah
* Fixed spelling of "dreadlocks
* Allowed clown robes to hold prank items
* Created .dm for chaplain suits
For easy organization
* Removed clown priest robes
Put them in chaplainsuits.dm
* Moved new chaplain suits
To chaplainsuits.dm
* Moved holiday priest
to chaplainsuits.dm
* Moved holiday priest to chaplainsuits.dm
* Updated suit obj defines, added monk's frock
* Updated obj defines for chaplain suits
* Updated holiday priest obj define
* Updated chaplainsuit obj defines, added white robes
* Fixed subtype define
Man, that was an embarrassing spelling mistake
* Fixed subtype define
For real this time I hope
* Added chaplainsuits.dm
* Fixed clown robes
* Updated holiday priest path
* Updated path for chaplainsuits
* Re-added prank items to clown robe storage
* Updated pathing for chaplain suits on Pubby
* Added comments
Hopefully this will help the AppVeyor check go through
* Adds stasis beds
Needs sprites, using placeholder ones
* Adds stasis beds to techwebs
Cryostasis Technology
* Adds sprites for stasis bed
* Stasis beds support economy/ancap
* Stasis bed can be deconstructed
* Stasis bed requires cable coil
* New stasis bed sprites by @Kmc2000
Made by Kmc2000 <bluekorben2000@yahoo.com>
Not currently functional
* Add unique to SSvis_overlay.add_vis_overlay
will return the overlay object itself and not reuse it
* Make stasis bed art function
can enable/disable with alt click
makes sounds when powering up/down
* The tubes go over the mob now
* Remove sleepers from techweb tree
* Fix stasis bed lying
* Modified stasis bed build requirements
* Survival pod version of stasis bed
Map spawned sleepers delete their circuit boards
Added stasis beds to 'doctors' phobia
NanoMed for survival pod which is always free, not refillable
* Replace sleepers with stasis beds on all station maps
removed all sleeper machine boards from maps
one sleeper machine board intentionally left alone in oldstation
* Fix stasis bed tube overlay capturing clicks
Give power up and down noise freq variation
* Remove stat check from living Life
* Remove vis overlay assertions from stasis bed
Revamped Donutstation's engineering and supermatter rooms to fix a number
of issues that prevented proper functionality, and resolved numerous
aesthetic complaints.
Fixed Jones actions on a couple away mission fridges.
* add a new holodeck program: photobooth
* Add two paint buckets and three spray cans to the booth
* remove step_ variables
* made the photobooth floor white again, we got buckets for that anyway
* retrigger ci
Removes access restriction on fridges and meat fridges in areas where you
shouldn't be expected to have kitchen access. Notably, everywhere that is not
the main station kitchen. I didn't think to check this in #41923.
* reeling it in
* Revert "reeling it in"
This reverts commit 2b795a8baf5eec89fdc1e6b6a6ef9d36276c2e62.
* adds the room
* makes the boobs more seeable
* WHAT IS CONSISTENT PROC NAME FORMATTING FUCK FUCK FUCK
* adds fluff sign and fixes map a tiny bit
* small updates
* fuck FUCK YOUR MERGE CONFLICT FUCK
cl actioninja\memager
refactor: Ballistic guns have been almost entirely reworked from a backend side. This primarily focused on moving as much as possible into the base ballistic gun and turning as many other guns into essentially varedits as possible.
add: Guns can now be racked. This is the default action unless the magazine is empty.
add: Guns now can have the magazine removed by clicking on them with an open hand while they are in hand.
tweak: Suppressors are now removed by alt clicking instead of clicking with an open hand
add: Guns now have various bolt types that all function a bit differently. Open bolts cannot have a bullet chambered with no mag, locking bolts lock back after running out of ammo, etc.
add: All ballistic gun sounds are controlled by variables instead of hardcoded usages.
tweak: The l6 LMG has a reworked control scheme. alt + click to open and close the cover, open hand to remove mag, place mag in by slapping them together, default action is rack.
tweak: Functionality that used to be snowflake code such as tactical reloads has been moved to the base gun, and can be toggled by variables.
refactor: All shotguns are now properly subpaths of the shotgun type. They still work the same.
imagedel: Gun sprites have been almost entirely overhauled to use overlays instead of states. This collapsed the L6 sprite from 20 sprites to 9 sprites to give an example.
soundadd: Remixed versions of the shotgun and base gun firesound
soundadd: New rifle firesound for l6 and moist nugget, new SMG fire sound, new sniper fire sound.
soundadd: Lots of new weapon operation sounds such as racking and bolts and the like.
imageadd: New sprites for the Riot Shotgun, Combat Shotgun, c20r, Deagle, m90, double barrel shotgun and 1911 by Memager.
imageadd: All gun sprites that were pointing to the left have been flipped to point to the right.
balance: Shotguns now can be pumped faster.
balance: Bulldog can now be tac reloaded
balance: Sawn off shotguns now have an accuracy penalty and recoil
/cl
🆑 coiax
tweak: Bartenders now gain their ability to "booze slide" from their
beer googles, rather than from a granter book in their backpacks.
/🆑
Less action button clutter, the ability to disable it if required (at
the cost of style), still keeping it possible for non-roundstart bartenders
(provided of course, you have the shades for it), as well as a less
janky way of checking than just looking through someone's action
buttons.
Had to touch a lot of maps because their directions were wrong in the icons
file, so when I changed those every map that had these needed updating. I've
added a script called cornersfix to mapmerge2/map_scripts for downstream
servers.
* reeling it in
* Revert "reeling it in"
This reverts commit 2b795a8baf5eec89fdc1e6b6a6ef9d36276c2e62.
* ya dun know
* huhuhuh tiny fan
* Tweak tangentially related formatting
* Update code/modules/cargo/centcom_podlauncher.dm
Co-Authored-By: MrDoomBringer <emmanuelssr@gmail.com>
cl
add: Entertainment telescreens in the bar indicate when they will show something interesting.
tweak: Entertainment telescreens can be viewed from a distance.
/cl
Bargoers are now informed both visually and in chat when clicking on the thunderdome telescreens is likely to actually show something interesting. Additionally, thunderdome telescreens can be watched without being directly adjacent (think sports bar TVs).
* Nuclear operatives have a christmas tree during the festive season
🆑 coiax
add: Nuclear operatives have a Christmas tree during the festive season.
/🆑
Minor buff to nuke ops during the Christmas period when trees have presents,
as they'll have access to random items just like the crew.
* Adds a second lightbulb to the bathroom
* Christmas tree SPAWNERS rather than LANDMARKS
Fixes#40440
cl MrDoomBringer
fix: The ceres shuttle will no longer overlap with centcom. The architects responsible for this issue have been sternly reprimanded.
/cl
scooches over the supplypod bay by a few tiles. Also added a little more fluff to the centcom pod bay.
Fixed vareditted bonfires not properly igniting at round start.
Fixed vareditted pianos switching to minimoogs at round start.
Fixed some vareddited flashlights not turning on properly at round start.
Fixed all missing floor icons
Fixed bookcases at the Wild West away mission not being properly populated.
Fixes missing icon in DM for syndie playing cards.
Added support to change the burning icon of bonfires (right now there's the
normal on_fire and warm states, warm being more of a burning embers sort of
deal.)
MrDoomBringer
admin: Admins can now spawn things in ICly (as well as do a bunch of other cool new stuff) using the Config/Launch Supplypod verb!
code: also supplypods have been refactored
* Converts all colored plasteel tiles to turf decals.
* Removes now deprecated floor icons and paths.
* Hotfixes on three maps.
* Moves script to its own folder.
* Fixes wild west.
* Fixes holodeck
* Fixes eye rape bug.
* Fixes meta and lavaland biodome ruin having some missing textures.
New titanium floors! The intent here was to reduce the eye strain that the current max saturation fuckbois have, and make some floor tiles people might actually consider using. Right now the options are still pretty limited with blue, yellow etc only coming in full tiles, and I expect this will remain so until an actual greyscale rework comes along that shrinks the file size down from its bloated 4,000 sprites to something more reasonable and modular. Decals, perhaps?
The CentCom recovery shuttle (where escape pods dock) is so close to the space
ninja prison that players can see indestructible wooden walls from it.
I moved it a little further south, so it's not as immersion breaking.
Now that shuttles are all loaded via template we no longer have a need for the
timid var on shuttles.
Well not all shuttles, it seems I forgot to template the backup shuttle so it
wouldn't have been working until now. This got fixed here as well.
Mickyan
Rob Bailey
Denton
nicbn
nemvar
actioninja
Krysonism
oranges
Emmett Gaines
AarontheIdiot
kittymaster0
loser
vuonojenmustaturska
Farquaar
JJRcop
Tad Hardesty
ShizCalev
Strommer Kilian
Tlaltecuhtli
skoglol
MrDoomBringer
Jack Edge
WJohn