About The Pull Request
This PR finally splits up the ways that borgs are supposed to initiate inventory checks of a mobs and initiate attempts to buckle mobs to themselves (formerly, they would both happen upon click+dragging a mob onto yourself as a borg). Now a borg will only try to buckle a mob to themself if they ARE NOT on harm intent when they finish click+dragging said mob onto themself, and will only try to check a mob's inventory if they ARE on harm intent when they finish click+dragging said mob onto themself. An outsider can still buckle someone (even themself) to a borg who's on harm intent; the borg just can't do it themself.
Why It's Good For The Game
This issue is incredibly annoying to deal with as a borg (especially if you're in an area or situation where *spinning someone off of you could be risky), and I'm really surprised that it's taken this long for this control conflict to be fixed.
Changelog
cl ATHATH
tweak: If a cyborg click+drags someone onto themself, they will only try to buckle that person to themself if they (the cyborg) ARE NOT on harm intent. Attempts made by non-cyborgs to buckle themselves to cyborgs by click+dragging themselves onto said cyborgs should be unaffected by this change, even if those cyborgs are on harm intent.
tweak: If a cyborg click+drags someone onto themself, they will only attempt to check that person's inventory if they (the cyborg) ARE on harm intent.
/cl
About The Pull Request
does what says on title, becomes a securitron that can shoot people
removes ed209 cell because it doesnt do anything why does it even exist
fixes ed209 crafting using dragnets
sadly, removes lasertag mode from ed209, but ive never seen anyone use it and it made everything a lot more confusing
eds now shoot you even if youre lying down because i guess that you could rest before to avoid getting shot but im not 100% sure
Why It's Good For The Game
fixes tons of horrifying copypaste
also fixes some minor things
Changelog
cl
del: Lasertag EDs have been removed
code: EDs are now not a horrifying mess of copypasted securitron code
balance: EDs now still shoot you if you're lying down
tweak: you no longer need a battery to make an ed209
fix: fixes ed209 crafting using dragnets instead of disablers
/cl
* Blindness removes colours so you can only see if an object is near, not the fine points on it.
* Fixed up the monochromatic trait to persist when removing blindness
* Removed added trait and created new colour filter for blindness
* Blankspace Removal
* removed the src before the proc as it was not needed
* Reverts italics-span back to no color.
* Cleans up many extra spaces and indents.
* Adds 'hear' span class.
* Replaces all 'italics' used in heard messages with 'hear'.
* Makes nanites be passed down when jellypeople and slimes split
* Trying to change how nanite splitting works, currently this is broken and disallows splitting of slimes and jellypeople
* Still doesn't work, jellypeople code fails at the L1 check
* Nanites now pass on properly, but sync needs a rework. Get component might be the right way to do it after all
* preparing for revert
* Reverting, I think
* I don't know how revert works, making activation copy over as well
* Removing an unneccesary proccall
* Update medbot.dm
* romance of the three medbots
* no longer requires unique ID
* Revert "no longer requires unique ID"
This reverts commit 3349140f3779f8e694e14d1c2a170ff5d3105a56.
* sometimes i can code ok
* Update medbot.dm
* duh
* Update unsorted.dm
* Update unsorted.dm
* Fuck Git pushing and Fuck Git pulling
PR machine broke, had to resubmit
* Update food_reagents.dm
* Major fixes and error fixes for nemvar
* fixed a missing type path part
* expanded scope of protection while increasing protection needed
* spacing error
* adds new variable, pepperproof to check for immunity to pepperspray
* adds another protection variable EYESPEPPERPROOF
* Revert "adds another protection variable EYESPEPPERPROOF"
This reverts commit b9f3682f7c47a157008d565620f8cdcffece145a.
* fixes and reverts to better and easier time
* small formatting fixes
* null checking
* Update living_defense.dm
Combat defibrillator has halved recharge time. This allows it to both
stun people more quickly, and actually be able to cause a heart attack
with harm intent during the stun.
It also has unique, mediocre sprites by Me. Syndicate duffel bag
sprites altered slightly so the little med/ammo icon is tilted.
I randomly found out combat defibs could actually be used offensively
while testing things, but they were both a tad slow to recharge and had
what was practically an undocumented feature that I've never seen
anyone use. This PR points out that they can be used in combat, and
buffs them appropriately so a nuclear operative could reasonably use
it, at the cost of sacrificing their belt slot and their offhand.
* Selectively randomisable characters
* it's a list now
* this doesn't work
* it's totally fucking fucked mate big time
* it works
* so sick of this goddamn pull request and yes i know this is a retarded way to do this it didn't work the other way
* anturk forestalls the inevitable suicide
'associative lists are more performant'
* final changes anturk requested
'remove all the "in randomise" and it's ready'
About The Pull Request
removes duplicate if statement in a switch that is there for no reason. It already happens on line 95.
Why It's Good For The Game
???
Changelog
cl
code: removed duplicate code
/cl
* Turns digital camo into an element
* Removes commented out code.
* Keep forgetting this
* Update code/datums/elements/digitalcamo.dm
Co-Authored-By: Rob Bailey <actioninja@gmail.com>
* ED209's aggro when you throw things at them and no longer die to shocked grilles
* fixed an extra line
* runtimes in the waiting
* runtimes cant stop the law
About The Pull Request
Converts every single usage of playsound's vary parameter to use the boolean define instead of 1 or 0. I'm tired of people copypasting the incorrect usage.
Also changes a couple of places where a list was picked from instead of using get_sfx internal calls
This was done via regex:
(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\)) to match 1
(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\)) to match 0
full sed commands:
/(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\))/\1TRUE\2/ 1 to TRUE
/(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\))/\1FALSE\2/ 0 to FALSE
I'm not very good with regex and these could probably be optimized, but they worked.
Why It's Good For The Game
Code usability
* You can no longer give the AI laws containing IC filtered words. Adds a proc to accomplish this.
* turns proc into a define, adds it to hacked module because I forgot
About The Pull Request
Splits the previous single dmi used for all under items/uniforms into 17 separate dmis
Why It's Good For The Game
makes icon conflicts when developing much less likely.
About The Pull Request
Adds 'notice' span class to all visible_messages which had no span class, making all those black messages blue.
Why It's Good For The Game
This should help differentiate action-messages from talking-messages in the chat. More actions will be blue, thus black talking-messages should pop out more.
Changes some stuff in mech code:
state renamed to construction_state
magic state numbers changed to defines
mechadefines moved into their own file as well as putting a MECHA in front of every single one to avoid conflicts (a define just called MELEE is a dumb idea)
tool interactions in attackby moved to tool_acts
Why It's Good For The Game
I still haven't given up on saving mech code.
About The Pull Request
Drone shells have been refactored to use mob spawners, and now show up in the ghost spawner menu. Seasonal hats were sacrificed in the process. The spawners are also anchored to prevent players moving them off the derelict.
The derelict drone flavor text and laws have been relaxed slightly, and made more clear as to whats allowed for derelict drones in particular. Effectively: drones are not allowed to leave KS13, the no interaction restriction has been limited to sentient beings, and interaction is now allowed while on KS13. Going to the main station for any reason is explicitly disallowed.
image
The derelict itself has gotten a slight overhaul to make fixing it slightly more feasible. There is a vault you can get into after setting up power which contains materials to help fix KS13. The amount of air mix has been greatly increased.
Why It's Good For The Game
The derelict has great potential for allowing players to learn about construction, as well as taking up the challenge of properly fixing the station. These changes makes that more realistically achievable without relying on random asteroid spawns close by that you werent really supposed to go harvest from.
Fixes#30379
Changelog
cl Skoglol & Naloac
tweak: Make Kosmicheskaya Stantsiya 13 great again! No I mean it, go do it. The derelict has gotten a slight overhaul, and it is now more feasible.
tweak: Derelict drones has had their laws laxed slightly while on the derelict. It should now be harder to be forced into breaking them.
refactor: Drone shells are now mob spawners and show up in the ghost spawner window.
/cl
About The Pull Request
Completely removes item_color and the clusterfuck of bad programming it caused.
In places where item_color was used for entirely unique purposes it was split off and renamed to a new var on that typepath only, or refactored so it wasn't needed
In places where item_color was used as a dye color, it was converted to the new dye_color var
In places where item_color was used as the worn overlay it was removed and instead now icon_state is always used as the clothing overlay.
A new mob_overlay_icon var was added for manually setting where the mob overlay icon path is for specific items.
Moved some mob overlay files relating to clothing to their own directory as well for organization purposes.
Totally refactors washing machines, instead of the horrible abortion that was iterating through the typepath it now uses a registry of dye results.
Some bonus functionality to come out of this:
the washing machine now supports arbitrary dye colors.
Why It's Good For The Game
It's been 4 years since the "this should be deprecated soonish" comment was added, and this var is a shitpile of confusion if you just trace the usage of it.
Changelog
cl
add: Washing machines now support arbitrary dye color
add: Washing machines now dye nearly every item.
refactor: lots of backend changes to clothing overlays, report any issues
/cl
* HEY RACISM GOT A SPRITE ACCESSORY FOR YA
* angel + dragonborn > givespeciesflight
* more review stuff
* last of the review stuff
* compile
* readds my fix
* Boolean numero uno
* Boolean numero dos
ATH1909
Fikou
Mickyan
nightred
variableundefined
spookydonut
Nichlas Pihl
skoglol
kingofkosmos
Unknown
Dingo-Dongler
GuyonBroadway
kevinz000
Rodey125
moo
MacBlaze1
wesoda25
carlarctg
nemvar
cacogen
Fhaxaris
Dawson1917
Rob Bailey
bgobandit
tralezab
loser
plapatin