Commit Graph

32636 Commits

Author SHA1 Message Date
Qustinnus 2c8489af26 s-s-s-spaghetti to newfood (#53574)
🆑 Qustinnus
code: Moves spaghetti to new food
fix: Fixes some more size problems on food
fix: Fixes organs having wrong params
/🆑

fixes #53482 fixes #53572
2020-09-16 02:49:06 +01:00
Timberpoes 393ad935ea Fixes issue where self-resp and enabling Godmode may not clear the suffocating moodlet (#53715)
Clears suffocation-related flags while the user doesn't need to breathe due to the self-resp virus symptom or Godmode.
2020-09-15 19:22:17 -04:00
Timberpoes 96f4c2f4ad Fix two gas assertion runtimes (#53718)
/datum/gas_mixture/proc/remove(amount) has a code path that can return null.

All the code following the runtimes assume some bit of gas_mixture was actually removed at all. No need to trigger this code if there's no gas_mixture removed, can early return instead.
2020-09-15 19:21:11 -04:00
Timberpoes 6f2bcf879a Add additional info to a runtime situation to be able to handle it better in the future. (#53727)
Added two CRASHes for two areas where this could go wrong to better understand what and why this is happening.
2020-09-15 19:16:10 -04:00
Timberpoes b8ce0aa519 Cyborg inventory runtime fix. (#53741)
Following the cyborg inventory refactor, code changed a bit.

Cyborg inventory screens are inited in the HUD, however AI Shells don't generate a HUD until an AI assumes direct control.

Damaging an AI shell before the AI created a HUD in it would cause runtimes as modules disabled and enabled.

To remedy this, we now initialize the core inventory slots on the robit Init() and then update them as necessary in the HUD code later on if an AI ever deigns to grace your shell with their exalted presence instead of asking for it and then never using it.
2020-09-15 19:04:09 -04:00
EdgeLordExe 1765037329 Nerfs Flashes [Edge Awards 2020] (#53604)
Flashes now deal stamina damage and micro-stun, they deal higher damage than batons BUT they have a severe disadavntage in form of directionality. Stamina damage and the duration of the micro stun is determined by direction your enemy is facing.
2020-09-15 20:14:01 +01:00
spookydonut c711270a38 Fix ventcrawling bug I merged (#53704)
#53672 introduced a bug because held_items always has the same number of indexes as the mob has hands
2020-09-15 18:58:52 +01:00
Jared-Fogle 77a07b5866 Prevent smashing of light tubes onto fixtures (#53705)
Previously, if you tried to put in a light tube at any point before fully finishing the fixture, it would break the light tube. This is no longer the case, and it will now simply prevent you from putting it in.
2020-09-15 18:57:30 +01:00
PolishUser 4f597c97c7 Breadcat (#53609)
* Introducing Bread Cat

* Introducing Bread Cat

* Introducing Bread Cat

* Message

* Introducing Bread Cat

* Naming

* Crafting + Return

* H

* hnnnng

* Why are we still here?

Co-authored-by: PolishUser <fakemail@fake.com>
2020-09-15 13:36:32 -04:00
EdgeLordExe f9ef6d13d4 Edge's Explosive Balancing Patch [v4] (#53468)
* E

* Update pyrotechnics.dm

* E

* Update code/modules/reagents/chemistry/recipes/pyrotechnics.dm

Co-authored-by: girl <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>

Co-authored-by: girl <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
2020-09-15 09:55:01 -04:00
Couls 75cdfc88f6 Optimize stat panel and fix guardian verbs (#53463)
Optimizes stat panel code for better performance, including icon caching and removing some unnecessary processing
Also fixes #53432
fix #53381
fix #53724
Changelog

add: icons are back on alt clicks
fix: horrible performance from alt clicking turfs with multiple objects
tweak:browser should notify the SS when it's ready to receive data

* Update statbrowser.html

* Apply suggestions from code review

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>

* hidden = TRUE

* almost ready

* Browser should notify when ready to receive data

* Apply MSO's suggestions

* reset cache if something in it gets deleted

* Fix runtime

* fix my stupid code

* send href_token when adding admin tabs

* fix an issue with cyborg suit topic

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-09-14 23:36:46 -07:00
Timberpoes ddc9e7d7ee Add a confirmation for harvesting Replica Pods with associated ckeys/minds that aren't ready to be revived. (#53567)
* Early return logic, add alert

* Robustify code.

* Minor tweak.

* Interaction check
2020-09-14 10:57:42 -04:00
Mike Long 93b8626a2c Makes the syndicate syringe gun start with a syringe loaded. (#53656) 2020-09-14 10:49:55 -04:00
Putnam3145 d556f4a740 Unbads ventcrawling. (#53672) 2020-09-14 16:56:22 +08:00
TiviPlus 9f153219d0 cleanup (#53677) 2020-09-14 16:55:17 +08:00
Jimmius a9c538fbc9 Airlock Seals 2: I'm dumb and a fool edition (#53114)
Adds door seals to the game, inspired by the ones used in Alien Isolation and SOMA. Trivially easy for a human to remove, but makes it a nightmare to try and smash through if you're an alien, an evil robot, or don't have hands. I also slightly changed how airlock reinforcement works, as now there are two ways to increase the integrity, the previous way of just resetting the max_integrity after the removal of the plating wouldn't work.
2020-09-13 16:12:02 +01:00
Tad Hardesty 899a9e04cb Fix some missing Initialize hints (#53566)
* Fix some missing initialize hints

* Whitelist /mob/dview not calling /atom/Initialize()

* Better idea
2020-09-13 20:34:12 +08:00
TiviPlus e7d0c30523 Random whiteship selection (#53603)
Breaks shit if the deprecated map pr is merged before/after without me fixing it so only merge one of those
2020-09-13 07:44:21 +01:00
SamuelRowe 19ef3b3fa0 Fixes mixer and filter icon_states, Part 2. (#53625)
Fixes invalid default icon_states that caused issues with mapping utils such as SDMM.
2020-09-13 03:45:18 +01:00
Wallemations 11073f55ec Fixes some issues with sign language & makes some things more clear (#53610)
Changes the name of the recipe for the gloves to make them more clear
Adds a note in the tongue file to make sure it's clear you SHOULDN'T SEE THAT TONGUE.
Adds a unique chat message for mimes who use sign language, to make it clearer you can't cheese as a mime
Adds a unique slurring verb for drunkards
Removes the ability for sign languagers to use megaphones, which I forgot existed in the game. 
Punctuation removal now replaces all punctuation used with periods rather than with blank space, to reduce run-on sentences.
2020-09-12 18:57:49 -07:00
Arkatos1 4b2cf6520c Guide to Dank Radials (#53616)
This PR makes Guides to Dank Mimery use a radial menu as a method for choosing mime spells, instead of using an outdated html browser menu. Old book text was moved to the item description instead, to make it clear what it does.
2020-09-13 02:55:17 +01:00
Tad Hardesty 67f9ea771a Remove outdated shuttle import landmark (#53642)
Cleaning up after #44676
2020-09-13 02:52:18 +01:00
tralezab 867b5fef1e Makes Ice Box Botany Cozy as Fuck [MULTI-Z] [FUCK CABLE HUBS] (#53627)
Makes botany down a zlevel, gives them an exit so they can collect plants on the ice moon...
2020-09-13 00:50:09 +01:00
Ghilker fb7b23cf4d tgui: Temperature Gate (#53632)
* new device, temperature gate

* added necessary examine on device

* better description(?)
2020-09-13 00:37:40 +03:00
Ghilker 02c09813c6 tgui: Temperature Pump (#53608)
* new item, temperature pump

* tgui bundle build

* requested changes
2020-09-13 00:00:14 +03:00
msgerbs fb010a1dea Fix mechs not using power to move, gygax leg actuator button not matching actual state, and mechpads not working (#53624)
Fixes these issues with mechs:

    Mechs aren't using power to move (broken in #52902)
    Gygax leg actuator button is opposite of what it should be (off when it should be on) (broken in #52902)
    Mechpads don't actually send mechs
    None of the error messages for failing to move work
2020-09-12 18:16:14 +01:00
UnlimitedVanillaWorks 036b1ffa72 Atmos grammar fixes (#53628)
Some grammar/spelling changes in the descriptions of recent atmos additions.
2020-09-12 15:39:31 +01:00
msgerbs 5fffce5d2d Adds better feedback related to husks (#53599)
Husks currently have basically zero ingame feedback other than the grey sprite. It should be abundantly obvious when somebody is a husk, given that it's such a huge physical change that it changes the sprite. This PR adds examine text to husks, and adds a message to the health scanner. The regular scanner will only tell you that they are a husk, the advanced scanner will tell you if they were husked by burns or by "extreme fluid loss" AKA lings (but burnt takes precedence so you can still burn your ling corpses to a crisp to help hide your tracks). The defib now also gives a message specifically for husks instead of a generic "tissue damage" message which normally means brute/burn damage.

I also updated the description of sythflesh and rezadone to mention that they can restore burnt husks, and replaced some hardcoded "burn" with the BURN constant.
2020-09-12 03:13:18 +01:00
NightRed 6197be5bf3 Organ removal ends metabolizing reagents in the organ (#53619)
If an organ contains reagents it will end metabolizing them on removal.
2020-09-12 01:45:46 +01:00
silicons 78b94a98b9 fixes xenobio camera runtimes (#53618)
code was trying to bitwise & with an area instance instead of the flags of said instance
2020-09-12 01:43:56 +01:00
EdgeLordExe 8204b71573 Smart Pipes : Mapping Revolution [Golden Edge Awards 2020 Edition] (#53530)
Adds a mapping helper for piping, it works on all layers, works on all colors, and it autoconnects to other pipe devices. making it extremely useful.

Making mapping less of a massive fucking clusterfuck of burnout is always good.

Mappers can now use Smart Pipes, pipes that autoconnect to other pipes, like redstone! MAPPERS ONLY!
2020-09-11 15:59:10 -07:00
LemonInTheDark dc725f4b66 Merge pull request #53620 from Dennok/connector-cap-fix
Fix connector double cap. Now really. (Lemon's note, the last fix didn't properly well, fix things. Wrong arguments being passed, ect. this should do it, as it properly clears old overlays now.)
fix #53437

bugs is bad
2020-09-11 14:03:11 -07:00
msgerbs dde45a406d Fixes several things not unlocking when hit with an ID in a tablet. (#53600)
The following will now be unlockable by hitting them with an ID in a tablet:

    Bots
    Express supply console
    Air Alarms
2020-09-11 18:43:53 +01:00
Rohesie 457a3bb414 limb disabled refactor (#53374)
Fixes #53219
    Nukes is_disabled()
    Turns several variable value changes into events.
    bodypart_disabled turned into a boolean value.
    BODYPART_DISABLED_WOUND turned into TRAIT_DISABLED_BY_WOUND. Not the cleanest thing out there, but it works.
    Cleans some code and reduces number of updates, as only the extremities have a disabled effect.
2020-09-11 17:59:09 +01:00
Jared-Fogle 751328a2ba Fix chemicals not recognizing end of metabolization (#53550)
* Fix chemicals not recognizing end of metabolization

* Make generic to all organs
2020-09-11 09:41:42 -04:00
Timberpoes 5bc1753dd0 Fixes pretty much all spells having 10 times longer cooldowns than intended. (#53598)
* Feex

* It's Delta Time!

* Someone smarter than I has spoken!
2020-09-11 12:44:57 +02:00
msgerbs f91dd961aa Adds NO_ALERT flag to areas, refactors area alerts slightly (#53487)
Adds a NO_ALERTS flag for areas and adds it to most off-station area types. Up until now, whether or not an area should trigger alerts has been a snowflakey mix of ALWAYS_UNPOWERED and outdoors, with some smattering of other conditions thrown in. This unifies it all behind a single bitflag so it's easy to make sure an area does not send alerts to the station consoles. I also refactored alerts slightly so they make sense (state = 1 means not alerting? Seriously??), removed an unnecessary override of poweralm from some lavaland areas which probably doesn't do what somebody thought it does, and removes an old snowflaky override of power alarms in engineering which is a leftover from the singulo days. As an additional side effect, off-station fire alarms can now properly work locally (previously, the entire fire alarm did not work if it wasn't on the station. Now they work but just won't send alarms)
2020-09-11 04:31:42 +01:00
Mickyan 7e4e9d432d Adds rollerskates, wheely can do tricks (#53497)
This turns wheelys into a skateboard subtype so they are no longer a copy paste of old skateboard code. They have lower stability compared to skateboards.
I've also made a whole bunch of small adjustments in the process to make skateboard code cleaner and more modular, such as turning the improvised skateboard to its own subtype so that construction steps don't need to be overwritten for all subtypes

Adds two subtypes of wheelys:
-Rollerskates: more stable than wheelys but slow you down when the wheels are retracted
-Skishoes: For skiing! Only work on snow, obviously

I wanted to add some fun alternatives to skateboards with their own drawbacks, and the ski shoes were an opportunity to do something fun for icemoon maps
2020-09-11 04:14:00 +01:00
zxaber 53c85f5d48 Fixes a runtime for ModPCs running Plexagon Access Management without a secondary card slot (#53597)
As said by the title.

Also fixes an oversight where the Plexagon HR Core app (job management) was reading worn ID rather than inserted ID.

Also adds names to differentiate between primary and secondary card readers so both show on the screwdriver remove menu.

Also makes using IDs on a modPC actually call the InsertID proc, so that having the secondary ID come first in the list of parts doesn't give it priority.
Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com>
2020-09-11 03:26:39 +01:00
TiviPlus f64085240d Fix sleep lint and use tabs in hilberthotel.dm (#53586) 2020-09-10 18:21:11 -07:00
Jared-Fogle 04a42f08b0 Add feedback for alt clicking atmos machinery (#53510)
When you alt click atmos machinery, you will usually do something along the lines of maxing out the pressure output on a pressure pump.

This adds a chat message when you do.
2020-09-11 01:43:34 +01:00
ArcaneMusic 224b87e55d Adds native chilly peppers to icebox flora. (#53544)
Now, icebox has a native plant that can be picked on the surface level, where the sunlight reaches highest, and rarely seen underground, and provides you chilly peppers. Traditionally a chili pepper mutation, the theme was close enough that I felt it'd be a good fit for the map, and helps break up the monotony of the map being ice, rock, and more ice with some harvest able flora.
2020-09-11 01:16:07 +01:00
Jared-Fogle 0c8bf36548 Remove references to old singularity machines (#53509)
Removes the singularity generator and the particle accelerator. The former had no sprite, and the latter only existed because of a leftover type path. This does not affect gameplay at all.

Removes the "Start Singularity" verb that was only intended for debug use.

Fixes #53508.
2020-09-11 01:08:43 +01:00
Jared-Fogle 55adfd3804 Fix seeing surgeries while blind (#53500)
Fixes #53295.
2020-09-11 00:28:02 +01:00
Dennok 074e5fba22 connector cap fix 2020-09-11 00:17:46 +03:00
AnturK a55d5439e9 Fixes tests on master. Maybe. (#53613) 2020-09-10 19:16:41 +01:00
Emmanuel S 953e337eb3 Pod launcher renaissance squash (#52611)
Refactoring of Flex, Fix Section scrollable

Getting presets working


wip


Upgrade dependencies

preset notice, tooltip fixes, pod spawnlocation fixes


finishes UI, final polish


quells one travismoment


Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>
better var names


better vars


sound for loop


Further review addressing


runtime fixes


Update code/modules/asset_cache/asset_list_items.dm

Co-authored-by: Rohesie <rohesie@gmail.com>
More review addressing


tgui merge


why was that there


Small improvements


Small Improvements Part 2


dropoff / wall moving improvements


compile!


more fixes
2020-09-10 20:22:47 +03:00
ShizCalev 5c318c0a2f Merge pull request #53578 from msgerbs/air-alarm-fix
Fixes air alarm operating modes not working
2020-09-10 13:18:43 -04:00
ATH1909 1007abcec5 fixes a copy+paste error in synthcode (#53573)
handle_body() was called when handle_mutant_bodyparts() should have been called instead. I've fixed this issue.

I've also doc'd the disguise_fail_health variable, because the comment that's currently next to it doesn't accurately describe what the variable actually does.
2020-09-10 13:08:53 -04:00
Dennok ec914d0135 Fix portable_atmospherics runtiming on mapload (#53575) 2020-09-10 13:07:21 -04:00