About The Pull Request
As title, except a clarification: sounds that play with no source or direction are still stereo due to that the stereo will actually do something and not just be wasted space.
On a technical level, what I actually did was reexport (nearly) every single sound effect to mono 44.1khz sample rate Ogg at quality preset 5. This resulted in some small increases in file size in some places but other than that reduced file size across the board.
A couple of sounds that were wavs for whatever reason were also converted to ogg, this resulted in some code changes to change the referenced sound effect.
Some sounds were also recut. The grille hit and punches in particular are common sounds that had large and noticeable gaps at the beginning.
All of this has resulted in the compiled rsc file going from 102.7 mb to 83.2 mb.
Why It's Good For The Game
Free space with no (effective) drop in quality.
A standard for audio going forward. (that will be inevitably ignored)
Tighter sounds in some places.
Changelog
cl
soundadd: Downmixed every sound to mono. This shouldn't have resulted in any changes in audio, byond downmixes anyways.
soundadd: Recut some sounds. Sounds shouldn't have large silent/noise gaps at the start anymore
/cl
* Gave service headsets to jobs that report to HoP (not assistants, obviously). Created a headset and encryptionkey for lawyers that is sec service (similar to genetics)
* Typo
* Less copypasta more sensemaking
I'm doing a lot of work on the pAI stuff right now and mad props to
whoever set the loudness booster up, but this typo is killing me every
time I see it.
* Adds Champagne, Bug Spray, and Wizz Fizz
Three new drinks. How did we not have champagne already?
* REEEE COMMA
REEEEE
* Fixing stupid mistake and beginning BUG fixing
Observe good pun
* Less direct referencing of vars and defines
Also screaming
* Adds applejack, fixes small errors in coloration
Horsepuns HONK
* Adds sprites, includes sprites for bottles of champagne/applejack
Does what it says on the tin.
* Adds sprites.
* Fixes champagne and applejack being nice drinks.
* Adds bottles for the new pure drinks
Does not add them to the boozeomatic yet.
* Switches to Nemvar/Kryson sprites
These are better. Also it means wizz fizz is animated.
* nerfs bugspray
* Nerfs Wizzfizz and Bugspray, adds Jack Rose
see title
* Changes how wiz is checked, removes vestigal code, FUCK
* Changes screaming to on_mob_add like ATATH suggested earlier and cleans up healing code
*scream
* Adds applejack and Champagne to Booze-o-mat
* [SDQL2] Adds selector arrays
* SDQL2 documentation spec updated slightly
* SDQL2 selector array docs + tweaks
If a single list is the only result of a MAP statement,
meaning objs.len == 1, AND it's a list, it will unwrap
the result from its containing list and return it directly.
The selector array logic keeps track of the state of the query
when it starts the first Search. It won't change the state back
to Execute until the top-level is reached, which sets a var
to keep track.
* SDQL2 MAP change from objs.len to length(objs)
* [SDQL2] Reverts MAP list unwrap
* [SDQL] Move (expr) from expr, unary_expr to var
This should result in the same functionality but instead of expressions and unary_expressions processing sub expressions, variables do
This means that expression->value->variable is now completely recursable
* [SDQL2] Update selector list documentation
adds logging to spraybottle usage. spraying in general is logged in game to track people spreading plasma/lube/whatever. theres transferring reagents to people via spraying logged in attack.
It seems it was intended to make movement cost a bit of hunger per tile,
but was actually only happening while you were floating (despite the
comment saying it should be easy).
This reverses that so it's now working as intended.
Testing shows this increases nutrition by about 5.6 per minute of
non-stop (non-floating) running movement. Walking cuts this cost by more
than half as not only do you cover fewer tiles in a minute, but walking
also costs half as much in tile-tile movement.
If you're on meth, expect to get quite hungry from zooming around the
station like a madman at 300 mph, which I think makes quite a bit of
sense.
* FuCK
* Beret Resprites
* e
* Adds the archaic and vintage berets.
* Grammar fix.
Just misspelled allegedly.
* Grammar fix.
* Modifies the beret to bring it a bit more off the eye.
By default (assuming the department based exp lockout config is enabled), hos requires 5 hours as security. but the captain only requires 3 hours as crew?
Seems silly.
@iamgoofball I wonder if banned accounts still get notifications.
Somebody with more time than me: make the config for these use a keyed list for per-job overrides, rather than a flat head override.
Somebody else with more time than me: make a config that allows readying for time restricted roles anyways, but only at low priority.
Sometimes a reason 1 restart will work to fix these for servers without
tgs3.
This works on tgs3 even though the api sleeps, this will likely not work on
tgs4. In those cases the world/Reboot call will likely still bring the
server back up to a functional point that an admin can do a tgs restart via
the verb.
There is no point in attempting to notify clients, every attempt at doing
so failed.
I found that when the valve of a canister was closed, the
.../canister/process_atmos proc would never reach its update_icon call.
I've fixed that by removing the early return and having a single
update_icon call at the end run when necessary.
Space cleaner sprayed, splashed or vaporised onto someone will slightly
improve their hygiene. Effective janitors can spray stinky spessmen to
stave off the stench long enough for the offender to have a shower. Space
cleaner will only stop you from stinking for a short time, unlike a shower
which will keep you fresh for much longer.
The amount of cleanliness from a single application of space cleaner is
capped, so a chemist dumping a bluespace beaker of space cleaner on their
head is not going to be as effective as a shower.
Giving janitors an extra way to help the crew is probably good, especially
because this additional mechanic can't be replaced by janiborgs or
cleanbots.
A lot of equipment can be placed on the back and belt slot. Much of this
equipment is job specific. Sadly, the Clown and Mime have been left out
of the fun.
Why should all the other jobs have the fun of belt and back slots?
Sometimes you want to mosey around the station like a honkin' cowboy,
your bikehorn clipped securely to your belt. Now you can. Your trusty
honkshooter is ready to go. DRAW!
Or maybe you're a Mime who wants his crusty baguette saber at his side.
EN GARDE!