Commit Graph

5071 Commits

Author SHA1 Message Date
Fhaxaris c6759b6ceb Fixes all explicit occurrences of rand() being used incorrectly. (#48732)
It doesn't return non whole numbers just because you gave it a range of non whole numbers. So don't do that.
2020-01-12 00:20:38 -05:00
MrPerson e22560a346 update_icon() improvements (#48669)
* update_icon() improvements

Fixes some update_icon() calls to properly call parent and use update_overlays() and update_icon_state().

The rest of obj/item fuck it

* Suggested fixes, also passes the linter

* I always forget . = ..() is faster than return ..() FOR SOME FUCKING REASON

* Actually this is better

* Signilzes datum/action to update its icon when its connected item does.
2020-01-11 23:46:43 -05:00
Fikou 8eee742734 [Ready] Adds ERP (#48699)
Adds a new emergency response team, the ERP! It stands for Emergency Response Party

the ERP includes:
-the coordinator: basically the captain of the operation, armed with a birthday cake, balloon and lots of fireworks to start the celebration
-the bouncer: the big boy, has a telebaton and an armor vest (if youre a loser you get a police hat too)
-the constructor: has tools, materials to build the party, disco tiles and an ethereal disco ball planter
-the cleaning service: your normal jannie, with his trusty mop, trash bag and cleaning grenades
-the comedian: a clown, armed with instruments, a bananium shield and chameleon suit/hat, for some comedy at the party
2020-01-12 13:31:13 +13:00
skoglol 284c0fec72 Merge pull request #48702 from LudwigVonChesterfield/tactical_fix
Fixing a small typo in tactical.dm
2020-01-11 05:42:10 +01:00
LemonInTheDark f4f8a686df Makes grounding rods consistent, changes the supermatters bolts a great deal. (#48472)
* Goof I will find you and I will berate you

holy hell

Calm and peaceful ahhhhh

I swear goofs pc failing was the biggest tragedy in gaming

Fixes some flags

More touchups

Now to squash

Goofs PC failing was the biggest tragady in GAMING

* Fixing some misspellings before the bee gets me

* GOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF

* Full vehicle support

* Changes some flags around, "fixes" some bugs, makes being shocked less insane

* Makes spliting more reasonable, unfucks some shitty tesla code I copypasta'd into the sm, godspeed shitcode,
none noticed you.

* Removes my tesla_ignore_1 fix, another pr is up that should solve things, so we're just leaving it in for now,
gonna have to deal with merge conflicts when it gets merged, but that won't be too bad

* tfw

* Nothing to see here folks

* I'm a boomer
2020-01-10 23:25:11 +11:00
wesoda25 030303d952 Ethereals now discharge electricity if their charge is too high (#48573)
* if this works i will be happy

* :(

* explosion

* brutemod

* george melons
2020-01-10 23:14:41 +11:00
Jordie 3ef6beb0d9 Merge pull request #48637 from Ghommie/Ghommie-tg14
Fixes traitor codewords highlight and some other hear signal hooks.
2020-01-10 22:26:18 +11:00
Arkatos1 7b543d2cf9 Valentine status effect fix (#48615)
* Automatic TGUI Rebuild [ci skip]

* Valentine fix

* Revert "Automatic TGUI Rebuild [ci skip]"

This reverts commit 0a92762a259c447b1486cef3a8a6d493dea2039b.

* Review fixes
2020-01-10 22:18:26 +11:00
Dennok a2fc1614a6 You do not lose the storage window on storage pickup. (#48685)
* do not lose the storage window on pickup

do not lose the storage window on pickup

* Keep update_actions()
2020-01-10 21:35:02 +11:00
Jordie f6ae7bfa60 Merge pull request #48686 from Arkatos1/MimingFix
Mime drinks now check if you are true mime before healing
2020-01-10 21:19:47 +11:00
LudwigVonChesterfield 4bc7053b73 A small typo in tactical.dm allowed for a funny. 2020-01-10 00:32:04 +02:00
kevinz000 32be60459f living, not mob (#48655) 2020-01-08 18:16:35 -05:00
Arkatos 4e91dae0d1 Miming check 2020-01-08 21:42:43 +01:00
Qustinnus 8337ccac44 Fixes integrity issues related to datum mats (#48586) 2020-01-07 10:02:18 -05:00
skoglol 135251ece3 Fixes admin disease naming, basic disease trigger (#48628) 2020-01-07 09:54:55 -05:00
MrPerson d5b98c4d8d Unicode support Part 1 (#48304)
* Unicode support Part 1

Makes all calls to ascii2text() and text2ascii() unicode aware as well as all calls in code/__HELPERS/text.dm.

Adds defines for the footext_char() procs to maintain 512 support.

I did some cleanup on the text helpers since a lot of them were really, really bad.

reject_bad_text() and reject_bad_name() have an arg to reject non-ascii chars which defaults to TRUE.

* Give travis a more recent beta

* Ultimate compat
Added the _char procs I was missing
Test the build instead of the version because Lummox is a goddamn moron

* Suggested fixes, removes the last of the dd_ helpers

* Reading the reference is very important!

* Minor code improvements and a comment

* Typo
2020-01-07 09:25:47 +01:00
Ghommie ba9122d606 Fixes traitor codewords highlight and some other hear signal hooks. 2020-01-06 17:06:59 +01:00
Qustinnus 2a1c921acb Refactors skill modifiers to use dictionaries (#48572)
* adds dictionaries woo

* fixes bad code

* duh
2020-01-05 19:46:25 -05:00
skoglol 4499940ee8 Merge pull request #48326 from cacogen/wayfindingpinpointers
Wayfinding pinpointers for Kilo, Donut, Delta, Box and Meta
2020-01-05 15:28:29 +01:00
skoglol 1986466aa7 Fix converting riot shield subtypes to strobe shields (#48541)
Basically this would let you upgrade fake roman bucklers to fully 
fledged riot shields with a flash on them.

Also fixed some inconsistent list indentation.
2020-01-04 22:25:38 -08:00
cacogen 3418be2e16 kriskog changes 2020-01-05 16:43:47 +13:00
cacogen 570ddb50f1 Adds beacons to Meta
- Wayfinding beacons now try to grab their location from any airlock they're under first, then their area, if it hasn't been set on the map
2020-01-05 16:43:47 +13:00
cacogen 29104ccc1e Navigationally Challenged quirk
Spawn with wayfinder. Automatically given to clients less than 7 days old.
2020-01-05 16:43:47 +13:00
skoglol 04880ca76c Merge pull request #48556 from ShizCalev/caltrop-fix
Caltrop / glass / lightbulb crossing fixes
2020-01-04 21:56:26 +01:00
Rob Bailey ba876548f3 Revert "[ready] Smooth-ish move rising: revengeance" (#48156)
Reverts #47817

People are complaining about motion sickness and I don't know what the issue is.
2020-01-04 23:58:31 +13:00
oranges fa41c23539 Merge pull request #48537 from kriskog/waddling
Fixes waddling
2020-01-04 15:34:51 +13:00
ShizCalev ea56f83e58 Caltrop / glass / lightbulb crossing fixes 2020-01-03 04:47:06 -05:00
swindly ee056e6cba fixes check_contents blacklist check (#48520) 2020-01-02 14:53:09 -05:00
skoglol 95b4d04185 Fixes waddling 2020-01-02 14:20:24 +01:00
81Denton 557d5f3266 Merge pull request #48505 from ninjanomnom/waddle-element
Makes waddling an element
2020-01-01 17:19:17 +01:00
Emmett Gaines c6e71c5384 Makes forced_gravity an element 2019-12-31 13:00:47 -05:00
Emmett Gaines 119c4ebca3 Makes waddling an element 2019-12-31 12:55:53 -05:00
ShizCalev 9f532650b3 Pin removal recipe turned into proper tool_act. Has examine message informing you that you can do the thing. Now plays proper tool sounds. (#48461)
* Pin removal recipe turned into proper tool_act. Has examine message informing you that you can do the thing. Now plays proper tool sounds.

* fixed message
2019-12-31 09:18:33 -05:00
Jordan Brown 6d50877333 Fix crafting (#48477)
Initializes the instance type list before attempting to add to it.
2019-12-31 11:53:32 +01:00
Krysonism 5310876edc [READY]Sparklers, Firecrackers and Ian's New year's party. (#48480)
* Base comitt

* Adds Ian's New years helper to all maps

* Fixies + Festive corgi hat for Ian

* newline

* Apply suggestions from code review

Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>

* Implements more suggestions from review

* Fixes grenade spawn chance

* Puts qdel last again.

* Run mapmerger

* Run map merger on last map and makes box contain 20% more memes

* Update code/modules/mapping/mapping_helpers.dm

Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>

* Moves var declarations to the bottom

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
2019-12-30 22:59:14 -05:00
Jordan Brown bed37b7bb2 Fixes Intellitater crafting deleting AIs (#48451)
* Adds safety requirement checking to crafting

/datum/crafting_recipe now has check_requirements() which will be called once item instances that will be used are collected. If this fails, the crafting will be aborted.

* Prevent populated AI cards from use in crafting.

- Overrides check_requirements for the aitater crafting_recipe, failing it if there is an AI present in the candidate card.
2019-12-29 13:20:45 -05:00
cacogen c963b542f0 Kong whiskey and candy corn liquor (#48263) 2019-12-28 15:20:06 +01:00
cacogen e3b8829be3 Luxury shuttle improvements (#48395) 2019-12-28 05:09:30 +01:00
cacogen f66a03c926 PDA cart swapping, eject hotkey and verb; toggle light action button (#48336)
* PDA cart swapping, eject hotkey and verb

* Update PDA.dm and action.dm

- Toggle light action button
- Proper use of mob/user instead of usr when appropriate
- Fixes UI not updating when ejecting or inserting cartridge or ejecting ID
- Makes toggle_light item action work with PDAs
2019-12-27 10:39:51 -05:00
Emmett Gaines 8e775638d4 Fixes orbit component transfer runtime (#48379) 2019-12-27 10:30:28 -05:00
81Denton 3a0c5e75b3 Adds a new job: the Paramedic (#48236)
* Adds a new job: EMT

* adds code

* either adds or removes code, hard to tell at this point

* Never not on it, leanin' so hard you're ashamed
You can't dismiss this sick transmission, huffs your brain
Exhale your will and forget I ever knew you
Fuck do you do?
Fuck a man with hips for hulu
Rack a snitch, chalk and cue you
Corner pocket consume you
Too many hoes in my
Too many hoes in my motherfuckin' meal
Asking if I know how a motherfucker feels
How a motherfucker feels

* 300 hours in MS Paint

* map editing is almost as pleasant as CBT

* remove crepe

* indentation

* map merge

* crew pinpointer, EVA access

* sick sprites by twaticus

* Replaces pen acid bottle with calomel

* Moves crew monitor/pinpointer to premium

* Triple six, five, forked tongue
Subatomic penetration rapid fire through your skull
How I shot it on one taking it back to the days of trying to lose control
Swerving in a blaze of fire, raging through my bones
Oh shit I'm feeling it Takyon
Hell yeah, fuck yeah, I feel like killing it Takyon
Alright that's tight, what its like to experience Takyon
Out of the blue, in through the back
Door coming through like fuck what was that
Man I don't know, but it made me feel so heated
How we creep without showing you jack
Shit from below, give a shit if you know
'cause even if you did, you'd keep coming back
Back for more, need it man you're addicted to the heat
We make beats catch
Beat it til it bleeds to death, each track
Like EPMD snappin' necks as we tap energy
From everything on and off the map
Oh shit I'm feeling it Takyon
Hell yeah, fuck yeah I feel like killing it Takyon
Alright that's tight what its like to experience Takyon
Takyon, shot down your throat like a keg of beer
Choke on the smoke we in and exhale 'til the whole chamber is clear
Haters act so fucking weird
Try to stain this atmosphere
But they can't 'cause its way too sheer
How to make a hater disappear
Take shit where it ain't never been
Fuck what you thought could not comprehend
This shit if I fisted your brain with it
10-9-8-7-triple 6-5-forked tongue
Criminal level crunk lightning storm
Get out the way or get up torn
Ain't a picture big enough to fit
What we dig up from the core
Of all that they forgot ever was
Militant march of this war
Takyon taking them down
All we see is blood
Takyon turning them out
How to trick out and freak that buzz
Oh shit I'm feeling it Takyon
Hell yeah, fuck yeah I feel like killing it Takyon
Alright that's tight what its like to experience Takyon
Lunar eclipse forcing you to trip
Off the moonlit fire we spray
Cryonic haunted bullets hollow tipped with toxic waste
So here's the deal, if you don't feel ill
Don't want it nowhere near my zone
That shit is dead, can't nobody get
With that shit gets dial toned
Takyon bitch slappin pussy clots and clones
Takyon settin' off uni bombs inside your dome
Oh shit I'm feeling it Takyon
Hell yeah, fuck yeah I feel like killing it Takyon
Alright that's tight what its like to experience Takyon

* YUH

* Updates sprites

* changes job order, uncomments plasmeme clothes

* Updates outfits

* last commit I swear

* bottle descriptions

* Renames EMT to paramedic

* Renames existing EMT clothes to paramedic as well

* Add missing job icons for Paramedic (#9)

SecHUD icon
ID card icon

* Improves descriptions

* Reverts vending balance change, replaces random spaces with tabs

* Resolves map conflicts

* Update strings/ion_laws.json

Co-Authored-By: BadSS13Player <58376109+BadSS13Player@users.noreply.github.com>

* Adds missing pda_slot to the paramedic outfit

* roller bed starting equipment

* Fixes map conflict

Co-authored-by: JJRcop <jrubcop@gmail.com>
Co-authored-by: BadSS13Player <58376109+BadSS13Player@users.noreply.github.com>
2019-12-27 10:29:12 -05:00
AnturK f63a53f5f0 Even more runtime fixes. (#48377)
* Fixes cleaving saw runtime.

* Achievement without DB runtime.

* Jelly transformation runtime

* purging nanite runtime.
2019-12-27 04:29:04 +01:00
AnturK 8a64746062 More runtime fixes. (#48376)
* Fixes desynchronizer runtime.

* Fixes adv disease runtime.

* Disallows building with circuitboards without result. (Should this trace maybe)

* Steal objective runtime.

* Fixes scanning mindless dead.

* Fixes linked slime speech runtime.

* Fixes camera deletion runtime.

* Adds some sanity to camera swarmer act.
2019-12-27 04:24:27 +01:00
spookydonut 9ce2bdae8c COMPONENT_DUPE_SELECTIVE (#48021)
* COMPONENT_DUPE_SELECTIVE

* a

* changes per review

* webedit
2019-12-25 22:02:27 -08:00
81Denton 0a42c12368 Add deadmin/readmin keybindings (#48370)
They're unbound by default, so admins will have to assign keys to them.
2019-12-24 11:29:17 -08:00
RaveRadbury db3faf7ff0 Fixes mime pins, clarifies quirk descriptions (#48367) 2019-12-23 23:22:04 -05:00
skoglol 91a94e46af Mindread now reads the correct true name (#48301)
* Mindread now reads the correct true name

* Fixes dna.real_name
2019-12-22 15:29:25 -05:00
thebleh ab16a761dd Don't spawn a pen for uplink unless it's the selected choice (#48332)
* Don't spawn a pen for uplink unless it's needed

* Spawn pen after checking uplink choice for pen

* spawn pen uplink after exhausting other options
2019-12-22 11:12:36 +01:00
moo f92eb16161 Mining Skill is Now Exclusive To Dedicated Mining Tools, Not Weapons That Double As Mining Tools. (#48237)
* gimme ur rune pick

* changes XP scaling

* beep beep

* works on my machine, 150 hours

* fixes borgs bypassing xp restriction when using KA
2019-12-22 08:36:46 +01:00
swindly 0e2b4e1977 Adds logs as parts of bonfires and blacklists steel-caps from them (#48312)
* blacklists steel logs from bonfire

* adds logs as bonfire part
2019-12-21 16:43:36 +01:00