held items actually contains "null" entries by default using just var/I
gets these null items and then tries to wash_obj a null causing a
runtime
Specifying /obj/item will stop the nulls being iterated
* Fixes projectiles not hitting mobs, some refactoring too
* some stuff for projectile can hit target to work with not being ontop of an object
* Yeah let's just refactor bullet_act while we're at it.
* Yeah let's just refactor bullet_act while we're at it.
* Yeah let's just refactor bullet_act while we're at it.
* CanPass returns true to projectiles regardless of hit
* snakecase?
cl coiax
fix: Objects and items can now be inserted into closets, like before.
fix: Fixes a bug which prevented carbons from throwing items.
/cl
Essentially, the original way the insert() proc was structured, I
overlooked an else-if chain that was skipped if something was an item,
because I thought it only existed to type-check the item to access its
flags.
These are the changed lines from the NODROP PR. https://github.com/tgstation/tgstation/pull/42109/files#diff-2b130b854bf2e2a5e76320246520eea4L171closes#42109
cl
del: removed the separated chemicals trait
/cl
I've been meaning to do this for a while. Separated chemicals is mainly used for botany explosives, which are a spammable one hit kill on almost everything. This has been especially bad since I fixed the bug that broke its interaction with squashing.
Botany will still have many tools without these instakills, especially after #42268. This should make botany's weapons both more balanced and more varied.
Smokeplants will still be possible, but will require mutating traits into plants.
In summary, botany needs a nerf in general, and this seems a good place to hit it.
note: EMPs will be lost as well
fixes#42361closes#42363
i changed the moodlet instead of where the wuv proc is, so it should pick the initial name of the dog and say something like "pugs are so adorable! i can't stop petting them!" but for all kinds of dogs
the only thing is that this name doesn't change if you pet a pug and then a corgi because they are classified as the same buff, i could make the name of the buff the same as the mob you are petting so you could stack happiness but that would be a balance change, imagine how happy you could get locked in a room with every kind of dog in the game
I noticed that I had 4 hierophant kills logged on the stats hub, which is off
by about an order of magnitude. What happens is that on death hierophant
releases an expanding square, which you're meant to run from - this puts you
out of range for the medal.
* Refactors NODROP flag into TRAIT_NODROP
🆑 coiax
fix: Anti-drop implants can no longer be used to drop objects that they
were not responsible for sticking to a person's hand.
fix: Backfiring with a Barnyard spellbook will now play a spooky horse sound.
refactor: Refactors the way that "NODROP" items work to a new system,
there should be no change in functionality.
/🆑
Various items in the codebase were doing weird hoop jumps in order to
preserve the nodrop flag's state when it also wanted to change it, so I
moved it to a trait system.
I may have gone overboard with the type of unique trait sources, but
those can be changed later. My long term plan is make a general "CURSED"
nodrop origin, which means you can unlock cursed items by being hit with
a bolt of door opening or something. But that's for another PR, this has
no functionality changes, apart from some slightly modified descriptions
on cursed masks.
- Removed a bunch of redundant voice changing code for all the voice
changing animal masks, used two new clothing flags for this purpose.
- Also refactored a bit the animal masks, making new cursed subtypes that play
the sound when created.
* Drop location
Adds a new drink, made by mimes, for everyone! It was based in a costum drink that had the flavour text of eraser, nothing and future!
Recipe is 1 part Silencer, 1 part Nothing and 1 Part Nuka Cola (it also heals mime like most mime drinks do)
cl BebeYoshi & Hexmaniacosanna
add: A new drink called Blank Paper was added to the bar menu, it was made by a mime and it represents a new start.
/cl
[why]: This was a special costum drink and we thought it deserved its own cocktail, besides, mimes needs more unique things (even if you don't even need a mime to make it).
🆑 coiax
tweak: Observers are able to see family heirloom messages when examining
objects.
/🆑
I mean, it bugged me the once time that I suspected a random object was
an heirloom, but had to use VV to check.
* Moves valentines/candyheart messages to json; adds new text
* commas are my passion i love commas more than anything in the world give my valentine to commas and then FUCKING KILL COMMAS HOLY FUCK GOD
* commas.
* EVEN MORE VALENTINES
* I can't stop
* toolbox pls
* rstar
* Update uplink_items.dm
* contents, force
* i
* toolbox now costs 2 tc
robuster
* "toolbox"
* grammar mistake
* bust < bash
* description is better
A old, blue toolbox, it looks robust.
* changed bash skulls to bust heads
because i just watched the space station 13 video again
* yuh
* asdf
* throw!
* uplink now notes that it increases in damage
* Resisting out of bucklecuffing will now take different amounts of time based on the cuffs used.
* removes stray reference to "one minute"
* makes cobby's change
* WHAT THE FUCK YOU FUCKING MORON
* includes parts of dent
* let's talk about floyd with his dumb ass prs, who the fuck asks for or wanted hygiene except fart fetish lovers, seriously musk/body odor is one of the weirdest and shit fetishes there are why are we enabling floyd's fetishes my god man the maintainers are a disappointment jesus christ.
oranges
Qustinnus
kevinz000
Tad Hardesty
coiax
4dplanner
Jordie
tralezab
Kierany9
Jordan Brown
81Denton
Dax Dupont
Cauã dos Santos Rebelo
granpawalton
Mickyan
bgobandit
Vile Beggar
duckay
PKPenguin321
carshalash
tortellinitony