Commit Graph

26 Commits

Author SHA1 Message Date
phil235 7afbd3345b Replacing some hearers(...) with get_hearers_in_view(...).
Renaming Make Sound to Object Say.
Switching deaf_message in audible_message proc to last argument.
Replacing some "for(mob in hearers)+show_message" with audible_message()
2014-09-25 18:22:27 +02:00
Aranclanos e47095d376 fixes issue #4025
the song datum will now use properly the canUseTopic() proc
2014-07-01 00:00:40 -03:00
Aranclanos 5736eb1f44 Creates canUseTopic(), a mob proc contained for the moment in the machinery.dm
The Topic() proc of machinery will use this.
The first non-machinery item to use this will be the violin and piano.
There are plans to make admin observers use this, to make AIs don't be able to use Topic() when they lose power (doing that currently will break gameplay) and make all items use the canUseTopic() proc if needed.
I just wanted to pull the fix for the piano and violin quick, the rest is a todo.
2014-04-30 05:25:01 -03:00
MrPerson 19d00b96f0 Make violin stop cutting off other sounds 2014-04-02 05:23:00 -07:00
Giacomand 17fd5d6cdc * Fixes certain objects not using 3D sounds.
* Gave the piano a bigger falloff.
 * Capped the sound x/z to 7.
2013-11-21 23:50:53 +00:00
Giacomand c012a7aee3 Changed playsound() to use less code. Playsound now loops through the player list, which means you do not have to check inside closets/objects/other mobs to play sounds.
Made all sounds use 3D sounds! This includes sounds which have less volume the further away you are from it.
The piano now uses 3D sounds.
Changed how the far explosion sound is calculated.
2013-11-18 14:38:49 +00:00
Miauw 5ad9505ef4 [MAP]Fixed space-fastening properly.
Conflicts:
	code/modules/power/singularity/field_generator.dm
	maps/tgstation.2.1.2.dmm
(What is this I don't even)
2013-11-09 14:42:54 +01:00
Miauw 58f021626b Cleaned up bugfixes. Committed musician.dm too, I accidently forgot that. 2013-11-09 14:11:40 +01:00
Giacomand 83b882ed3f * Added the space violin to the service cyborg modules.
* Made the space violin usable by service cyborgs.
* You can now examine Cyborgs to see their active module.
* Made the choose module window look nicer.
2013-10-26 13:49:41 +01:00
Aranclanos 89c3865a16 Fixes a runtime when a song tries to keep playing when the instrument was deleted 2013-10-22 03:47:49 -03:00
Giacomand ce30071077 Runtime fixes.
runtime error: Cannot execute null.on reagent change().
proc name: del reagent (/datum/reagents/proc/del_reagent)
  source file: Chemistry-Holder.dm,308
  usr: null
  src: /datum/reagents (/datum/reagents)
  call stack:
/datum/reagents (/datum/reagents): del reagent("pacid")
/datum/reagents (/datum/reagents): clear reagents()
Chemsmoke (/datum/chemical_reaction/chemsmoke): on reaction(/datum/reagents (/datum/reagents), null)

runtime error: Division by zero
proc name: Topic (/datum/song/Topic)
  source file: musician.dm,193
  usr: Tico-Tico Tambien (/mob/living/carbon/human)
  src: Untitled (/datum/song)
  call stack:
Untitled (/datum/song): Topic("src=\[0x210054cd];import=1", /list (/list))
2013-08-02 00:28:08 +01:00
sararar ffa7b2f2e7 Issue #704. added a fix so that g# will now work on the space piano. tested and works.
Signed-off-by: sararar <sarajfarr@gmail.com>
2013-06-20 13:13:50 -04:00
Cheridan 725718dd5b -Replaces the holodeck boxing ring that no longer works with a dodgeball arena. Adds dodgeball sprites and defines.
-Fixes the crew monitoring console disappearing when damaged (meant to do this before but the change didn't go through somehow)
-Readds the space piano, removes the useless /device subtype from its path.

-Makes tables use a less hardcoded method to determine iconstate.
2013-05-02 11:52:55 -05:00
Tastyfish e4b2968e4f Cleaned up redundant piano/violin sound files and made playnote() code not be a giant unmanageable switch 2013-04-04 06:55:38 -04:00
Tastyfish 806d784b16 Moved backend and UI functionality into the datum/song class and made in generalizable for special-case functionalities for player checks, etc 2013-03-20 04:52:17 -04:00
johnsonmt88@gmail.com 154a7c0f76 The code compiles again but I make no promises about whether or not the piano works.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@5425 316c924e-a436-60f5-8080-3fe189b3f50e
2012-12-30 17:51:49 +00:00
daniel.cf.hultgren@gmail.com 49d87eed07 Reverted to oldpiano until me or somebody else decides to fix baysongs and whatever bugs there are.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@5422 316c924e-a436-60f5-8080-3fe189b3f50e
2012-12-30 10:03:38 +00:00
elly1989@rocketmail.com 4d9876fd65 Fixes issues with pen bbcode. Replacetext did not work correctly after I changed text2list - (It was missing 'needles' at the beginning of 'haystacks').
>dd_replacetext and dd_replacetext_case are now replacetext and replacetextEx respectively.
>replacetext and replacetextEx works using strings only; it doesn't convert it into a list and then back into a string.

Fixes some dumb-dumbs in textlist and text2listEx
> "<" where there should be a "<="
> no else case for when the separator is longer than the text (causing empty lists to be returned)

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4971 316c924e-a436-60f5-8080-3fe189b3f50e
2012-10-27 21:21:17 +00:00
giacomand@gmail.com 6a2d78bc94 -Killed the updateDialog lag. I added a check to see if there were any mobs to update, if not it will stop checking until a user uses the machine again. I had to replace all the machine = src and machine = null with procs to help make it manageable. I believe this is one of the culprits causing the server to lag as the round goes on, as more players will interact with machines.
-Atmos delay is now based on active players, to help fight lag for massive player rounds.

-Changed some for(blah in world) loops to use the correct lists.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4958 316c924e-a436-60f5-8080-3fe189b3f50e
2012-10-25 19:15:51 +00:00
elly1989@rocketmail.com 7b720a20b6 >Moved most of the helper procs into code/__HELPERS. If you see ANYTHING generic enough to be a helper proc just throw it in there and help purge the copypasta 5ever
>Replaced dd_text2list, dd_text2listcase, tg_text2listcase and tg_text2list with text2list and text2listEx. text2list will return a list of each and every character in the string if you set separator=""
>added return_file_text(filepath) which returns text from a file after doing some checks: does the file exist? is the file empty? It prints helpful error messages to the world.log if it runs into problems
>Replaced dd_file2list(filepath, seperator) with file2list(filepath, seperator). It just calls text2list(return_file_text(filepath), seperator). rather than copypasta
>Replaced time_stamp() so it's not as retarded
>Lots of the world setup stuff uses file2list now, rather than file2text -> sanity -> text2list
>Added error() warning() testing() procs. These print messages to world.log with a prefix. e.g. ## ERROR: msg.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4948 316c924e-a436-60f5-8080-3fe189b3f50e
2012-10-24 14:39:36 +00:00
daniel.cf.hultgren@gmail.com 58dfdf5026 uruereruguu
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4776 316c924e-a436-60f5-8080-3fe189b3f50e
2012-09-29 23:14:57 +00:00
daniel.cf.hultgren@gmail.com 20edf15eab * You can now properly import baystation and oldpiano to the new piano
* Fixed the BPM +/- signs
* Fixed the violin


git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4775 316c924e-a436-60f5-8080-3fe189b3f50e
2012-09-29 23:11:19 +00:00
daniel.cf.hultgren@gmail.com fc4a98ba39 *Reworked Piano, now optimized and whatnot, new interface
*Updated changelog

Please notify me of any bug so it can get fixed.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4757 316c924e-a436-60f5-8080-3fe189b3f50e
2012-09-25 18:35:16 +00:00
elly1989@rocketmail.com bbd020b436 Runtime fixes for:
runtime error: bad icon operation
proc name: New (/icon/New)
  usr: Charles Mycroft (/mob/living/carbon/human)
  src: /icon (/icon)
  call stack:
/icon (/icon): New("plating", "metal1", null, null, null)
the wall (185,137,1) (/turf/simulated/wall): clean blood()
Space cleaner (/datum/reagent/space_cleaner): reaction turf(the wall (185,137,1) (/turf/simulated/wall), 11.6)
/datum/reagents (/datum/reagents): reaction(the wall (185,137,1) (/turf/simulated/wall), 1, 10)

runtime error: list index out of bounds
proc name: Topic (/obj/structure/device/piano/Topic)
  source file: musician.dm,525
  usr: Toto (/mob/living/carbon/human)
  src: the space minimoog (/obj/structure/device/piano)
  call stack:
the space minimoog (/obj/structure/device/piano): Topic("src=\[0x200723e];modifyline=1", /list (/list))
Octisetti (/client): Topic("src=\[0x200723e];modifyline=1", /list (/list), the space minimoog (/obj/structure/device/piano))

Added sanitization to user inputs in piano/Topic()

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4605 316c924e-a436-60f5-8080-3fe189b3f50e
2012-09-02 22:32:24 +00:00
johnsonmt88@gmail.com ecd5a2283d Standardized musician.dm
Also the piano now has a 50/50 chance to spawn as the minimoog or space piano

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4577 316c924e-a436-60f5-8080-3fe189b3f50e
2012-08-28 16:21:34 +00:00
johnsonmt88@gmail.com 19135de9eb Changes to the file structure!
There are many files, folders and chunks of code in areas that make absolutely no sense and thanks to the defines being located mostly in a completely separate file, it can be damn-near impossible to find something. Before moving defines to where the rest of their code is located; I'm going to move some code around into places that actually make sense to begin with. I'll mainly be focusing on the code/game/objects folder.

This commit mainly lays the groundwork for the work I'll be doing by adding in the effects, structures, decals and turfs folders. I'll slowly be moving appropriate files and code into these folders. I may end up moving machinery into 'objects' and mech stuff into its own module folder but I'll ask for some opinions on coderbus before doing that.

I've also gotten rid of the /magic/ folder. I've moved the library stuff into its own folder in modules/library, the cult stuff is now in gamemode/cult with the rest of it and musician.dm is now in objects/structures since the piano is a structure apparently.


I think I've got the hang of how DM and SVN handles folders and files but it's quite possible that something will break simply by svn committing it oddly. Please let me know if that's the case!

Remember to clean compile.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4513 316c924e-a436-60f5-8080-3fe189b3f50e
2012-08-22 15:50:09 +00:00