Defined all the existing light_color values.
Moved their definitions to colors.dm
Made white the default color. It was so already, but that was very obscured.
Moved the atom light-related variables to the atom definition.
Wrapped changes to variables such as light_color into procs that report the event through signals.
Moved the light_on variable to the atom level, also adding a signal for its changing, to represent toggling lights.
Cleaned up a little bit of code in where new variables were defined before redefinitions.
This is all atomization to reduce changes in #52413
None of this affect gameplay at all, it's all code cleaning and refactoring.
There's more colors to standardize, a search for color = will find lots of targets, and I see little need to have both the LIGHT_COLOR and COLOR patterns, but I don't want to make this PR bigger than it already is.
Exactly the same functionality for a cheaper cost, no typecache lists being built.
One could argue that this diminishes expansibility. I'd argue back that this is a rather lazy hack and shouldn't be expanded on.
If you want to add more complex smoothing functionality then don't make it area-based.
* Makes pad fireproof and makes machines spam less
* Update code/game/machinery/civilian_bountys.dm
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
* Adds a coder override emote to skip dumb shit with me
* I know this sucks, I can't comprehend how to do this cleanly without a full rewrite
* cleaner now
* Adds an atmos debugging tool and excited group visualizer
* rebuild moment
* yarn install -> yarn run build
* Sigh
* Fixed UI, did not test, needs a rebuild.
* Proper flexing
* Adds varied colors, improved ui courtusy of stylemistake:
* Fixes a runtime, updates tgui
* added superconductors, cleaned up some shitcode, removed a clashing color
* Woop
* Speed
* rebuild
* Adds a tick count
* begone auto-update
* color defines
* rebuild moment
* color improvements, fixes updating
* adds another preprocesser define to handle showing max shares in the ui
* test of application system?
* patches up some display issues, allows for smooth flowing from one group to another
* overlay-ified
* client testing
* dmi moment
* plane master
* it fucking works
* size change
* passthrough
* rebuild moment
* adresses review concerns, toggles active turf vis on when testing
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
* Plant Reagent Genes can upgrade themselves via crossbreed, var added to keep cabbage from creating an organ farm
* This will do.
* Nah, NOW it's fine.
* tiny documentation tweak.
* like every var in hydroponics is ONE LETTER ROH
* When did this change
* is this the power of bitflags
* Apply suggestions from code review
Co-authored-by: Rohesie <rohesie@gmail.com>
* Apply suggestions from code review
Co-authored-by: Rohesie <rohesie@gmail.com>
* Alright, working as intended.
* Flips to positive defines because I'm a negative lad
* resolves conflict
Co-authored-by: Rohesie <rohesie@gmail.com>
* Fixes#52538
* Allow those with insulated gloves to mess with airlocks still
* Fix not being able to interact with insulos
* Fix style qualms
* Add shock immune to should_electrocute
* tk and the defib
* fixed range check
* extra check that is not needed
* only show ear damage on threshold pass
* wrong branch am bad
* is living check
* Adds useless skillchip adaptor
* Redo code so that skill_station code doesn't need to be modifed
* Remove helper and return directly instead of setting return code
* Update code/modules/library/skill_learning/skillchip.dm
Co-authored-by: Rohesie <rohesie@gmail.com>
* Change to bitflag system
Co-authored-by: Rohesie <rohesie@gmail.com>
* Try to replace light overlay to vis_contents
* move glowybit creation in Initialize
* ups
* change mutable_appearance to SSvis_overlays
* set right settings
* temp
* cleanup
* more
* Revert "more"
This reverts commit 8707bfe75d.
* less is better
* some documentation
* almost there
* we did it
* words
* better words
* Update code/controllers/subsystem/timer.dm
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
* Update code/controllers/subsystem/timer.dm
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
* whitespace
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
* no brainer!
* hilarious indentation error
* thank you!!
Co-authored-by: trollbreeder <trollbreeder@users.noreply.github.com>
* fixes
* armhulen07/23/2020 someone mute me from this channel i'm going to give all of my organs to Bulgaria if i keep finding these dark truths
Co-authored-by: trollbreeder <trollbreeder@users.noreply.github.com>
Rohesie
girl
Krysonism
Jordan Brown
ShizCalev
ArcaneMusic
LemonInTheDark
Theos
Arkatos1
tralezab
Ryll Ryll
Timberpoes
Time-Green
NightRed
KathyRyals
Fikou
nemvar
Tlaltecuhtli
Jared-Fogle
zxaber
EdgeLordExe
Gamer025
Wayland-Smithy
Dennok
AnturK