Commit Graph

58 Commits

Author SHA1 Message Date
MrPerson 9038fb15af Code cleanup
Removed a bunch of unused or hardly used vars on /mob and /atom/movable.
Added defines for mob/living/var/mob_size so it's not using magic numbers.
2015-03-13 10:41:00 -07:00
Remie Richards 5fc7af7fbf attackby() now has an argument containing the parameters of the click that called it. Items placed on tables now center their icon where the user clicked. this is NOT true for racks, since racks look organised in their sprite.
Items reset their pixel_x and pixel_y values on pickup.
2015-02-19 13:02:43 +00:00
Iamgoofball fbfe5e5840 Fixes Chameleon letting you attack and stay invisible. 2015-01-11 09:24:22 -08:00
Razharas 418e3a0613 General cleanup
Fixed the magic text failing in monkey injectors
Removed lots of comments
Didnt fix mysterious list bounds runtime in tourettes
2014-12-29 11:36:01 +03:00
Razharas 8d110ee496 Tiny clean up, still lots of work to do
Only compiletested, these changes were never tested in the game yet
2014-12-12 23:57:11 +03:00
Razharas c2046105af Ok reverting this shit
Disregard this you know what i do
2014-12-01 00:12:58 +03:00
Razharas 4998b19ddf Merge pull request #5679 from Aranclanos/projectilesBump
Projectiles bump fix, spawn() removal
2014-11-27 03:38:05 +03:00
Razharas ebfb3b012d Fixes runtimes of the mechs
Fix #5777
2014-11-22 18:34:41 +03:00
phil235 4bdafd02b6 Moving carbon/middleclickon() form carbon.dm to click.dm and centralising it (there was two carbon/middleclickon() proc.
Moving carbon/altclickon() to click.dm as well.
2014-11-07 19:23:30 +01:00
Aranclanos 364f4e1f24 Changes the call from process() to fire() in all places where a projectile is created. 2014-11-04 16:38:58 -03:00
Francis adf252df9b Keep the define around as that is a good idea 2014-10-20 22:49:06 +13:00
Francis 6eb4793801 Revert "Adds click cooldown to clicking on mobs Fixes #4812"
This reverts commit 7116584db1.
2014-10-20 22:23:19 +13:00
Francis 5f8380304a Revert "Make handcuff click cooldown a define"
This reverts commit 7da7fdbaab.
2014-10-20 22:23:07 +13:00
Francis 25d587a483 Revert "Cleaning up unecessary cooldown changes"
This reverts commit 970c61844f.
2014-10-20 22:22:51 +13:00
Francis Devine 970c61844f Cleaning up unecessary cooldown changes 2014-10-09 14:49:28 +13:00
Francis Devine 7da7fdbaab Make handcuff click cooldown a define 2014-10-09 14:49:28 +13:00
Francis Devine 7116584db1 Adds click cooldown to clicking on mobs Fixes #4812 2014-10-09 14:49:27 +13:00
MrPerson a23dbe2357 Merge branch 'master' of https://github.com/tgstation/-tg-station into examinate_the_doctor
Conflicts:
	code/game/objects/items/devices/radio/radio.dm
	code/game/objects/items/toys.dm
	code/game/objects/items/weapons/tanks/tank_types.dm
	code/game/objects/items/weapons/tanks/tanks.dm
	code/modules/events/ninja.dm
	code/modules/power/cell.dm
	code/modules/power/port_gen.dm
	code/modules/reagents/reagent_dispenser.dm
2014-08-29 04:21:15 -07:00
Firecage 6c7af5eb32 SPANCLASSES!!!!! 2014-08-26 09:52:13 +02:00
MrPerson d0c97aae72 Merge branch 'master' of https://github.com/tgstation/-tg-station into examinate_the_doctor
Conflicts:
	code/ATMOSPHERICS/components/unary/vent_pump.dm
	code/game/gamemodes/cult/ritual.dm
	code/game/gamemodes/nuclear/pinpointer.dm
	code/game/machinery/spaceheater.dm
	code/game/machinery/status_display.dm
	code/game/objects/effects/decals/crayon.dm
	code/game/objects/items/stacks/stack.dm
	code/game/objects/items/weapons/airlock_painter.dm
	code/game/objects/items/weapons/cigs_lighters.dm
	code/game/objects/items/weapons/storage/secure.dm
	code/game/objects/items/weapons/tanks/tank_types.dm
	code/modules/assembly/assembly.dm
	code/modules/assembly/holder.dm
	code/modules/assembly/mousetrap.dm
	code/modules/mob/living/carbon/alien/special/facehugger.dm
	code/modules/mob/living/carbon/slime/examine.dm
	code/modules/power/cable.dm
	code/modules/reagents/grenade_launcher.dm
	code/modules/reagents/reagent_containers/food/drinks.dm
	code/modules/reagents/reagent_containers/food/snacks.dm
	code/modules/reagents/reagent_containers/glass.dm
	code/modules/recycling/sortingmachinery.dm

Thanks Firecage, this is all your fault
2014-08-20 05:54:20 -07:00
Aranclanos ccae5781c5 added two defines CLICK_CD_RANGE and CLICK_CD_MELEE (4 and 8), replaced all changeNext_move() procs to use these two defines.
Added melee click cooldown for paper spam on cameras.
2014-08-03 22:14:56 -03:00
MrPerson 645ca7f8a1 Merge branch 'master' of https://github.com/tgstation/-tg-station into examinate_the_doctor
Conflicts:
	code/_onclick/click.dm
	code/game/atoms.dm
	code/game/objects/items/toys.dm
	code/modules/paperwork/folders.dm
	code/modules/power/cable.dm
2014-06-09 01:50:44 -07:00
ikarrus d50eaaa624 You now face what you are examining when using the verb 2014-05-31 14:11:42 -06:00
MrPerson 9d9a657acf Change examine() from an atom verb to a mob verb
Just in time for the feature freeze, a big change that will introduce bugs! Yay!
Mob verb is called verb/examinate(target), which just calls target.examine(user) and face_atom(target)
For explanation why, see http://www.byond.com/forum/?post=1326139&page=2#comment8198716
Long story short, mob verbs are much faster than object verbs. The goal is to make right-click menus populate faster.

Also changes a bunch of examine() procs to always, ALWAYS call the parent. Except mobs, but you have 1 guess why I'm not touching them. Mostly this affects obj/item/examine().
And also remove a whole shitload of pointless set src in view(2) kind of crap. Also span classes.
2014-05-01 09:56:39 -07:00
Aranclanos 129401c403 evidence bags will now use attackby() to add items to themselves
removed the preattack() proc
2014-04-29 08:38:51 -03:00
Aranclanos a86071c3ac Reverts my aphril's fool click delay on mobs stuff 2014-04-02 01:40:02 -03:00
Cheridan 302f2ea122 Merge pull request #3215 from MrStonedOne/silicon-macros-and-hotkeys
Gives cyborgs ai click shortcuts, adds some click shortcuts, and gives borgs more meaningful hotkeys
2014-04-01 01:27:39 -05:00
Aranclanos 953acabcda right so more stuff I forgot 2014-04-01 01:56:16 -03:00
Aranclanos 594443cf5e For the start of the month, I'll make combat more robust because I think everyone is pretty unrobust.
This won't be reverted.
Happy clicks.
2014-03-30 22:12:24 -03:00
Aranclanos 7bcb69ad88 Removes the click cooldown from almost everything, now it should be always be 0.1 seconds.
Ranged weapons and laser eyes have a cooldown of 0.4.
Grilles, windows, windoors, walls and blobs have a cooldown of 0.8.
Hitting mobs will also have a cooldown of 0.8.
Removes the unused USEDELAY flag.
2014-03-28 06:32:47 -03:00
MrStonedOne 636d4d34ae Add access override hotkey control+shift to ai
Also adds framework for control+shift click capturing to _onclick, can be used by most atoms
2014-03-27 21:12:44 -07:00
Mloc-Hibernia 8af8a43d6f Initial pass to convert LF to CRLF
Signed-off-by: Mloc-Hibernia <colmohici@gmail.com>
2014-03-24 08:53:40 +00:00
Razharas aa71a5f2ca Monkey trouble fix
It wasnt even checking is monkey had a disease. it was monkifying humans
straight, assuming all cuffed monkeys should be jungle fevered
2014-02-10 10:42:54 +04:00
adrix89 5bfe0cbd61 Merge branch 'master' of https://github.com/tgstation/-tg-station into attack_override
Conflicts:
	code/_onclick/item_attack.dm
2014-02-03 18:07:45 +02:00
MrPerson 4ffd2cf5a4 Allow anyone whose living to turn on examine. 2014-02-02 15:07:09 -08:00
adrix89 869f4efa0a I finally realize what was causing the click issues,so now it works with proximity flag. 2014-02-02 15:31:56 +02:00
MrPerson 294b87b20f Dead people no longer turn to face things when they examine. Nor does anyone else who can't move for that matter. 2014-01-30 15:28:52 -08:00
adrix89 8658feae33 Remove adjenct check from click,and move it after attack self
Fixed https://github.com/tgstation/-tg-station/issues/761
2014-01-20 10:21:51 +02:00
adrix89 f280a46847 Implement an preattack override for your self contained snowflake needs 2014-01-19 17:27:13 +02:00
Aranclanos f6f9f0f050 Removed a leftlover in click code and fixed changeling stings because they weren't working why aren't they working why don't they work, I keep asking that, it's a PR about changelings stings, but they don't work, why they don't work little black ball of destiny, I just want to know why they don't work on the PR that says that they will work, why why why 2013-12-05 07:35:29 -03:00
Razharas b7b45881b2 Made abstract a flag and other stuff
Everything that had abstract var now has ABSTRACT flag
Everything that checked abstract var now checks ABSTRACT flag
Fixed some runtimes
Fixed click code and face direction changing while cuffed
Added del to all attack_* of the proboscis in case shit goes real
AStar is still weird so added  a simple sanity check
2013-11-18 03:53:50 +04:00
Razharas 6d0bbc8b24 Further improvement of ling code
Yadda yadda
2013-11-17 02:09:43 +04:00
Razharas 453da53560 Ling changes and some click additiong to items 2013-11-16 23:10:55 +04:00
Aranclanos a2981e5f9c Merge pull request #1589 from SuperSayu/clickstuff3
Mecha, hud, and click fixes
2013-10-25 09:16:54 -07:00
supersayu fff7c61d10 More correct fix for #1164 that does not introduce new bugs (oops)
Re-adds the ability for mobs to turn when clicking on a wall object in their square (APC, etc)
Re-adds ghost shift- and alt-clicking, sorry about that.
2013-10-16 01:36:43 -04:00
supersayu a7398c2205 Mecha fixes
Prevents mech actions from acting on the user's inventory.  Fixes #1487.
(Almost) fully prevents inventory use from within a mech, to be more consistent.  The internals GUI button still works on the theory that it's emergency equipment.
2013-10-16 01:30:00 -04:00
Giacomand 1bf07a3065 * The AI can now use alt click to get a list of objects and the turf for easy access.
* The AI can interact with all the items in the list.
* The AI can use this for several things:
 * Since the list will not dissappear for the AI, until there's no camera coverage, they can use it to bookmark a single tile to interact while not having to look at it.
 * They can also use this to quickly jump to the listed turf.
 * They can interact with objects under other objects.
* Made the CTRL Click on the APC directly use the toggle_breaker() proc.
2013-10-14 17:23:53 +01:00
Mloc-Argent db0a908038 Make energy weapons not get a bloody overlay and fixed alt-gr not calling AltClick()
Signed-off-by: Mloc-Argent <colmohici@gmail.com>
2013-10-08 20:15:56 +01:00
MrPerson 5347cac68a Merge pull request #1494 from Giacomand/clickmobopt
Hostile Mobs Attacking Through Window Fix
2013-10-07 12:55:04 -07:00
Giacomand 0bb72fcb66 * Fixed hostile mobs being able to attach through windows (thanks to the new click code's Adjacent proc)
* Made the shift examine turn your mob again.
 * Slightly optimized getting the modifier params, in the click code.
2013-10-04 14:44:53 +01:00