Commit Graph

1651 Commits

Author SHA1 Message Date
oranges 64460ae3ca Merge pull request #44825 from AutomaticFrenzy/patch/lints
In advance of eventually adding SpacemanDMM's linter to Travis, fix everything it can currently detect.

Some lists, including global lists, are given types so that L[i].foo expressions can be checked.

Some procs are given a new form of return type annotation so that DuplicateObject(O).forceMove()-type invocations can be checked.

Open to syntax suggestions on the return type annotations, and on whether the preprocessor strategy makes sense.

Return type syntax is currently roughly:

    <typepath> | <paramname>([_])*(.type)?
2019-07-03 19:31:11 +12:00
ShizCalev 6e44bd3a93 Merge pull request #44796 from kingofkosmos/addswarningspans
Adds warning-spans
2019-07-02 00:47:43 -04:00
kingofkosmos ad64678c48 Merge branch 'addswarningspans' of https://github.com/kingofkosmos/-tg-station into addswarningspans 2019-07-01 13:32:24 +03:00
kingofkosmos 51f77267f4 * revert error spans 2019-07-01 13:28:15 +03:00
AnturK d8b023774e Quirk preferences fixes (#44823)
Removes the useless split by value lists. Updates savefile after
removing invalid quirks. I'd prefer usual savefile validation but quirk
lists are built pretty late. Other solution would be hooking all prefs
to after quirk SS initializes, this seems less intrusive if ugly but
I'm open to alternative suggestions.
2019-06-29 20:07:21 -07:00
AffectedArc07 c4e75bc40b [READY] SSdiscord and Round Notifications (#44231)
* Notify System

* V2

* Adds a hint

* Stoned fixes round 1

* Use grammar wells I can

* This didnt work

* I wish you could test on TGS without committing

* Jordie fixes round 1

* oops

* This took way longer than it should have taken

* Adds in endnotify for serverops

* Spacing
2019-06-30 00:43:25 +10:00
Emmett Gaines 48f19baba1 Randomizes lavaland atmos (#44427)
This makes lavaland atmos random per round. You won't get eternally burning hell worlds or vacuums but it's nice for a bit of variety.

Admins can edit the gas mixture for all of lavaland at once if they want to ruin some miners' day.

image

cl
add: Lavaland atmos is no longer a preset gas mixture and varies per round
tweak: Bonfire minimum oxygen content has been reduced
/cl
2019-06-29 21:07:26 +12:00
AnturK 340106b7bc Skip quirk assignment for characters without station role (#44781)
I'm getting tired of fixing wrong assumptions about what equipment is
available or when quirk assignment happens.
2019-06-28 16:03:59 -07:00
kingofkosmos c969f6d3eb Merge branch 'master' into addswarningspans 2019-06-27 15:12:54 +03:00
kingofkosmos ec5c82029a * "Is already...", "Can not...", "Not when..." etc. 2019-06-27 06:15:43 +03:00
Tad Hardesty b07065a477 Add additional type annotations to lists 2019-06-25 22:48:10 -07:00
spookydonut 18e92e152b Makes shuttle load in transit level [TESTED] (#44676)
* Removes shuttle manipulator

* oops

* fuck it lets just remove it.

* Revert "fuck it lets just remove it."

This reverts commit 8a95879f21d3f4aad3d56e33fa90ebc1940c1e27.

* re-remove the old admin proc

* Make shuttles load in transit level

* Add check

* oops

* i need coffee
2019-06-24 09:50:47 -04:00
spookydonut c5f7f5b063 Removes shuttle manipulator (#44655)
* Removes shuttle manipulator

* oops

* moves ui to ssshuttle

* fuck it lets just remove it.

* ooops

* Revert "fuck it lets just remove it."

This reverts commit 8a95879f21d3f4aad3d56e33fa90ebc1940c1e27.

* re-remove the old admin proc
2019-06-23 21:24:10 +02:00
Emmett Gaines d615abf23c Replaces callbacks in signals with simple proc paths (#44579) 2019-06-22 18:21:57 +02:00
oranges d3f5e23b02 Merge pull request #44593 from XDTM/SpamsOver
Makes lowmemorymode spawn the transit z level, fixing the shuttle error spam
2019-06-19 10:00:49 +12:00
oranges 99044ecabe Fixes the AI job assignment (#44628) 2019-06-18 23:18:04 +02:00
FrankFo 645156ff60 De-linkifies names in deadchat_broadcast(), makes deadsay css class default (#44600)
* De-linkifies names in deadchat_broadcast(), makes deadsay css class default too

* Makes the source argument come after message, since it is optional

* Removes excess </span>
2019-06-18 22:49:02 +02:00
AnturK 4bc7b04386 Fixes head job assignment order (#44587)
* Fixes head job assignment order

* Makes this shared list

* Hmm yes
2019-06-17 16:51:41 -04:00
XDTM afcbb30024 Makes lowmemorymode spawn the transit z level 2019-06-17 17:31:49 +02:00
oranges b734e62ecf Merge pull request #44513 from AnturK/policything
Displays job policy when joining
2019-06-17 14:00:13 +12:00
AnturK e4ad4661b8 Fixes secret sauce reagent choosing (#44521)
I had these on previous fix branch but seems i forgot to push whoops.
Fixes #44520

cl
add: Recipe for fabled secret sauce can now be found in the deepest reaches of space.
/cl

Changelog because i forgot one when i actually added the feature.
2019-06-17 13:57:15 +12:00
oranges 07abe542a8 Merge pull request #44548 from vuonojenmustaturska/sanity
Add periodic cleaning of several player-containing lists to server tasks
2019-06-17 13:56:41 +12:00
vuonojenmustaturska 375eb4b5ba Update server_maint.dm 2019-06-15 20:31:42 +03:00
vuonojenmustaturska e57ab0a85b Add periodic cleaning of several player-containing lists to server tasks 2019-06-15 20:20:43 +03:00
AnturK 7c33571386 Displays job policy when joining 2019-06-14 08:25:47 +02:00
ninjanomnom 56196df9c6 Reverts datum outputs
reverts #43038
reverts #41535
2019-06-13 20:09:10 -04:00
Mickyan 1ab6b264d8 I need my payday, too (#44353) 2019-06-11 11:06:52 -04:00
81Denton b8f4737b22 Adds cheesie honkers to Clown phobia (#44385) 2019-06-08 20:20:25 -04:00
TheChosenEvilOne d1039623dd Fixed multiple map voting issues (#44378) 2019-06-08 13:14:40 +02:00
oranges a9476642cf Techweb clash warning now shows path clashing (#44321) 2019-06-05 20:52:17 -07:00
oranges 2e5a3c2226 Merge pull request #44319 from actioninja/gaybabyjail
Fixes an issue with the anti-antag rolling system where players were getting banished to nullspace
2019-06-05 18:45:22 +12:00
actioninja c6193255f7 renames the func to make it clearer it has extra logic in it 2019-06-04 19:41:41 -07:00
TheChosenEvilOne a66126d7e3 Add map voting (#44244)
- Add map voting
- Rename config option for preferred map weighted map selection
2019-06-04 23:55:14 +02:00
Emmett Gaines c3f95024b2 Gets rid of the GetComponent macros (#44220)
* Removes the GetComponent macros

* Regex replacement for GET_COMPONENT

Search: `GET_COMPONENT\( *(.+?) *, *(.+?) *\)`
Replace: `var$2/$1 = GetComponent($2)`

* Regex replacement for GET_COMPONENT_FROM

Search: `GET_COMPONENT_FROM\( *(.+?) *, *(.+?) *, *(.+?) *\)`
Replace: `var$2/$1 = $3.GetComponent($2)`
2019-06-04 17:39:58 +02:00
oranges 7811f1ff7f Merge pull request #44208 from 4dplanner/throw
Thrown objects phase through thrower
2019-06-03 11:05:46 +12:00
YakumoChen 8927239681 AFK Timeout text fix (#44245)
Fixes a button in the afk timeout prompt.
2019-06-01 15:10:34 -07:00
oranges 5be02315ea Merge pull request #44191 from AffectedArc07/removes-ss-religion
Removes SSreligion
2019-06-02 09:40:45 +12:00
AnturK d8078e1452 Adds system for randomized semi-persistent chem reactions. (#44094)
Generates parametrized randomized recipe and resets them every x days.
One example reaction added, with recipe available in space ruin (or through experimentation of course).
There's a few obvious improvements to the randomization system but i feel this is good enough to start some discussion. Still need to decide how far should conflict resolution go.
2019-06-01 09:31:05 +12:00
Jordie 902ca44026 Queries attempt reconnection on mysql 2006 error (#44144)
* queries attempt reconnection on mysql 2006 error

* change failed connection cutoff to use timer
2019-05-31 19:11:16 +02:00
vuonojenmustaturska 6a106bc877 Remove reagent ids and use typepaths where applicable (#44166)
cl Naksu
code: reagent IDs have been removed in favor using reagent typepaths where applicable
fix: mechas, borg hyposprays etc no longer display internal reagent ids to the player
/cl
2019-05-31 21:57:26 +12:00
4dplanner 44cd465de1 Mobs don't pass through thrower 2019-05-30 16:07:58 +01:00
4dplanner 55a1621432 Thrown objects phase through thrower 2019-05-30 15:20:09 +01:00
Akrilla f66769a113 Show codewords on round end screen (#44168)
* Show codewords on round end screen

* More efficient searching of codewords in text

* Typed globals
2019-05-30 11:57:19 +02:00
AffectedArc07 e856ca9de2 Merge 2019-05-29 14:03:03 +01:00
AffectedArc07 9955d0efbc Gives SSreligion the boot 2019-05-29 13:33:04 +01:00
AnturK 966be0a58c Fixes overflow role. 2019-05-28 22:48:49 +02:00
Akrilla 1262f1d4fc Traitor greet text changes
New line, mentioning recognizing words. Phrases are now generated in a list, rather than just a joined string.
2019-05-24 22:34:09 +01:00
Rob Bailey 8958287246 [s] Prevents a certain kind of antag-rolling abuse. (#44056)
About The Pull Request

Currently there's a very easy way of making it so that if you don't roll antag, you aren't playing the game and can just go observe and hope for ghostroles.
Have every job set to never, have return back to lobby if preference unavailable set, and antags enabled.
if you roll antag, you get a job or the antag, if you don't, back to lobby.
If you think this is a good idea and go do this, know it's against the rules and if you get caught you'll be banned.

What this PR does is validate that you have at least one job enabled before ever even adding you to the pool of potential players, if you have "return to lobby" set. If this happens, you'll get a notification and an admin will be notified if you also had antags on.
Either of the other "my pref was unavailable options" you can have all jobs set to never just like before and you'll get your random role.
Why It's Good For The Game

Prevents some abuse that can easily be closed on the game code end.
2019-05-24 13:57:37 +12:00
AnturK 26009e179c Adds required jobs support to gamemodes (#44026)
* Adds required_jobs support to gamemodes

* alos needs to be checked with no players present

* early return
2019-05-22 09:56:42 -04:00
vuonojenmustaturska e2104ed3c8 Blob refactor (#43872)
* blob refactor

* blobtype -> blobstrain

* fixes, chemical -> strain

* only /mob/living experience Life, blobs and other cameras can process if they need to

also other fixes

* call_life goes out

* ispath thing
2019-05-12 23:59:36 +02:00