Commit Graph

46305 Commits

Author SHA1 Message Date
MrDoomBringer 999169442a Makes pulling money out of IDs more consistent, adds actually useful feedback to pulling money out of cards (#42905)
* zug zug

* makes feedback more useless

* more stuff

* improves breast visibility

* make it talk
2019-03-07 10:55:17 +01:00
Tlaltecuhtli f5d5d2a3b1 fixes some edge cases in rcd building (#42960)
New RCD interactions
2019-03-07 10:49:43 +01:00
ShizCalev 55761bf88f Merge pull request #43026 from tralezab/patch-43
Trees now have the plants faction
2019-03-06 18:21:27 -05:00
py01 05333ea4d7 nerfs scattershot (#43014) 2019-03-06 16:07:20 -05:00
Unit2E 9fa337156e makes powersinks dense when anchored (#43023) 2019-03-06 16:03:35 -05:00
81Denton ca1110eed0 Elances no longer explode when thrown (#42997) 2019-03-06 16:02:26 -05:00
ShizCalev b16b33f8d8 unfucks cyber organs (#43042)
* unfucks cyber organs

* false
2019-03-06 21:15:57 +01:00
TerraGS 2de33d27f1 fixes cult halo not being removed when deconverted (#43002)
* fixes cult halo not being removed when deconverted

* accidently removed a line of code
2019-03-06 10:55:42 -05:00
Unit2E 522459fdea Tweaks the powerfist (#43000)
* buffs the throw speed from 0.2 to 1.5

* Adds variable launch speed and gas leaking to powerfist

* Upgrades failure status with weak punch type things and special messages

* Fixes 0 content punch
2019-03-06 10:54:23 -05:00
tralezab 0a51e7e1b9 [PROBABLY READY? REVIEW WITH SCRUTINY] New event: Fugitives (#42554)
* fugitives

* lets make this a bit cleaner

* cultists and the beginnings of security detail, lots of wip

* wip security

* WALDO (and some more work on yalp, of course)

* adding antagonist teams for both hunter and fugitives, roundend report beginnings

* this whole file is shit, but hopefully a little better

* it compiles (+ space police)

* some more work

* S.E.L.F. fluff

* grammar and icon fixes

* lets finish yalp elor, give it the justice it deserves

* moves hunter spawns to ship pods + russians P1

* moves hunter spawns to ship pods + russians P2

* fugitives and hunters now recognize eachother

* hunter spawning finished(?)

* missed this

* ATH's review

* runtime fixed, added yalp's transport ability

* anturk's review

* makes hunter.dm better trust me

* oopsies

* INVOKE_ASYNC

* russian ship + finally a (bad) sprite for the capture machine

* step > pixel, thanks travis

* mooshroom review p1

* mooshroom review p2

* improper use of /improper

* waldo's radio doesn't stick, police id

* candidate picking is more flexible + minor things
2019-03-06 10:17:46 -05:00
IndieanaJones 63058be1bc Space Dragon no longer announces when not spawning (#42982) 2019-03-05 21:57:03 -08:00
skoglol cbecd7a93a Another fridge access pass (#43012)
Removes access restriction on fridges and meat fridges in areas where you
shouldn't be expected to have kitchen access. Notably, everywhere that is not
the main station kitchen. I didn't think to check this in #41923.
2019-03-05 21:12:34 -08:00
tralezab 513305620c No single root feeds the forest. 2019-03-05 14:15:55 -08:00
oranges 0267bce949 Turns out a bunch of components do not properly transfer because of (#42691)
one of three things.

    1. They don't use RegisterWithParent or UnregisterFromParent to unregister
       and register signals

    2. They use callbacks which refer to a source object, which is usually deleted
       on transfer, or lost in some manner, or simply makes no sense at all to be
       transferred

    3. the component was never designed to be transferred at all

TransferComponents gave no shits about any of this and just blindly transferred
all components, if they were actually capable of it or not.

I only noticed this because it was causing chairs to break as they would not register signals
and verbs correctly for rotation after being picked up and then placed down, and a player
reported that issue via ahelp.

Luckily we caught it before the rot got anywhere, only chairs and the shuttle subystem
tend to use this proc (Shuttle uses it on turfs), can you imagine if everything was using
this LMAO

Which is good because it's more dangerous than a loaded gun

I have added a can_transfer var, that is true when a component is valid to
actually transfer, which means the dev has actually thought about what happens when
you take the parent object away and swap it for another and all the crazy that is entailed
by this

I have done my best to audit what components are actually
transferable, but things are basically a hot mess (Thanks @Cyberboss )

The following components required edits:
Forensics:
did not register/deregister the clean_act signal properly, did not checkblood on new parent

Rotation:
did not use RegisterWithParent or UnregisterFromParent, turned out
to not be transferable anyway due to having callbacks that can be
passed in to the parent with unknown sources that we can't feasibly
reuse (i.e if you're transferred from a chair to a bed, your old rotation
call backs are no longer valid). Turns out the use case it was for (just chairs)
didn't need it anyway, so I just made it non valid for transfer.

Wet Floor:
Honestly this one is just a hot mess, it should be a subtype of the slippery
component with the extra wet turf handling.

As it is it basically manages a slippery component on top of it's own extra
functionality, so that's a major code smell.

I added registration/unregistration of the signals, and made it's pretransfer
remove the slippery component and the posttransfer add it back (via update_flags)

Components that seem transferable without issues
mirage_border
orbiter
decal
spill
storage (I hope to earth)
2019-03-05 20:27:29 +01:00
as334 3237b64188 [Ready]Fusion V6: Chaos Hyper-Torus Edition (#42748)
* Fusion 6 begins.

* Adds location effects, updates analyzer feedback.

* Fixes a messed up prob statement

* Further work on reaction and some testing stuff.

* The debuggery continues

* Fusion continues

* Removes a check that's not longer relevant

* Tries to make filtering more possible

* More tweaks to make stable fusion more accessible, prevents a rare float overflow issue, makes unstable fusion less rewarding, reduces nuclear particle damage.

* Fixes my really poor implementation of the examine for volume pumps.

* Fixes an oopsie with probability

* Merge, and also tweaks instability scaling
2019-03-05 20:23:41 +01:00
Tlaltecuhtli 6c2f37c6b1 makes floorbots fix broken tiles by default (#43007)
* makes floorbots fix broken tiles by default

🆑 
tweak: floorbots fix broken tiles by default
/🆑

* t/f

* woops
2019-03-05 13:45:37 -05:00
ShizCalev 847a285e55 Fixes adminheal not clearing heartbeat sound (#43008) 2019-03-05 13:44:34 -05:00
Mickyan e831716127 Hairstyling update (#42907)
* good hair day

* fluff

* vendor/fixes

* removes redundant loc check

* cobby reviews
2019-03-05 12:23:00 -05:00
ShizCalev 5ff539e360 Candle cleanup and fixes (#42968) 2019-03-04 20:02:56 -08:00
oranges 94cd150bea Merge pull request #43003 from tgstation/MrStonedOne-patch-3
Fix sstimer's reset buckets being stupid
2019-03-05 12:19:55 +13:00
oranges 4c5d194e4a Merge pull request #43006 from Time-Green/hide-genepulse-path
[S] Protects genepulse
2019-03-05 12:19:23 +13:00
IndieanaJones 45c7f21089 [READY] Fixed Space Dragon Swooping and Becoming Invisible (#42967)
* Load glyphid.dm

* Add glyphid spawner

* Added Glyphids

* Fix Evolution Chain, Place Glyphids Properly

* Made binary returns use True/False instead of 1/0

* Use capitals, dumbass

* Shitload of small tweaks and changes

* Something fucky happened copying over, fixed now

* Delete glyphid.dm

* Update tgstation.dme

* Update spawner.dm

* Prevent Space Dragon from Swooping, Fixes #42874

* Updating Outdated Info in Intro Blurb
2019-03-04 11:40:31 -05:00
zxaber 22a0787ac3 Allows Mecha Clamps to open Firelocks and unpowered Airlocks (#42963)
* Done and done

* I made it better good

* Update airlock.dm
2019-03-04 11:39:41 -05:00
Time-Green 8a8cdce0cd protects genepulse from peepers 2019-03-04 15:12:29 +01:00
Jordan Brown bf29adbadf Revert "Bandaid for the TGS4 Linux trusted mode bug" (#42964)
This reverts commit 360882e7ee (#41668).
2019-03-03 23:27:36 -08:00
Kyle Spier-Swenson de5b7d4d93 Fix reset buckets being stupid
Why I never did see this I don't know, its a 5 million years old bug.
2019-03-03 22:33:44 -08:00
Jordan Brown e83b6256fa Merge pull request #42972 from TerraGS/bot-cleanup
Cleans up bot construction code
2019-03-03 23:05:17 -05:00
MrDoomBringer a33052797c Gives the Centcom Podlauncher back it's old, sexy, chad UI. Also, prevents all tgui tooltips from FUCKING BLOCKING CLICKS REE (#42911)
* fuck yes


unfucks tooltips


700x700

* u got it anturk
2019-03-03 10:51:40 +01:00
SIX10 4782c687a7 Make regular Sandwich more nutritional than grilled cheese (#42971)
because lettuce and meat are better for you than 2 slices of cheese and bread.
plus stupid vegetarians
2019-03-02 14:06:31 -08:00
ShizCalev d728800fbb Fix extra "a" in technology fabricator admin messages (#42970) 2019-03-02 13:58:11 -08:00
ShizCalev 5dc1e548a3 Fix secure crates not returning a value for take_damage (#42969) 2019-03-02 13:57:40 -08:00
Militaires 5ff56fb39e Correct CQC help instructions (#42980) 2019-03-02 13:57:24 -08:00
TerraGS 03ed20a7b3 Fix a firebot runtime (#42966)
Firebots were runtiming due to multiple initializations, so this fixes that
issue by calling a proc to refill the extinguisher rather than going through
the initialize proc to do it.
2019-03-02 13:56:59 -08:00
Jordie e1d5052fa6 Merge pull request #42896 from py01/bundle
New Tactical Syndicate Bundle: Recon
2019-03-02 23:08:09 +11:00
Jordie 7687310882 Merge pull request #42947 from actioninja/magcountfix
Fixes the bullet count when unloading weapons such as the double barrel and revolver
2019-03-02 23:03:25 +11:00
Jordie 34a6197169 Merge pull request #42959 from SouDescolado/Runtimes-fix
Fixes spawner menu runtime
2019-03-02 22:43:42 +11:00
ShizCalev 4a72f37d74 Merge pull request #42953 from Kierany9/galaxy_brain
galaxy brain hivemind bugfixes
2019-03-01 15:57:43 -05:00
oranges 7a3dfa6b40 Merge pull request #42923 from ShizCalev/janicard-sign-fix
Fixes janicart /holosign interactions
2019-03-02 09:47:36 +13:00
oranges 1a3af2d0c1 Merge pull request #42925 from actioninja/bucketspritefix
Fixes mop bucket sprite not updating properly after filling with a bucket
2019-03-02 09:47:06 +13:00
ShizCalev 25d142e917 Fixes janitors not spawning with the proper janitor holobarriers (#42921)
* Fixes janitors not spawning with the proper janitor holobarriers

* one more
2019-03-02 09:46:22 +13:00
oranges c833b76980 Merge pull request #42897 from ShizCalev/beartrap-fix
Beartrap fixes
2019-03-02 09:45:05 +13:00
Coconutwarrior97 765f8e32e0 Fixes transit tube barricade spam (#42813)
* Only two transit tubes per turf can be wrenched down.

* Made a can_wrench_in_loc() proc. Placed it at start of wrench_act and afterI.use_tool.

* This aint lookin hot.

* Should be working now.

* Added proc at start of wrench_act.

* Fixed if statement and put it before to_chat.
2019-03-02 09:43:53 +13:00
Time-Green ad1dd38655 Adds snailpeople as a rare genetic meltdown effect (#42889)
Meant to be part of #42864 , but got a little big so I'll add it to wichever gets merged last.
[Snailcrawl demonstration](https://youtu.be/IL7WFpfRo4c)

PROS

- Gets snailcrawl, wich makes them greatly faster and gives them a lube trail

- Their blood is spacelube

- They get a cool armored nodrop snail shell

- They don't slip

CONS

- Very slow

- Punch is pathetic

- Tttaaalllkkk llliiikkkeee ttthhhiiisss

- Extremely vulnerable to salt

- Can't wear glasses

Adds gastrolisis, wich is pretty much [this](https://www.youtube.com/watch?v=lFbPi8o0OEU) spongebob episode where they slowly turn into snails

You can also get gastrolisis by random_reagent_id, so maintpills and botany

🆑
add: Adds snailpeople as a rare genetics accident.
sprite: Snailshell sprites by nickvr628
/🆑
Snailshell sprites by @nickvr628

Why: It's a silly gimmicky race and it's a rare occurence. Also extremely highly requested for some reason
2019-03-02 09:40:56 +13:00
TerraGS 8e68526133 cleans up bot construction code 2019-03-01 14:39:03 -06:00
Time-Green 016d739f96 Loot crates no longer explode after unlocking (#42957)
* loot crates no longer explode after unlocking

* Adds a comment
2019-03-01 10:45:03 -05:00
Kamparauta 8789c1d7e3 Changes the PAI loudnessBooster to a piano_synth, allows choosing of instrument. (#42910) 2019-03-01 13:50:16 +01:00
ShizCalev 05f2ac7317 Cleans up (mostly) defunt crit_fail var (#42908) 2019-03-01 13:45:30 +01:00
ShizCalev f643036911 Merge pull request #42946 from TerraGS/floorbot-update
Adds floorbot variations
2019-02-28 22:14:29 -05:00
ShizCalev 66fd697db4 Fixes 10mm rifle mags and sniper rounds not reporting ammo/updating material values. (#42938) 2019-02-28 11:46:23 -05:00
tralezab 7762e72405 New trait: Unstable (#42904)
* nice.

*  They exist to cease.

*  "They've got eyes inside my head!"

* frick

* unstable insanity

* Just try taking this bull by the horns. (eyeballs)

* It's a thankless job, and you'll probably die in an explosion. But the pay is pretty good.

* "The best denials are simply that: a beginning and end unchanged, a dream with no memory."

* fixes the dme
2019-02-28 10:35:13 -05:00