Commit Graph

27809 Commits

Author SHA1 Message Date
Tad Hardesty bbef4190f8 Fix runtime when lightning smiting non-humans (#43537) 2019-04-08 15:54:32 -04:00
Tad Hardesty b992620011 Fix runtime when setting up a sec character before atoms initialize (#43527) 2019-04-08 15:54:06 -04:00
Tad Hardesty 9c9cc9110a Improve cancellability of Run Weather admin verb (#43528) 2019-04-08 15:53:44 -04:00
Tad Hardesty c7390b28d7 Give Cyborg modules their icons in the map editor (#43509) 2019-04-08 10:39:55 +02:00
Tad Hardesty 38977aa740 Fix Alt-Click to rotate soda and booze dispensers (#43522) 2019-04-08 10:37:39 +02:00
Kyle Spier-Swenson a052185777 Captain now requires playtime as another head role (#43495)
By default (assuming the department based exp lockout config is enabled), hos requires 5 hours as security. but the captain only requires 3 hours as crew?

Seems silly. 

@iamgoofball I wonder if banned accounts still get notifications.

Somebody with more time than me: make the config for these use a keyed list for per-job overrides, rather than a flat head override.

Somebody else with more time than me: make a config that allows readying for time restricted roles anyways, but only at low priority.
2019-04-08 10:36:29 +02:00
Tad Hardesty 09949fe611 Fix welfare being given to everybody else with the same job (#43490)
* goddamn NEETs ruining my economy, fixes #42387

* Fix remaining broken call to add_neetbux
2019-04-08 10:29:51 +02:00
Kyle Spier-Swenson 2cace871d8 Handle OoM errors (#43349)
Sometimes a reason 1 restart will work to fix these for servers without
tgs3.

This works on tgs3 even though the api sleeps, this will likely not work on
tgs4. In those cases the world/Reboot call will likely still bring the
server back up to a functional point that an admin can do a tgs restart via
the verb.

There is no point in attempting to notify clients, every attempt at doing
so failed.
2019-04-08 00:03:15 -07:00
William Wallace c06ec19eb0 Update canister icons when connected to a port (#43518)
I found that when the valve of a canister was closed, the
.../canister/process_atmos proc would never reach its update_icon call.
I've fixed that by removing the early return and having a single
update_icon call at the end run when necessary.
2019-04-07 14:05:05 -07:00
AnturK 67deb481be Switch preloader to world proc (#43516) 2019-04-07 14:04:18 -07:00
QFMVC 8054bc34db Give space cleaner the ability to clean people (#43494)
Space cleaner sprayed, splashed or vaporised onto someone will slightly
improve their hygiene. Effective janitors can spray stinky spessmen to
stave off the stench long enough for the offender to have a shower. Space
cleaner will only stop you from stinking for a short time, unlike a shower
which will keep you fresh for much longer.

The amount of cleanliness from a single application of space cleaner is
capped, so a chemist dumping a bluespace beaker of space cleaner on their
head is not going to be as effective as a shower.

Giving janitors an extra way to help the crew is probably good, especially
because this additional mechanic can't be replaced by janiborgs or
cleanbots.
2019-04-07 00:34:53 -07:00
RaveRadbury 89f4e05079 Allow bike horn and baguette to equip to belt and back (#43471)
A lot of equipment can be placed on the back and belt slot. Much of this
equipment is job specific. Sadly, the Clown and Mime have been left out
of the fun.

Why should all the other jobs have the fun of belt and back slots?
Sometimes you want to mosey around the station like a honkin' cowboy,
your bikehorn clipped securely to your belt. Now you can. Your trusty
honkshooter is ready to go. DRAW!

Or maybe you're a Mime who wants his crusty baguette saber at his side.
EN GARDE!
2019-04-06 01:28:37 -07:00
py01 bab739ca81 Fix armblades sometimes having trouble prying open doors (#43481) 2019-04-05 15:42:09 -07:00
ShizCalev a0652c3700 Enable tac reloads for most ballistic weapons (#43466) 2019-04-04 23:51:58 -07:00
AnturK b9210e9811 Fix a few nanite runtimes (#43478)
Just some missing sanity checks.

* Fixes spreading nanites runtimes.
* Also glitch runtime.
2019-04-04 21:54:59 -07:00
Brett Williams e23cc06531 Changes Monkey Tackling to Function Like Disarm Rework (#43424)
* Fix the monkies

* pinned commit
2019-04-04 16:11:17 -04:00
oranges 627cd2bb0c Merge pull request #43484 from Militaires/clownsuit
fixes clown suit datum runtime
2019-04-04 19:10:22 +13:00
Rob Bailey a9b39afe66 [READY] Disarm Rework: Shove that Dickhead (#42958)
The War on Stun Based Combat Phase II
About The Pull Request

A massive change in gameplay that affects more than just disarm. Hopefully in an interesting way.
There's two parts to this, part 1 is that disarm's functionality has been entirely stripped out and replaced with essentially a new purpose: Shoving.
Shoving is the new action that occurs when clicking on people while in the disarm intent.
Shoving someone pushes them one tile away from you. If there is otherwise nothing blocking them, they are slowed down very slightly for 3 seconds. If you shove someone again while they are slowed, it knocks ranged weapons out of their active hand. I'm not sure about this part and may buff or remove it depending on how it works in practice.
If the blocking tile has a table on it, they're pushed onto it knocking them over for 3 seconds. If it has another human on it, it knocks them both over, the collateral victim for 1 second instead of 3. If the tile is otherwise blocked besides them, it knocks them down for 3 seconds. All knockdowns cause you to drop items, and do not stun at all and can be immediately crawled away from.
However, once knocked down, if you are shoved again it paralyzes for 4 seconds. This is the same length as the old disarm push. It cannot be chained or extended, shoving them again while they're paralyzed does not extend the length of the paralyze. Once it ends, the person will be up and moving.
Now you might be thinking, why would I want to shove someone unless they're against a wall?
Here's part 2:
Moving into someone in a hostile intent no longer pushes them. They'll stay where they are and your movement is blocked. If you want to get someone out of the way, you need to shove them.
Why It's Good For The Game

Changes a previously RNG based mechanic that was basically just spammed until you got that lucky "I win" roll into a positioning based utility that has a point to use in many situations. Livens up simple melee combat and makes fighting in confined areas more lively and unpredictable. Introduces some new epic gamer strats, I've been playing around and it's pretty fun.
Also why not try something really crazy and see what happens? If it's shit it can be reverted :^)
Changelog

Special thanks to whoneedsspace, the inventor of the singlecap, for deshitcodifying this hard.

cl
add: Disarm has been reworked, instead of an rng based system instead it pushes people away from you. If their movement is blocked it knocks them over. Shoving someone twice quickly will knock ranged weapons out of their hands.
del: Moving into humans while in a hostile intent no longer pushes them.
tweak: Passive grabs need to be resisted out of while on the ground, and can't be directly crawled out of
/cl
2019-04-04 18:58:09 +13:00
militaires 72121f2974 fixes clown suit datum runtime 2019-04-04 02:12:01 +02:00
FloranOtten 80ab07fad7 spellcheck (#43467) 2019-04-03 14:27:18 -04:00
Tlaltecuhtli ec1ad61558 new cargo crates & tweaks (#43454)
* 1

* 2

* finall pre pr

* oof

* oof

* testing merge conflict fix

* test mk2

* test mk3

* plant & chem

* bvcgr

* fixed stuff

* grammar stuff

* fixes clothing + cobby bribe

* new sprites by wjohn

* Update code/modules/clothing/suits/armor.dm

Co-Authored-By: Tlaltecuhtli <33834933+Tlaltecuhtli@users.noreply.github.com>

* tweaks .38 stuff

* Update code/modules/cargo/packs.dm

Co-Authored-By: Tlaltecuhtli <33834933+Tlaltecuhtli@users.noreply.github.com>

* nuclear option
2019-04-03 14:23:38 -04:00
nervere d04fd9417c removes unused secrets panel button, fixes a button in the global player panel (#43427)
* fixes secrets topic check_antagonist

* removes code related to check_antagonist topic that doesn't work or does nothing

* changes the name of the button in the secrets panel

* removes old secrets panel topic check_antagonist

* player panel antag button no longer relies on secrets topic

* player panel antag button no longer relies on secrets topic

* readds something i shouldnt have removed
2019-04-03 18:21:26 +02:00
ShizCalev d128a12773 paraplegic vehicle fixes (#43399)
* paraplegic vehicle fixes

* im on a boat
2019-04-03 11:10:57 -04:00
Tlaltecuhtli 05d9b6056c fixes large ebows insane dmg (#43446) 2019-04-03 10:36:10 -04:00
John Ecron Smith 3b38b37f7f Adding laceup shoes to curator's outfit (#43441)
Adds laceup shoes to curator's outfit.
2019-04-03 10:33:05 -04:00
ShizCalev d1c3ac84ba allows byond members to bypass pop cap (#43458)
* allows byond members to bypass pop cap

* fix

* new line
2019-04-03 10:20:03 -04:00
Brett Williams 5008b3e93f Fix "at at" in map template loading logs (#43460)
Removed unlawful reference to Disney's Star Wars franchise in map logging.
2019-04-02 18:10:20 -07:00
nervere 80ff869077 Fixes for asay, asay darkmode, and asay when custom asay colors enabled (#43422)
About The Pull Request

Fixes several annoying and unintentional things about asay.
Fixes #43370
Changelog

cl Nervere
fix: Default color for when custom asay colors is not enabled is now orange, not red.
fix: Asay is now properly bolded in lightmode.
fix: Asay is now properly bolded in darkmode.
tweak: Default color for when custom asay colors is enabled is now orange, not black.
/cl

closes #43370
2019-04-03 10:51:24 +13:00
Militaires 3ff0287d90 [READY] Outputs Datum Cooldown: For Real Guys This Time (#43038)
cl Basilman
fix: Added a cooldown for datum outputs
/cl

also added an arg called do_owner in playsound that lets the owner of a datum output be different from the atom that plays it, chiefly used for component/squeak so that you can apply the component directly to any single atom without having to fuck with said atom's datum_outputs list so that it can properly play the sound, since the datum output is already stored within the datum component itself.

also send_info now returns true or false based on whether it's cooling down or not, i dont like this and i initially just had a var for whether it's cooling down or not but raz said it saves a var so i guess whatever ill just have it like that
2019-04-03 10:48:37 +13:00
ShizCalev 27c66097c6 Fixes locker bolts moving mobs not valid for insertion into lockers. (#43439) 2019-04-02 16:10:58 -04:00
MrDoomBringer 4642306b15 does it (#43451) 2019-04-02 21:56:04 +02:00
zxaber 3fdd7746ef Deflection tweaks with the MK-I Ripley in mind (#43304)
* (deriuqer) yrammuS

* Also this

* Guess I'll do it this way, then

* You can hit the arms now, too

* Update code/game/mecha/mecha.dm

requested by ShizCalev, committed by Zxaber

Co-Authored-By: zxaber <37497534+zxaber@users.noreply.github.com>

* Update mecha.dm

* commited a comment
2019-04-02 20:59:57 +02:00
moo 596d57cb6f Refactored magic guns to use process_fire() for checks (#43432)
This was previously using afterattack()
2019-04-02 14:00:02 -04:00
MrDoomBringer 0c4fe77857 whups i dropped my monster check i use for my magnum sanity (#43445) 2019-04-02 13:58:50 -04:00
Rob Bailey f9a6864774 ez clean buff (#43444) 2019-04-02 12:41:47 -04:00
Barhandar c3d471ee19 Buffs plasteel golems (#43415)
* VERIFIED golem buff

* Oops wrong proc

* Annnd the description mentioning this.
2019-04-02 01:43:30 -04:00
WJohn b8c032f7c0 New 357 Revolver Sprites (#43438) 2019-04-02 01:34:59 -04:00
Brett Williams a3bcd15595 Return of the Ass: Photocopier Edition (#43437)
* Return of the Ass

* One last commit, master...

* spring cleaning
2019-04-02 01:33:09 -04:00
pireamaineach 7c821fc1fa Make the .45 magazine actually update per round. (#43433)
Makes the .45 magazine actually update per round rather than just showing
full or empty.
2019-04-01 16:14:41 -07:00
Tad Hardesty 3d098c890a Standardize obj/updateicon() and update_icons() to update_icon() (#43418)
* Standardize updateicon to update_icon

* Standardize obj/update_icons() to update_icon()

* Fix pneumatic cannon infinite loop
2019-04-01 18:08:19 -04:00
MrDoomBringer 34ffee6d45 fixe (#43443) 2019-04-01 18:01:44 -04:00
Vile Beggar c20a86e79d supreme boo (#43414) 2019-04-01 11:59:12 -04:00
Tlaltecuhtli 7aa9332cab cryo cell start with auto eject true (#43420)
🆑
tweak: cryo cell starts with auto eject true
/🆑
now malkraz has a debt of 1 gbp with me
2019-04-01 10:43:20 -04:00
Tlaltecuhtli 15357e6288 Fix grammar error in void magnet (#43426) 2019-03-31 22:09:08 -07:00
Brett Williams b14809f889 Refactored magic guns to use process_fire() for checks
This was previously using afterattack()
2019-03-31 20:29:59 -03:00
oranges eaf73214e6 Merge pull request #43409 from AutomaticFrenzy/patch/blood-brothers
Fix blood brothers causing the whole end-round report to be bold
2019-04-01 10:33:46 +13:00
AnturK 71285cf7c4 Remove update icon in portable atmos process (#43392)
Canisters already do this manually, and other portables visuals don't care
about their contents changes.
2019-03-31 10:37:53 -07:00
francinum 36ec6ec90f Fix inter-server crosshop (#43406)
Lists start at one. Thanks Lummox.
2019-03-30 14:16:42 -07:00
ShizCalev f2cea780aa Move map errors to their own log file (#43376)
In interest of getting things fixed without having to constantly crawl
through game.log to find map issues, moved them to their own log file.
2019-03-30 13:54:55 -07:00
Vile Beggar e8fb46e746 Fix needing to remove clown/mime mask to shower (#43390) 2019-03-30 13:53:49 -07:00