Commit Graph

24203 Commits

Author SHA1 Message Date
Qustinnus 908ccfe7b3 Fixes some material datum bugs (#47049)
* fixes

* chair

* ass

* fixes

* dumb

* done

* fix
2019-10-14 00:36:56 -04:00
Yenwodyah d519d8887e Stops traitor mode from announcing the number of antags at roundstart (#47078)
About The Pull Request

Someone forgot to take out their debug statement, so the game was announcing the number of traitors to everyone on the server at the start of each round.
Why It's Good For The Game
About The Pull Request

Someone forgot to take out their debug statement, so the game was announcing the number of traitors to everyone on the server at the start of each round.
Why It's Good For The Game

Meta-knowledge is bad
Meta-knowledge is bad
2019-10-14 15:28:41 +13:00
Fikou 31ab3ac830 power tool refactor (#46974)
Power tool refactor
2019-10-13 20:34:52 +02:00
TheChosenEvilOne f193939b57 Multi-Z fixes (#47046)
* Fixed multi-z throwing and changed isliving in stairs.

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>

* Openspace can no longer be deepfried.

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>
2019-10-13 19:45:10 +02:00
carlarctg 5cbe594e9d Update singularityhammer.dm (#47040) 2019-10-13 19:44:37 +02:00
skoglol b68abe7e6d Adds random character when antagonist preference (#46952)
About The Pull Request

Well known statics rejoice! You can now choose to have random name/body/age/gender whenever you roll roundstart antagonist.

Since player mobs are generated before antag datums are handed out, I added a list that collects minds chosen as antags during pre_setup() to keep track of this.

"Other" was also missing from the random gender, added it.

Wizard, clown op, nukeop, latejoin and midround antags are excempt.
Why It's Good For The Game

Some static namers get metagamed to the extreme when antagonists, this should help alleviate that while allowing them to keep static naming for the RP. Keep in mind all conversion, midround and latejoin antag rolls are excempt, this is not a guarantee someone is a non-antag.
Changelog

cl Skoglol
add: Random name/body/age/gender when roundstart antagonist preference added.
add: Random gender will now have a chance of picking "Other".
/cl
2019-10-13 17:00:17 +13:00
skoglol d735e0bf36 Yet another debug outfit update (#46982)
About The Pull Request

Less uranium in the material box due to radiation. Suit helmet has had geiger sound reduced to 0, and a manual geiger counter added to the box. Also added a death wand for easier and cleaner killing.
2019-10-13 16:55:39 +13:00
nemvar 62a02f09f1 Medanalyzers are now the tier 2 option for scanning people. (#46917)
About The Pull Request

Removes medical analyzers from medkits.
Removes the ability to print medical scanners from the autolathe.
Why It's Good For The Game

Medical analyzers are currently probably one of the common items in the game. Not only do mappers place them all over their maps but they are also in every medkits, which, funnily enough, are also fucking everywhere.

This leads me what I call the Cobb's Assortment of medical scanner quality:
Tier 1: Ghetto tier. Click your healthdoll, see if you burned for fingers on the kitchen plate.
Tier 2: Normal Analyzers. Somewhat restricted but still fairly common. Almost every department has one but you won't find on randomly in the hallways.
Tier 3: Advanced Analyzers: The shit medbay can print after research, nuff said.
Changelog

cl
balance: Removed health analyzers from medkits. Removed the ability to print health analyzers from autolathes.
/cl
2019-10-13 16:50:12 +13:00
Ghom 2821303c74 Stops non-alphanumeric graffiti decals from being named "letter". (#46979)
About The Pull Request

Does exactly what it says on the tin.
text2ascii accepts text strings with length higher than one character as first arg, so we need to check against that beforehand.
Why It's Good For The Game

Fixing a (likely unreported) mild issue with the game.
Changelog

cl
fix: non-alphanumeric graffiti decals will no longer display as "letter".
/cl
2019-10-13 16:42:35 +13:00
James fffb74bdcf [READY] Welders consume fuel when they destroy an object during attack (#46842)
About The Pull Request

Welders didn't actually consume fuel if their attack deleted an object. This was first noticed when welding space vines, in that the welder didn't consume any fuel to do so. Further testing showed that this was the case for any object that gets destroyed on hit, including APCs, Air Alarms, Girders etc.

Problem was that the code for actually consuming fuel after an attack is in the afterattack proc which doesn't actually get called if the target is QDELETED. PR moves that code to the attack proc, along with (regrettably) implementing attack_obj too. This feels hacky and reeks of duplicate code, so if anyone has a better option for how I could implement this fix I'm all ears.
Why It's Good For The Game

Fixes unintentional behavior
Changelog

cl
fix: Welders now consume fuel when they destroy an object
/cl
2019-10-13 16:41:14 +13:00
Arkatos1 5e47463792 Silicon PDA fix (#46922)
About The Pull Request

This PR makes it so that silicon PDA verbs like toggle ringer are given only to a silicons that actually have one, like AI or pAI. This is also consistent with other similiar silicon items, like silicon camera.
Why It's Good For The Game

Less bugs.
Changelog

cl Arkatos
fix: Only silicons with a valid PDA will now get PDA-related verbs.
/cl
2019-10-13 16:39:00 +13:00
Rob Bailey e1683f674f Merge pull request #46978 from willox/duplicate-variable-stuff
removed a bunch of duplicate member variable definitions and entirely duplicated types
2019-10-12 03:44:15 -07:00
Rob Bailey e41d8a24ff Merge pull request #46950 from YPOQ/bubblegumspawnfix
Fixes bubblegum spawn
2019-10-12 03:30:37 -07:00
Rob Bailey 0310061f5f Makes the health analyzer's damage list into columns (#46793)
* Makes the health analyzer body part damage list into colums, and other small span fixes.

* Typed list magic fix.

* Adds font face.

* Reformat into a html table and also into a list().
2019-10-12 03:29:46 -07:00
YoYoBatty a0b9031ca5 Fixes cold water vapour not freezing turfs properly (#46908)
* Fixes cold water vapour not freezing turfs properly

* Update code/game/turfs/open.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>
2019-10-11 15:45:29 -04:00
oranges 1c266bb040 Merge pull request #47008 from AnturK/arenadoorfix
Fixes arena controller door opening.
2019-10-11 13:52:32 +13:00
Toast 4c9b0f9551 Emergency Medical Holodeck is a Workplace Hazard (#46985)
About The Pull Request

I moved the Emergency Medical module for the Holodeck behind the safety / emag lock, while also moving up 1218 AD Thunderdome a few slots, so there are less chances of someone miss clicking the first thing that would have been underneath Emergency Medical, the Atmos burn test.
Why It's Good For The Game

To be quite honest, the Emergency Medical Holodeck module is used by those who want to bypass other departments to cure their ailments. If there was a chem dispenser in the module, the holodeck would be able to pretty much replace the entire medical department.

Need surgery? Have a meta-friend perform surgery with no chances of failure because the holodeck provides all of the tools needed, including an operating computer.
Need to cure your common cold? Magic space holodeck has a Pandemic machine.
Need to keep your friend's rotting corpse defibbable? Holodeck has stasis beds.

I believe this particular holodeck module reduces departmental cooperation and reliance, because you have consequence free alternatives to get your harmies fixed. Ghetto surgery, for example, isn't a viable alternative because you don't need to find and use improvised surgical tools when proper tools exist with no strings attached. The abandoned medbay exists and can be used as a backup medical or hub to get back alley procedures done.

"But Synn, I am not an antagonist with access to an Emag to unlock the safety."
Silicon players are able to toggle the Holodeck's safety features, and enable the medical module from there, if the situation is serious enough to require said action when it comes to preventing human harm if they are still on Asimov's laws. A smart move afterwards would be turning the safety back on once the module is already loaded, thus to prevent harm from someone selecting the more... flavorful choices.

"But Synn, I don't want Doctor Jimbo or Roboticist Karen to perform surgery on me. I would rather have Assistant Dave do it because I know them."
Assistants aren't trained surgeons from Centcom, and the solution for bypassing the proper department that already has a surgical setup should be through ghetto alternatives. Considering how medical lately has been moving more towards surgery as the answer to curing most ailments, this should give Doctors more opportunities for work as there would be less people bypassing the system using holograms.

Honestly, if my tiny brain knew how to properly code, a better alternative to locking the emergency medical module would be having the station to be on a code red alert level, but I am not sure how to do that without breaking a lot of eggs.

cl
balance: CentCom has deemed use of the holodeck's emergency medical module unsafe, as it allows for procedures to be carried out by untrained crew members. If emergency medical procedures are needed, do not tamper with the machines and have your station's AI or cyborgs unlock the safeties.
/cl
2019-10-11 11:43:59 +13:00
imsxz b5b9fd30d7 turret fix (#46995) 2019-10-10 18:39:32 -04:00
nemvar c38a7a3bb5 Removes a bunch of var/ in procs (#46946)
* Removes a bunch of /var in procs

* reset this

* Why wasn't this already?
2019-10-10 04:20:27 -07:00
AnturK 9d8d1c420b Fixes arena controller door opening. 2019-10-10 08:50:09 +02:00
ArcaneMusic e7dacc57e4 Adds more functionality to the Medical Kiosk with upgrades. (#46884)
* adds rads upgrades, improves the formatting a bit

* Hey mapmerge want to work this time?

* alright what about now

* sigh

* alright back to standard

* Recompiles tgui

* Box Station map update hopefully?

* Now for the rest of em

* Unintentionally removed an intercom from donut, fixed

* Allows for players to multitool the kiosk board to change the cost to use.

* Alright lets clarify some booleans

* Correctly uses booleans in JS

* Mapp Diff don't be that way

* Update tgstation.dme

dot dme files are cursed and I have proof
2019-10-09 16:09:11 -04:00
Qustinnus 270f73671e fixes mats (#46994) 2019-10-09 20:10:55 +02:00
kingofkosmos 63f6280f44 Reformat into a html table and also into a list(). 2019-10-09 20:55:28 +03:00
Fikou e450be44dc surgery tool refactor (#46856)
* awooooooooooooooooo

* a

* aw shet

* woops!!

* a

* wow heck you
2019-10-09 12:25:42 -04:00
Urumasi 6e7801550b Moves reagent fill code and adds caps to plastic water bottles (#46878)
* Adds caps to plastic bottles

* Non-crafted water bottles now spawned closed

* Added warning message for closed bottles, fixed minor bug

* meme

* Makes the warning only show up when doing valid actions with the bottle

* Clumsy people now have a chance to lose the cap

* Fix small bottle's cap when fallen over, bottles now turn upright when opened on the floor

* Add a minor positive moodlet on bottle flip

* Adds a relic lavaland water bottle that always lands upright

* Moves container fill overlay to reagent_containers, changes glass/beaker/waterbottle to glass/waterbottle

* Make actions with closed cap early return

* Minor code cleanup
2019-10-09 12:05:52 -04:00
81Denton 3863d6b4d5 Fixes spraying/painting over dark paint (#46854)
* Fixes spraying/painting over dark paint

* Blacklists infinite spraycans from pyrite slime extracts
2019-10-08 21:50:09 -07:00
Fikou 3e0e1e9fda chap things now cover what they should (#46866) 2019-10-08 21:47:43 -07:00
William Wallace c688bc39f7 remove duplicate var from /obj/structure/closet/cardboard 2019-10-08 23:25:38 +01:00
William Wallace ea39325ec5 remove duplicate var in /obj/structure/flora/rock/jungle 2019-10-08 23:24:28 +01:00
William Wallace b59c809bd5 remove duplicate var definition in /obj/item/storage/toolbox 2019-10-08 23:23:09 +01:00
William Wallace d83ac45514 remove duplicate /obj/item/storage/backpack/duffelbag/syndie/med/medicalbundle 2019-10-08 23:22:03 +01:00
William Wallace 8221f6de87 remove duplicate var definition in /obj/item/stack/sheet/paperframes 2019-10-08 23:20:33 +01:00
William Wallace 15e5d098af rename dupe icon_state on /obj/item/stack/sheet/animalhide/monkey to item_state (still does not exist) 2019-10-08 23:19:12 +01:00
William Wallace 7f702163f4 remove duplicate var definition in /obj/item/pneumatic_cannon/ghetto 2019-10-08 23:15:32 +01:00
William Wallace 84808b77c4 remove duplicate var definition in /obj/item/toy/plush/slimeplushie 2019-10-08 23:13:32 +01:00
William Wallace 58ebaf07e9 remove duplicate var definition in /obj/structure/checkoutmachine 2019-10-08 23:11:01 +01:00
William Wallace e8a0b723de stray /obj/effect/turf_decal/trimline/brown/filled/end -> /obj/effect/turf_decal/trimline/neutral/filled/end 2019-10-08 23:09:04 +01:00
William Wallace 00a29087d5 remove duplication var definition in /obj/effect/decal/cleanable/blood/tracks 2019-10-08 23:01:20 +01:00
William Wallace 6b13eeac45 remove duplication definitions in /obj/mecha/working/ripley/deathripley 2019-10-08 22:52:10 +01:00
William Wallace 7412197317 remove duplicate definition of /area/vacant_room's icon_state var 2019-10-08 22:49:05 +01:00
William Wallace 42904e74b4 remove duplicate /obj/item/circuitboard/machine/protolathe/department definition 2019-10-08 22:23:40 +01:00
William Wallace 7017b98d60 remove duplicate /obj/item/circuitboard/machine/protolathe definition 2019-10-08 22:23:00 +01:00
Fikou 714b0ae2f1 the power of the M E D I C A L W R E N C H now makes you glow (#46927)
* awoo

* awoo

* no awoo $50 fine
2019-10-08 23:21:08 +02:00
Qustinnus a394ccdc2b Material datum chairs & tables and applies materials to all items (Now with less pain for mining & RnD) (#46525)
removes materials list from items, uses custom_materials instead. This might introduce some bugs so we should testmerge this for a while (and Ill test stuff locally as much as I can)

this also adds material crafting to sheets. Test case being chairs. In the future we can add stuff like tables, walls, doors etc.

also applies materials to everything, with fixes, which can close #46299
2019-10-08 11:06:02 -04:00
YPOQ 6b5a0c0a4d Fixes bubblegum spawn 2019-10-07 15:26:50 -06:00
Mickyan 1e6e9c9440 Adds drip-feeding mode for the iv drip (#46845)
* drip feed

* verb to altclick
2019-10-07 16:13:40 -04:00
kingofkosmos 71644568b5 Personal interaction messages to simple animals (#46744)
* Adds attacktext2 and friendly2 messages for personal "you" messages in combat.

* Adds response_help2, response_disarm2 and response_harm2 -messages for interacting with simple animals. Also removes unnecessary, already inherited, ones.

* Small extra: Adds personal messages for gun firing.

* Adds personal messages to grabs and fixes shoe stealing messages.

* Fixes open someone else's internals valve pronoun.

* Replaces response_help --> response_help_continuous, response_help2 --> response_help_simple etc. Also adds autodoc to simple_animal.dm variables.
2019-10-07 21:18:42 +02:00
spessbandit 87e3687bf2 Adds custom arcade game text for Halloween and Christmas. (#46795)
* Adds special arcade enemies for Halloween and Christmas. Moves arcade stuff to json file in preparation to add more eventually.

* adds custom weaponry

* fixes bug
2019-10-07 12:17:11 -04:00
carlarctg d6210b95ce Adds fireproof masks, and tweaks flameproof atmos clothing (#46732)
* the masks

* the startups

* more touchies

* whoops

* actually this is useless

* that's better

* i made a whoopsie boopsie

* bullying is not okay

* should stop coding at 2 am, but i am being a hypcrite now
2019-10-07 10:55:22 -04:00
AnturK d6477a1757 Fix arena controller topic (#46904) 2019-10-06 17:39:11 -07:00