Commit Graph

811 Commits

Author SHA1 Message Date
TWATICUS 8facec32c9 bola time 2020-02-27 09:48:25 -05:00
LemonInTheDark df9d859da8 Fixes tesla bugs, makes code better (#49260)
* Cleans shit up, adds some upper limits on zap count, makes explosions less commen. Need to fix apc issue before
I test how it plays

* Mood, buffs and nerfs tesla

* Cherry-Picking

* eyyo

* back to basics

* aight

* broooooooooooooooooo

* adds else

* range

* fixes shit

* Sure

* Cleans shit up

* Fixes prob issue

* Gee I like this spooky guy

* I swear to god if prob picks just makes a list I am gonna blow a gasket
2020-02-27 12:06:52 +01:00
Arkatos1 59379b371f tgui: Malfunction Module Picker (#49532)
* Module Picker UI

* Bugfixes, tweaks, malf theme

* Malfunction theme removed, generalized Uplink interface and tweaks

* Revert "Malfunction theme removed, generalized Uplink interface and tweaks"

This reverts commit e30dd183567325dd7a339ec3eb9d237a98b5fe3e.

* Rename and cleanup

* Cleanup
2020-02-27 01:19:26 -08:00
Bobbahbrown 63d65bf7ba Unsanitized input on blob broadcast allows HTML injection (#49561)
About The Pull Request

Unsanitized input allows for raw HTML injection on broadcasting message as blob. The repeated message by blob mobs is sanitized, so clients are safe, but still allows HTML injection into the blob's chat window.
2020-02-25 15:26:49 +13:00
ShizCalev 4316f79d32 Fixes some inconsistencies with CentCom & Nanotrasen capitalization, and a couple typos (#49469)
typo fixes, inconsistencies with Nanotrasen capitalization, ect
2020-02-22 22:35:53 +13:00
ShizCalev 12bf56f5df Merge pull request #49449 from XDTM/deadNdeaf
Makes sixth sense only able to hear regular deadchat
2020-02-20 22:56:16 -05:00
Bobbahbrown 476399a346 the span of these changes is immense (#49432) 2020-02-20 13:48:13 +01:00
spookydonut 6401ba5708 Merge pull request #49421 from ShizCalev/define-cleanup
Cleans up redundant math defines
2020-02-20 19:32:36 +08:00
XDTM 19655de8c7 Makes sixth sense only able to hear regular deadchat 2020-02-19 18:57:22 +01:00
ShizCalev eb1ebaaad3 Merge pull request #49350 from Iamgoofball/you_son_of_a_bitch_im_in
Adds more flavor to conversion.
2020-02-18 23:32:58 -05:00
ShizCalev d1e853f9c8 Merge pull request #49409 from cacogen/batonofshieldsunchecked+15
Stun batons respect shields
2020-02-18 22:50:59 -05:00
Thunder12345 93c3086ac1 No longer tells you to use a non-existent rune to sac (#49355) 2020-02-18 12:11:18 -05:00
ShizCalev 7209ac3c93 Removes unnessacary math defines 2020-02-17 23:09:09 -05:00
Iamgoofball bb4ca7bd36 Update runes.dm 2020-02-17 16:01:03 -08:00
Iamgoofball 41c2190280 Update brainwashing.dm 2020-02-17 16:00:11 -08:00
JJRcop a1392847bd Remove ismovableatom macro (#9) 2020-02-17 15:03:16 +01:00
cacogen 300df18eaf Stun batons respect shields
Also successful clumsiness rolls now stop stun baton attacks rather than just attacking the user as well
2020-02-17 22:28:15 +13:00
AnturK e3fca45a78 Fix a few small runtimes (#49352)
Nothing special here, mostly sanity.
Defib hud is awful, needs rewrite.
2020-02-16 00:40:11 -08:00
nightred 395bebcdcc [READY] Space Suits use cells and warm the wearer (#49028)
About The Pull Request

This makes space suits use a cell and warm the wearer, This was handled by the handle_environment proc in the past with an override to make the suits work. This corrects this issue, and removes the override.

All space suits will have a cell installed at round start, this cell will last 15 min on average usage.

The cell cover can be toggled by alt+clicking (press the button), or using a crowbar (just pry it open) on the suit.
With the cover open you can remove the cell by using the suit in hand, or ctrl+clicking the suit.
As well with the cover open you can use a screwdriver to set the thermal regulator's temperature. The normal range is 20 c to 45 c, do not use an emag on the suit to increase the temperature range.

Examining the suit will report the temperature setting and the cells charge, if the cover is open you will also be able to see the type of cell that is in the suit.

Suit storage units will now charge the cells in suits, they will also require power to operate properly now.

Why It's Good For The Game

    Space suits should be managing the wearers temp in space not using some override.
    Lizards now have a portable heater in the form of any space suit.
    Now that suits need a cell it is not as easy to spend all session in a space suit.
    New interactions with hardsuits and emp's give nice combat buff to an underused item.
    Nuke ops can raid xeno for some nice yellow cells, or science for a big old bluespace cell.
2020-02-15 11:32:54 +13:00
iamgoofball a799487fb5 fixes 2020-02-14 04:47:02 -08:00
iamgoofball b8cb713aad You son of a bitch! I'm in. 2020-02-14 03:04:42 -08:00
Fikou 730dc2d261 makes the nuke op leader getting the war declaration a config (#49279)
* the war declarator is now a config

* makes war ops a config

* makes war ops a config

* update 1

Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>

* update 2

Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>

* update 3

* ehh??

* grognak

* yes this works

* yeah ok togopal

* fuck

* heck

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
2020-02-13 21:08:26 -05:00
Tlaltecuhtli 89ffb407b6 Grammar fix in valentine code (#49341) 2020-02-13 16:37:18 -05:00
Jordan Brown 10563d09ec Merge pull request #49272 from Buggy123/patch-110
Nuke Ops reinforcements now work on-station
2020-02-11 13:35:44 -05:00
AnturK e40e22da6b Another runtime fixes batch. (#49209)
* Slime gland runtime fix.

* Logout ahelp logging runtime.

* Crafting non-items runtime.

* Turret building runtime.

* spacevine runtime.

* forcesay runtime fix.

* One less var
2020-02-10 10:50:36 -05:00
Buggy123 39ccfdbbad Nuke Ops reinforcements now work on-station 2020-02-09 18:26:00 -05:00
cacogen 9436ed69a8 Makes abductor baton child of stun baton (#48766)
* Makes abductor baton child of stun baton


- Clarify var names and reorder vars in baton defines
- Slightly simplify active baton wash code

* forget about ()
2020-02-07 14:53:14 +01:00
skoglol a28b24f149 Completely removes cloning (#48668)
* Removed from code

* Removes cloners from maps

* Some more references, now compiles.

* Reduces availability of replica pods

* DNA scanner and tech disk rebranding

* pubby door name, cargo pack description
2020-02-04 16:04:06 -05:00
Jordan Brown ce9577663a Merge pull request #49173 from ninjanomnom/material-lazy-init
Makes the global materials lookup lazily initialized
2020-02-04 11:05:59 -05:00
Fikou 8a38734fe9 xeno names keep consistent numbers through evolution (#49150)
* makes xenos have consistent numbers through evolutions

* makes benos have consistent numbers through evolutions

* this may be better

* pls work

* this should work

* FUCK you

* fuck
2020-02-04 07:30:47 +01:00
Qustinnus 48de09b7a4 Edible component; be gone vile organ code (#48596)
* component

* progress

* stuff

* Makes minor progress on edible component

* Finishes component and applies it to organs

* newline

* forgot to send signal

* domob addition

* wave that organ flag

* return adde

* fixes some minor issues

* fixes

* done

* done

* done

* added last one

* done

* done

* fix
2020-02-04 01:05:55 -05:00
skoglol a97b90bc3f Slight adrenal buffs (#49140) 2020-02-03 12:23:46 -05:00
Emmett Gaines ab3a127295 Makes the global materials lookup lazily initialized 2020-02-03 10:17:13 -05:00
MrPerson 12eecfd181 Makes raw HTML and browser datum popups UTF-8 aware (#49066)
* Makes raw HTML and browser datum popups UTF-8 aware

Admin menus specifically really shouldn't break just because you named some guy "☺s the Clown"

* Fixed new_player.dm

* Fucking filing cabinets
2020-02-01 22:14:31 +01:00
vuonojenmustaturska 40657c9ccd removes a bunch of unused/bad helpers (#48969)
* a commit

* Update code/controllers/subsystem/persistence.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* Update code/__HELPERS/text.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* Update advance.dm

* Update security_officer.dm

* Update text.dm

* Update unsorted.dm

Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
2020-01-28 16:22:20 +01:00
Fikou 27834b9f74 sec and med erts are now holy 2020-01-26 13:36:11 +01:00
MrPerson 26093e5ac2 Further update_icon splitup (#48784)
* Further update_icon splitup

After this there'll be just under 100 old update_icon() calls that need fixing.

* Thanks Travis
2020-01-22 10:18:05 -05:00
Fikou e86c0febf6 Highlanders can no longer be dismembered (#48761)
all of their gameplay is centered around a single claymore that can 
just be cutoff with a single hit from another guy's claymore, when 
normally as a highlander to kill you need like 3 hits, now you just 
need 1 to dismember and win
2020-01-18 22:47:16 -08:00
MrPerson f7eb2c905b Unicode awareness Part 2 -- copytext() (#48512)
* Unicode support Part 2 -- copytext()

This is the transition of all copytext() calls to be unicode aware and also some nearby calls in the same functions. Most things are just replacing copytext() with copytext_char() as a terrible character limiter but a few others were slightly more involved.

I replaced a ton of
````
var/something = sanitize(input())
something = copytext(something, 1, MAX_MESSAGE_LEN)
````

with a single stripped_input() call. stripped_input() already calls html_encode(), trim(), and some other sanitization so there shouldn't be any major issues there.

This is still VERY rough btw; DNA is a mess, the status displays are complete ass, there's a copytext() in code\datums\shuttles.dm that I'm not sure what to do with, and I didn't touch anything in the tools folder. I haven't tested this much at all yet, I only got it to compile earlier this morning. There's also likely to be weird bugs until I get around to fixing length(), findtext(), and the rest of the string procs.

* Makes the code functional

* Assume color hex strings are always # followed by ascii.
Properly encodes and decodes the stuff in mob_helpers.dm which fixes some issues there.

* Removes ninjaspeak since it's unused
2020-01-18 13:07:22 +13:00
AnturK bca492823a Runtime fixes: Episode 113 (#48814)
* Fixes mood nanite settings

* Fixes yet another quirk runtime.

* Ugly paperplane fix

* Abductor armor runtime.

* cablecutting runtime

* Nukeop death runtime (were those spec deaths meant to fire on gibbing too ? )

* headpike runtime fix

* ERT outfit runtime

* bonfire oxygen runtime

* Rest of nanite updates
2020-01-16 11:16:37 -05:00
81Denton d8068d5d06 hey, if you type in your pw, it will show as stars (#48797)
* *********

* *******************

* genius

* replaces if/else with var
2020-01-15 20:52:34 -05:00
Rohesie 675a358b1b Moves mob stat var changes to a proc (#48760)
* set_stat

* Adds a signal.

* Signal comes before
2020-01-15 16:43:10 -05:00
Buggy123 5efd5df30d Added cult major loss if Narsie is destroyed. (#48251)
* Added cult major loss if Narsie is destroyed.

* Minor corrections.

* Why did this compile?

* Minor fixes.

* Not bool

* Changed to defines as requested
2020-01-14 18:22:49 -05:00
Emmett Gaines 37a83ed511 Fixes hierophant barrier and blob structures allowing things through (#48746) 2020-01-13 17:59:30 -05:00
Fikou 8eee742734 [Ready] Adds ERP (#48699)
Adds a new emergency response team, the ERP! It stands for Emergency Response Party

the ERP includes:
-the coordinator: basically the captain of the operation, armed with a birthday cake, balloon and lots of fireworks to start the celebration
-the bouncer: the big boy, has a telebaton and an armor vest (if youre a loser you get a police hat too)
-the constructor: has tools, materials to build the party, disco tiles and an ethereal disco ball planter
-the cleaning service: your normal jannie, with his trusty mop, trash bag and cleaning grenades
-the comedian: a clown, armed with instruments, a bananium shield and chameleon suit/hat, for some comedy at the party
2020-01-12 13:31:13 +13:00
LemonInTheDark f4f8a686df Makes grounding rods consistent, changes the supermatters bolts a great deal. (#48472)
* Goof I will find you and I will berate you

holy hell

Calm and peaceful ahhhhh

I swear goofs pc failing was the biggest tragedy in gaming

Fixes some flags

More touchups

Now to squash

Goofs PC failing was the biggest tragady in GAMING

* Fixing some misspellings before the bee gets me

* GOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF

* Full vehicle support

* Changes some flags around, "fixes" some bugs, makes being shocked less insane

* Makes spliting more reasonable, unfucks some shitty tesla code I copypasta'd into the sm, godspeed shitcode,
none noticed you.

* Removes my tesla_ignore_1 fix, another pr is up that should solve things, so we're just leaving it in for now,
gonna have to deal with merge conflicts when it gets merged, but that won't be too bad

* tfw

* Nothing to see here folks

* I'm a boomer
2020-01-10 23:25:11 +11:00
Jordie 3ef6beb0d9 Merge pull request #48637 from Ghommie/Ghommie-tg14
Fixes traitor codewords highlight and some other hear signal hooks.
2020-01-10 22:26:18 +11:00
Arkatos1 7b543d2cf9 Valentine status effect fix (#48615)
* Automatic TGUI Rebuild [ci skip]

* Valentine fix

* Revert "Automatic TGUI Rebuild [ci skip]"

This reverts commit 0a92762a259c447b1486cef3a8a6d493dea2039b.

* Review fixes
2020-01-10 22:18:26 +11:00
Emmett Gaines 53024590de Can pass refactor (#48659)
* Makes all CanPass procs call parent

* Makes CanPass more extendable and gives the mover a say in the matter

* Replace CanPass with CanAllowThrough to use the new system

Regex replace `(?<!proc)/CanPass\(` => `/CanAllowThrough(`

* Simple optimization pass
2020-01-08 21:31:49 +01:00
skoglol c471f51dff Merge pull request #48647 from ShizCalev/tesla-shock-refund-fix
Fixes tesla immunity being lost if you have reactive armor and refund the lighting bolt spell / vice versa
2020-01-08 11:17:00 +01:00