Commit Graph

28051 Commits

Author SHA1 Message Date
magey3 ce5dbfb83e Fixes mixing beer with other drinks breaking the sprite (#44145)
About The Pull Request

fixes: #43070
All credit for this should go to @ExcessiveUseOfCobblestone as he made a comment on the issue that fixed it perfectly. All I did was implement it since it wasn't in the code yet and the bug was still there.
Why It's Good For The Game

Bug fixes are always good.
Changelog

cl Fire Chance
fix: Fixed the drink sprites overlapping when you are mixing beer with other drinks.
/cl
2019-05-27 22:57:04 +12:00
AnturK 0b2a97aa72 Fixes magic missile (#44147)
Fixes #44138

My bad, the var was misnamed and i didn't check.
2019-05-27 22:56:29 +12:00
oranges a7077dbcaa Merge pull request #44113 from 4dplanner/timestop
Fixes timestop interaction with antimagic
2019-05-27 22:54:19 +12:00
Tlaltecuhtli 1625ecdef4 fixes message spam from ridden vehicles (#44116)
* fixes message spam from ridden vehicles

* e
2019-05-27 22:53:11 +12:00
nemvar b35711737c Printing mops. (#44141)
About The Pull Request

Makes mops printable.
Why It's Bad For The Game

Excuse me, you can't just print out more mops. A mere autolathe could not even begin to understand the advanced science underpinning the mopping marvel you see before you. These super mops utilize GPS positioning to accurately and intelligently wipe away stains with surgical precision. They also incorporate the latest in synergistic machine learning to identify messes from stains to save you time and money. The smart hydration technology found in these sublime mopping units conserves water, minimizing time wasted on wringing, yet at the same time holds huge volumes of water. The ergonomically designed handle doubles as a self-defense tool, because it's a dangerous station out there and Nanotrasen has your back. Even the top of the mop was painstakingly crafted to be compatible with janicarts. Do you have any idea how difficult that was? People have lost there lives in pursuit of better mopping and yet you seem blissfully unaware of the sacrifices required. Frankly you should be thankful to even get these miracles of modern science at all, and now you want a lowly autolathe to print out more of them by claiming they are "just mops"? How dare you. I demand you apologize. Not to me, not to Nanotrasen, not even to the engineers and scientists who spent countless thankless hours developing the latest in mopping technology. No, you must apologize to the mop itself. Once you admit that this mop is a crowning achievement of humanity, truly the pinnacle of all that we are and ever will be, then you will be forgiven and allowed to gaze upon this mop, much less hold or even use one ever again. Repent, sinner.
Changelog

cl
add: Mops can now be printed at the autolathe and protolathe.
/cl
2019-05-27 22:50:59 +12:00
Garen Crownguard c69a359f20 ling fixes (#44055)
About The Pull Request

Fixes #37273
Fixes #37507
Changelog

cl Garen7
tweak: Lesser form lings can now toggle augmented vision
fix: You can no longer turn back into human form as a lesser form ling while ventcrawling
fix: Stuns and Reagents are now passed when transforming into a monkey or human
/cl

It didn't seem like augmented vision was meant to only be usable as a human so I made it usable as a monkey, if the original creator wanted it to be only usable as a human they would have assigned the var req_human of the augmented vision ability to TRUE since thats where this behavior is usually handled.
2019-05-27 22:36:08 +12:00
AnturK 11441e5dae Makes supermatter melt walls if it finds itself in one (#44068)
* Makes supermatter keep producing gases in walls.

* While i'm at it, fixes sm radio runtime

* Oh right this was split.

* Alright switching it to melting through.
2019-05-27 22:33:55 +12:00
moo c55dbf97f4 Vending Machine Input Framework & Clothing Vendor Inputs (#43964)
About The Pull Request

I didn't like how the wardrobe replaced lockers but you couldn't clean up after yourself say once you switched to the nurse's outfit as a doctor. Now, anyone can put clothes in a wardrobe so long as that clothing is a vendable product of said wardrobe (No engineering jumpsuits in science vendor, etc.).

Building off the previous snack machine vendor, this lays the framework for ALL vendors to allow all sorts of items to be inputted into vendors, all you have to do is change canLoadItem(obj/item/I,mob/user) to TRUE for the items you want the vendor to accept! It also has an option to restrict loading by changing canload_access_list. NOTE: having any of the access permits input instead of all access is needed to input (important distinction!)

ECONOMY: This will make it so any clothes you put in becomes a sellable product. It does NOT make it free unless you can already access the vendor's contents for free.

Code improvement + minor QoL with minute balance implications. If you want to discuss how making it easier to clean up your unused clothes makes it more difficult for antags to sneak then I'm in trouble lol.
Why It's Good For The Game
Changelog

cl ExcessiveUseOfVending
tweak: Wardrobe Vendors will now accept clothing types they sell. Now you can clean up after getting that cool alternate uniform!
code: see PR #43964 on how to easily setup a vending machine to accept items!
/cl
2019-05-27 22:24:58 +12:00
JJRcop bab214e892 PDA Message Server can be constructed (#43961)
About The Pull Request

I made a machine board for the PDA message server and added it to the telecomms techweb node. To keep the usefulness of the machine's password, a player built message server won't work until 15 minutes after construction. I've also converted a lot of magic numbers to defines, and changed the departmentType var on request consoles into a bitflag.

I'm open to ideas other than a time gate when it comes to keeping the server password's usefulness.
Why It's Good For The Game

You can't build a Message Server right now. If it's destroyed, PDAs may be knocked out for the rest of the round.
Changelog

cl JJRcop
add: You can now build a new PDA messaging server if you lose it.
tweak: Requests console messages no longer work if the messaging server is offline. Emergency alerts will still function in that case as long as the rest of telecomms is online.

/cl
2019-05-27 22:23:59 +12:00
Rob Bailey 7c69e1232d [READY] Better shuttle sound algorithm (#43884)
About The Pull Request

Shuttle sounds previously played PER DOOR AT MAX VOLUME
This fixes that problem by instead playing shuttle sounds from the nearest engine or door if there's no engines.
Also there's distance sounds.
Why It's Good For The Game

it's not because it's actually SOUL for the shuttle sound to horribly ear rape you when it has enough doors.
Changelog

cl
fix: Shuttle sounds should no longer ass blast your ears as they no longer play PER DOOR and instead from the nearest engine, or door if none are available.
soundadd: Distant shuttle sounds.
/cl
2019-05-27 22:22:39 +12:00
XDTM 5020a59565 Adds a communication remote that can send custom messages to some nanite programs (#43673)
About The Pull Request

Adds a new device, the nanite communication remote, which can be built from any protolathe once Basic Nanite Research is completed.
The Skull Echo, Forced Speech, and Hallucination programs can now be signaled by this new device to receive custom messages, instead of having to set them manually every time.
To do so, these programs must be set with a Comm Code, which will have to be signaled by a comm remote with the same Comm Code. A Comm Code of 0 is not signalable by remotes and will only work in the old way. If instead you want the program to be only activatable by remote, you must set the trigger code to 0.
Why It's Good For The Game

Makes these programs more elastic in use, allowing for example nanite-delivered private communication via Skull Echo, or actively messing up conversations with forced speech.
Changelog

clXDTM
add: Added a new device, the nanite communication remote, which can be used to send custom messages to message-based nanite programs.
add: Comm remotes use separate Comm Codes: for a message to be received, the signal's comm code must be the same as the program's.
/cl
2019-05-27 22:21:49 +12:00
oranges c33aec037f Merge pull request #44130 from Akrilla/traitor-codewords-highlight
Syndicate codewords are highlighted to traitors
2019-05-27 22:16:55 +12:00
tralezab 2049a24789 Fix phrasing of roundend obsessed (#44136)
After I changed the antagonist to be obsessed instead of a creep, the
roundend didn't work anymore. This has been bugging me for awhile.
2019-05-26 23:24:38 -07:00
Akrilla d612ea120e New classes, <span>, and inline var
Fixup
2019-05-26 08:50:37 +01:00
tralezab 57a513c3bb [READY] Adds the Gravitokinetic stand type (#43846)
This adds the gravitokinetic stand. It's attacks are weaker but they apply heavy gravity.
They can also alt click the ground to apply heavy gravity to that tile, the gravity applied from floor punches is heavy enough to damage people over time.

Recalling drops all of the affected tiles, and they have a range as well.
2019-05-25 19:17:55 -04:00
nemvar 0005bcbbd4 You can now recolo(u)r lightbulbs (#44122)
* COLOR = COLOUR

* Update lighting.dm
2019-05-25 09:53:31 -04:00
Akrilla 05c4f51f53 Merges code into above proc 2019-05-25 09:20:44 +01:00
Akrilla d87fdaaefa Highlight codewords
Phrases in blue, responses in red.
2019-05-24 22:34:46 +01:00
Akrilla 1262f1d4fc Traitor greet text changes
New line, mentioning recognizing words. Phrases are now generated in a list, rather than just a joined string.
2019-05-24 22:34:09 +01:00
4dplanner 6cccabef30 Different defines (#44029) 2019-05-24 11:56:04 -04:00
subject217 4cbcfd6b28 Removes MIRROR_MAGIC changesource flag from zombies (#44105)
YEET!
2019-05-24 09:33:02 -04:00
vuonojenmustaturska e06dbbdd99 a thing (#44077) 2019-05-24 12:31:27 +02:00
bgobandit 2d676dde4f Traitor Panel now shows the names of blood brothers' brothers. (#44040)
* TP now shows the names of blood brothers' brothers.

* cut one line
2019-05-24 07:21:38 +02:00
Rob Bailey 8958287246 [s] Prevents a certain kind of antag-rolling abuse. (#44056)
About The Pull Request

Currently there's a very easy way of making it so that if you don't roll antag, you aren't playing the game and can just go observe and hope for ghostroles.
Have every job set to never, have return back to lobby if preference unavailable set, and antags enabled.
if you roll antag, you get a job or the antag, if you don't, back to lobby.
If you think this is a good idea and go do this, know it's against the rules and if you get caught you'll be banned.

What this PR does is validate that you have at least one job enabled before ever even adding you to the pool of potential players, if you have "return to lobby" set. If this happens, you'll get a notification and an admin will be notified if you also had antags on.
Either of the other "my pref was unavailable options" you can have all jobs set to never just like before and you'll get your random role.
Why It's Good For The Game

Prevents some abuse that can easily be closed on the game code end.
2019-05-24 13:57:37 +12:00
Farquaar e9478431ad [Ready] Fixes the monk's frock glitch when hood is pulled up (#43928) (#43940)
* Removed HIDEJUMPSUIT tag from monk's frock

* Added item_state for monk hood
2019-05-23 18:01:28 -04:00
4dplanner 86789abde6 Deja Vu (#43870)
* First draft of bodypart rewind

* Further changes

* Fixes some simple animal problems

* Sepia regen cores change

* Rewind camera rewinds twice

* Changes to carbon procs
2019-05-23 16:29:15 -04:00
Putnam3145 de64c3cb8f Let service techfab make power cells (#44048)
* Let service techfab make power cells

* Made basic power cells be in all techfabs instead
2019-05-23 16:27:11 -04:00
4dplanner e70b26fd66 Fixes timestop interaction with antimagic 2019-05-23 20:22:36 +01:00
OnlineGirlfriend 85cb421806 [READY] Adds lemonade and lemonade sprite, adjusts Arnold Palmer recipe. (#44085)
* Adds lemonade and lemonade sprite, adjusts Arnold Palmer recipe.

* Tweaked lemonade recipe, new lemonade sprite, changed lemonade taste description
2019-05-23 09:20:58 -04:00
4dplanner 0a22411c23 Colossus chest ignores colossus bolts (#44050)
* Colossus chest ignores colossus bolts

* Changes to pierce
2019-05-23 12:29:50 +02:00
4dplanner 559a8d65da Fixes between the sheets (#44053) 2019-05-22 10:07:42 -04:00
vuonojenmustaturska cdad5e93a0 Removes some unnecessary wrapper procs (#44061)
* unwrap some things

* actually let's not #define this either
2019-05-22 14:41:11 +02:00
wesoda25 6057c768af Crab Protocol Now has Limited Stock (#44063)
* aaaaa
2019-05-22 14:34:03 +02:00
TheSilverNuke e2ed05d818 edagger suicide (#44064)
* edagger suicide

First change, worked on it with another guy as a way to familiarize myself with git and dm.

* Update pen.dm
2019-05-22 08:50:06 +02:00
Emmett Gaines 66cab55f28 Replaces the rpg loot datum with a component and makes some suffixes have real effects (#44044)
* Replaces the rpg loot datum with a component

* Makes bane accept species types

And cleans up some other code
2019-05-22 08:47:42 +02:00
RaveRadbury 9ab2ad72ca Reworks "Religiously Comforted" mood_event (#43995)
* Initial poking around

* adds a message to let you know the examine proc'ed

* converts time to minutes

* removes old on_process() code

* Nests procs under if(!appears_dead)

* nests blocks under src != user
2019-05-21 18:53:13 -04:00
vuonojenmustaturska e123400d00 Removes the mutation on_move hook (#44060)
Why It's Good For The Game

This

for(var/datum/mutation/human/HM in dna.mutations)
	HM.on_move(NewLoc)

pattern is just awful, especially when only one mutation out of all of them implements it.
Changelog

cl Naksu
code: removed /datum/mutation/human/proc/on_move in favor of having the chameleon mutation register for a signal
/cl
2019-05-22 10:49:28 +12:00
vuonojenmustaturska 300e663f32 Nukies get two kinds of shared team discounts rather than individual discounts (#44027 )
About The Pull Request

This replaces the 3 individual discounts on each nukie uplink with two shared pools of discounts. There are 5 unlimited stock discounts and 10 limited stock discounts. Amounts subject to change and debate.
Why It's Good For The Game
Changelog

cl Naksu
balance: nukeop uplinks now have 5 unlimited discounts and 10 limited discounts shared between the team, rather than 3 individual discounts like traitor uplinks
/cl
2019-05-22 10:48:32 +12:00
vuonojenmustaturska fcaf3a62e6 New advances in trash-disposaling efficiency: a janitorial blob strain (#43958)
About The Pull Request

This PR adds a new blob strain into the game that mainly eats garbage and spits it out when attacking. I have some ideas on how to expand on this but I don't know how strong the current mechanic is, so I'm opening the PR up for comments.
Why It's Good For The Game

More blob strains = More better
Changelog

cl Naksu
add: Added a new blob strain that grows inside the station and eats garbage
/cl
2019-05-22 10:43:34 +12:00
skoglol 5316926510 Fixes some missing adjancency checks. (#44020) 2019-05-21 11:43:35 +02:00
oranges 5006e17188 Merge pull request #44028 from vuonojenmustaturska/braindamaged-corpses
Stops corpses from receiving new information about their damaged brain
2019-05-20 16:00:22 +12:00
nemvar a37923ceb8 Makes podcloning transfer quirks. (#44001)
* Lolwut

* Update other_reagents.dm
2019-05-19 13:04:20 -04:00
Jordan Brown b6c41e3b32 Merge pull request #43991 from vuonojenmustaturska/vorecode
Removes vorecode
2019-05-19 12:24:56 -04:00
MrFluffster abdb26cb10 Adds foodtype CLOTH, gives it to dummy item for clothing eating and makes moths like CLOTH (#43965) 2019-05-19 17:58:56 +02:00
vuonojenmustaturska 7bb73bcfb8 Fixes a bunch of harddels and weirdness. (#44012)
* grabbag of random things

* followup

* deleet
2019-05-19 17:52:59 +02:00
Jordan Brown db25902248 Merge pull request #44016 from vuonojenmustaturska/cryoicon
Updates cryo tube appearance when a mob exits via teleportation
2019-05-19 11:26:25 -04:00
Jordan Brown e192f0f6a3 Merge pull request #44025 from vuonojenmustaturska/reinforcements
0 TC uplinks and real names for reinforcements
2019-05-19 11:17:28 -04:00
oranges 6d60467933 Merge pull request #44011 from ExcessiveUseOfCobblestone/starsnstripes
[S] The Pen is Mighter Than The Server No Longer
2019-05-19 22:31:28 +12:00
RaveRadbury ade1a97e7c [READY] pAI HUD Overhaul (#43741)
* Initial overhaul work and some fixes.

Running into a bug with getting healthanalyzer variables to pass.

Signed-off-by: RaveRadbury <risforradbury@gmail.com>

* Fixes some typos, shortens a message

* Update pai.dm

* Prevents pAI OS from coming up in other windows.

* Moved around some camera stuff, trying to fix lost pAI zoom

* Fixes pAI zoom, adds camera flash

* PAI buttons grey out if they need software first

* Better greying out of buttons in PAI

* Removes unimplemented HUD stuff

* Should make pAI Host Scan require being held (like DNA check)

* Includes host scan as a greyed out hud

* Improved button loop

* Fixes pda icon off-set

* Fixed inconsistent indentation

* Replaces outdated and innacurate checks for scans

Thanks to Cobblestone for the help

* Refactor pAI hud button grey out

* Changes browse to browser

* cleans up the code, gets rid of an error

* Removes indent from #undef

* Removes an unneeded text-align:right
2019-05-18 23:06:29 +02:00
vuonojenmustaturska 43548d4015 Fixes wabbajack altar becoming too inert (#44002) 2019-05-18 15:29:15 -04:00