The "set internals" button of tank items now turn green when it's used as internals.
Removed research scanner from drones (since cyborgs don't have it, it's more consistent)
Removed the ignore_madkadjust mask var.
The sechailer mask now has an adjust mask action button, so I removed the adjust verb that it was using.
The item's action are now created on item/New() instead of trying to create it every time someone picks the item up.
I split hud/action.dm, the datum/action stuff is now in the datum folder (/datum/action.dm), whereas the code for action buttons is kept in the hud folder under action_button.dm. Also I moved some /datum/action code that was in some files back into datum/action.dm where it belongs.
Fixes not seeing glasses through the riot helmet.
Fixes gas mask protruding from the abductor helmet.
Fixed radiation hood not hiding your hair, earpiece, mask.
Fixes colored justice hats not having an on-mob icon_stat.
Removed BLOCKHAIR bit from var/flags , moved it to flags_inv and renamed to HIDEHAIR
Added HIDEFACIALHAIR bitflag so certain hat/helmet can show just the beard.
Fixed human/update_inv_glasses not checking if our mask hides our glasses.
Fixed check_obscured_slots() not checking if our masj obscur our glasses.
Fixes some bits of flags_inv having the same value.
Fixes crusader hood and other headgear not hiding your identity when they should.
Fixes drone mask icon not appearing.
Fixes Toggle Helmet light verb on security helmet with seclite attached being usable while dead.
Fixes Lizard snout is poking through helmet
Fixes Space helmets not hiding masks and glasses (especially the large gar glasses)
Eva harsuit helmet no longer has a semi transparent part (incompatible with hiding masks and glasses, and causes lizard snout protruding from that helmet)
Made equip_to_slot() and unEquip proc more OOP at the carbon level which removes some duplicate code between monkey and human.
Readding code\modules\mob\living\carbon\brain\login.dm that someone (probably me) unchecked some time ago by mistake.
At some point someone changed the armor system to always block, which I
understand, because RNG is annoying, but they didn't lower the armor
values to compensate.
Right now a basic security officer blocks 50% of all melee damage. It
would take 7 hits from an esword/punches from a Juggernaut to reliably
down an officer, and just a single stun baton to down a guy with an
esword.
It takes 20 hits from an inactive baton to crit a basic officer, 8 hits
from an arblade, etc.
In short, melee is completely awful as soon as someone throws on a basic
vest. It makes melee weapons impossible to balance because even if
they're strong enough to crit a random med doctor in 4 hits they're limp
noodles vs a helmet. We can't move away from "I stun you lose" combat if
stun weapons are 8-20 times as effective as anything else.
I lowered the values around half for melee and tweaked laser resist a
bit as well (again, it shouldn't take 10 lasers to down someone vs their
one taser). I'm not overly attached to these values, nor are they
particularly deeply thought about, I just wanted to get a conversation
on git started where everyone would see it.
-Pressing this button will spawn up to 5 death commandos on centcom with a customizable objective
-Added a shuttle console to the ferry that, rather than moving the shuttle, will send a request to admins instead
-Deathsquaddies get an energy shield
-Deathsquad beret will no longer hide head, face, and hair
*TABLEPASS was already totally obsolete.
FPRINT was used, but it was on virtually everything anyway.
Removes those flags from every instance where they were used. Also assigned and removed other flags where it made sense.
If it is desired, I can revive the flag as NOFPRINT, which would retain the original functionality, though inverted. That way it would be be used only where it was intentional (holodeck items could use this for example).
phil235
KorPhaeron
Lularian
Fox-McCloud
bgobandit
Razharas
CosmicScientist
CosmicScientist
Steelpoint
Cheridan
xxalpha
Fayrik
MMMiracles
paprka
tkdrg
GunHog
Xhuis
hornygranny
Lo6a4evskiy
ikarrus
paprka
Miauw
Cheridan