Commit Graph

14 Commits

Author SHA1 Message Date
MrPerson ff3f84ab81 Replaces /image with /mutable_appearance, where appropriate (#26518)
In cases where you're creating an image to use as an overlay, it makes more sense to use a mutable_appearance if you can. The image will create a static appearance for not just the image but also each intermediate step if you change vars along the way. The mutable appearance avoids this unnecessary and expensive process. The only situation that requires an image instead of a mutable_appearance is if the overlay is supposed to be directional. MA's ignore direction while images don't. I dunno why, probably another BYOND-ism.

I added a convenience function, mutable_appearance(), designed to emulate image(). Also went ahead and set the default plane of /mutable_appearance to FLOAT_PLANE because it's fucking 0 by default.

Several overlays that were image() calls were changed to just text strings when I could. overlays += "string" has the same result as overlays += image(icon, "string") and saves a proc call.
2017-04-25 12:15:16 +02:00
Jack Edge a76d4374c1 Moves init_order to defines, moves SSevents above ticker. 2017-04-22 22:08:31 +01:00
Cyberboss 78ee754da3 Merge upstream 2017-04-01 23:38:37 -04:00
Remie Richards d1b2be75ad Fixes #24998 (Statues spawned by wizards are invisible) - Correctly (#25638)
* Fixes #24998 Correctly

* Fixes potential addition to non initialised overlays list
2017-03-31 09:33:44 -03:00
Cyberboss fb596bcdb3 _DEF 2017-03-22 14:52:21 -04:00
Cyberboss 7e14ec75fc Normalizes subsystem definitions 2017-03-22 11:50:46 -04:00
MrPerson b71e89ce10 Fixes non-dynamically lit areas being pitch black
Fixes #25179 (Legitimate closing of a pull request, thanks for this bug github)
Fixes #25164
2017-03-16 21:30:06 -07:00
Cyberboss ea740fd160 Fixes problems with icon overlays (#24530)
* Fixes problems with icon overlays

* Rename this to prevent confusion

* Well somehow that fixed it
2017-03-14 19:28:05 +01:00
Cyberboss 31ee152489 Repaths subsystem to controller/subsystem (#24624)
* Repaths subsystem to controller/subsystem

* Fix the shit
2017-03-08 22:05:45 +01:00
Cyberboss e03144dc1d Smoother roundstart take II (#24504)
* Revert "Until I figure out why random keys aren't being transferred"

* Fixes cyborgs not getting their key at roundstart

* Fixes mimes not getting the prefs name

* Fixes clowns not getting prefs names

* Sets the round start timer when it actually starts

* Remove fluff CHECK_TICKs

* Moves siliconization to the jobs module

* Yeah whatever

* Fixes AIization

* HNNNNGHHHH WHY IS THIS UP HERE?

* Fix cyborgs not linking to AI
2017-03-07 21:06:33 +01:00
Cyberboss 4aefd57cca Revert "Overlay/Roundstart fixpack (#24356)"
This reverts commit bf42d769e2.
2017-02-22 20:43:08 -05:00
Cyberboss bf42d769e2 Overlay/Roundstart fixpack (#24356)
* Fixes roundstart graphical lag

* Fixes manifests

* >Expecting searching lists to be fast

* Here's where they needed flushing

* THE DATACORE IS ANNOYING REEE

* <Commit name>
2017-02-23 09:41:58 +13:00
Cyberboss 85b8485313 NobodyReviewsNobodyReviewsNobodyReviews (#24360)
NobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviewsNobodyReviews
2017-02-22 20:18:15 +01:00
Cyberboss 56a6eaa8e6 Overlay queuing (#23922)
* Overlay queuing

* Fix SS flags

* Don't copy on assignment

* Flags processing

* Fix icon_smoothing

* MSO's helper proc

* Legacy detection

* Make it work

* Fixes shitcode

* Fix the flag

* |= -> +=

* OK, how did I fuck that up?

* shitcode

* Conditional assoc queue while initializing

* Cleanup everything

* Orange meme

* This isn't perfect, but its the best byond will give us.

* forgot about dir

* oh ya

* This was litterally the last thing i did last night before heading to bed

You can tell can't you?

* Fixes various shit

* Let's not ever pause

* Fix the flag

* Cleaned up some missing shit. Added image dummys

* Remove the one usage of FPRINT

* Jesus get rid of this
2017-02-22 21:44:55 +13:00