Commit Graph

52935 Commits

Author SHA1 Message Date
IndieanaJones de31a2b625 Fixes Swarmer Barriers (#53049) 2020-08-19 21:16:00 -03:00
NightRed 8c78aa58f5 Prevent duplicate names for vents and scrubbers in the air alarm (#52398)
It is always a pain adding in a new vent or scrubber to an area and suddenly you have duplicate names.
This prevents duplicate names for vents and scrubbers in an area.
Why It's Good For The Game

Makes engineering's life better, duplicate names are bad.
Changelog

cl
fix: Prevent duplicate vent and scrubber names in the air alarm interface.
/cl
2020-08-20 09:16:14 +12:00
Jared-Fogle 45c14f6330 Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking (#52761)
Adds SIGNAL_HANDLER, a macro that sets SHOULD_NOT_SLEEP(TRUE). This should ideally be required on all new signal callbacks.

Adds BLOCKING_SIGNAL_HANDLER, a macro that does nothing except symbolize "this is an older signal that didn't necessitate a code rewrite". It should not be allowed for new work.

This comes from discussion around #52735, which yields by calling input, and (though it sets the return type beforehand) will not properly return the flag to prevent attack from slapping.

To fix 60% of the yielding cases, WrapAdminProcCall no longer waits for another admin's proc call to finish. I'm not an admin, so I don't know how many behinds this has saved, but if this is problematic for admins I can just make it so that it lets you do it anyway. I'm not sure what the point of this babysitting was anyway.

Requested by @optimumtact.
Changelog

cl
admin: Calling a proc while another admin is calling one will no longer wait for the first to finish. You will simply just have to call it again.
/cl
2020-08-20 09:11:28 +12:00
skoglol d4d754a107 Adds nekomimetic, the felinid language (#52958)
Currently felinids are the only roundstart species without a language, this sees to that.
Changelog

cl Skoglol
add: Adds nekomimetic.
/cl
2020-08-20 09:09:53 +12:00
tralezab 6a25b30b12 Removes "availible" mispellings in codebase (#53046)
* AVAILABLE

* Rebuild tgui

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-08-19 23:57:37 +03:00
silicons 452d2ad6e7 [s] sanitizes nanite extra settings (#53065)
/datum/nanite_extra_setting/text/get_value()
return html_encode(value)

HTML injection bad. Brainwashing and potentially happiness programs are all subject to this, unless code has changed for how objective text is rendered. I don't think there's any case where nanites even need to be able to accept raw html.
2020-08-20 07:57:42 +12:00
Wallemations db3fe53cf8 Baseball bats have a 1% chance to be deformed on creation (#53051) 2020-08-19 16:15:04 -03:00
tralezab 3c5c2a1ebc Small Plasmamen envirosuit spelling fixes (#53045) 2020-08-19 16:12:18 -03:00
Ziiro 7d852a961f Allows xenos to use ladders properly (#53044) 2020-08-19 16:11:44 -03:00
ArcaneDefence 22736e14e2 Monkey powder now respects the monkey cap config (#53024) 2020-08-19 16:06:03 -03:00
uomo afb9a1d9aa Removes double space from health doll examining. (#53025) 2020-08-19 16:05:12 -03:00
tralezab 392258947e species now correctly do not include organs they do not use (#53030) 2020-08-19 16:02:38 -03:00
uomo 180ef034ba A bunch of tweaks to holsters. (#53031)
Regular holsters:

Can no longer hold pulse carbines.
Can now hold toy pistols.
Detective's holster:

Can no longer carry ALL ammo box types, it's crazy this was possible.
Can now carry all handguns instead of only revolvers, their ammo, the mini e-gun, and the toy pistol and its magazines.
Chameleon holster:

Can no longer hold pulse carbines.
Can now hold all the ammo of guns it can hold (handguns and revolvers), the toy pistol and its magazine, and the small energy crossbow.
Operative holster:

Can now hold... basically everything gun related. All guns, all ammo (except ammo boxes), all grenades.

Descriptions of all holsters changed to reflect this.
2020-08-19 15:58:40 -03:00
pali 7db5cdabb7 Fixed type2parent behaving incorrectly for /mob and /turf (#53035) 2020-08-19 15:57:24 -03:00
GuillaumePrata 83a921f67b Adds Hypernoblium interactions with Plasmamans to stop self combustion. (#52942)
Plasmamen won't interact with O2 if there is also Hypernoblium in the air and if already on fire, will get extinguished.
Adds Hypernoblium as a reagent when inhaled, having Hypernoblium in your system as a Plasmamen will also stop combustion.
2020-08-19 15:40:23 -03:00
ArcaneMusic 10362c6bf9 Bam ath happy (#53039) 2020-08-19 14:25:58 -04:00
Krysonism b8e128f17b New breathtaking medical stack: the mourning poultice! (#52968)
New type of medical stack, obtainable from botany: the mourning poultice.

These poultices convert 10 brute and 10 burn into oxy per application, and can be used on corpses as well as the living.

It takes 20u bungotoxin, 20u aloe juice and 20u cellulose to create one stack.

I have split all the existing medical stacks into their own dmi, stacks_medical.dmi.
2020-08-19 15:25:10 -03:00
NightRed 0497d5a950 Chemistry machines drop beakers on floor if you are not beside them (#52922)
When ejecting a beaker it would teleport to your hand.
This checks that you are in range, if not the beaker drops at the machine.

Fixes #52882
2020-08-19 15:22:45 -03:00
uomo e0520a2e10 Utility belts can now hold airlock and decal painters. (#53027) 2020-08-19 15:21:39 -03:00
ATH1909 829f305b6d bruh moment (#52661) 2020-08-19 10:38:25 -04:00
Aleksej Komarov c59d88470a tgui: Yarn Berry (#53026)
This pull request upgrades Yarn to version 2 (also known as Yarn Berry).
* Update build validator

* Provide inferno in the root level package

* Remove type module from package.json

* Powershell build script
2020-08-19 02:26:30 -03:00
Timberpoes 288bc5234b Reworks the Hierophant Club as a general utility item and removes attacks. (#52880)
This PR reworks the Hierophant Club into a utility item. Mining? Gone. Attacks? Gone.

In their place? 5-tile range point-and-click instant teleport similar to the ninja. Max charge is 1. Recharge time is 15 seconds.

With the removal of this bloat, the item is now small enough to fit in the average backpack.

The hiero club establishes itself as the entry-level megafauna drop from the entry-level megafauna.
2020-08-18 22:42:35 -03:00
NightRed 12f8b03249 Shatter glass by slapping the floor (#52916) 2020-08-18 22:40:07 -03:00
TiviPlus 0ab4f38605 Diagonal macro thingu (#52927) 2020-08-18 22:35:33 -03:00
CRITAWAKETS 2d9506cf43 General nanite nerfs. (#52937)
Nanites have recieved a general nerf, mostly in the healing department. This is probably not enough nerfs, actually.
2020-08-18 22:32:50 -03:00
Rohesie 25f670f8de Opacity refactor (#52881)
Moves all opacity var manipulation to a proc which sends a signal.
    light_blocker element for movable opaque atoms made, which tracks its movement and updates the affected turfs for proper lighting updates.
    has_opaque_atom boolean replaced by the opacity_sources lazylist to keep track of the sources, and a directional_opacity which serves a similar function but also allows for future expansion with on-border opaque objects (not yet implemented).
    Some opacity-related sight procs optimized as a result of this.
    Some variables moved to the object's definition.
    A define or two added into the mix for clarity.
    Some code cleaning, like turning booleans into their defines.
    One file renamed for clarity.

Changelog

cl
balance: Mechs no longer block sight. It's a non-trivial cost for the lighting system with little to no gain.
/cl
2020-08-19 13:24:20 +12:00
ATH1909 0c1d72e333 Adds reminders as to which cult structures make which cult items (#52637)
Said reminders are present in both the descriptions of those cult structures and in the stack recipe menu for runed metal.
2020-08-18 22:22:19 -03:00
tralezab 728d1ca524 cleanup the corpse file, cleanup stationstuck component, adds stationstuck to the reanimated skeleton (and zombie, why not) (#52940)
all living spawners in corpse.dm are now in ghost_role_spawners. I hate having to search two different files to HOPEFULLY find which ghost role I need to edit.

Added a disclaimer about giving guidance or at least stationstuck component to stuff so this doesn't happen again

Cleaned up stationstuck. Man, I know I made this, but damn I did kind of a shit job
2020-08-18 22:20:25 -03:00
Donkie 9ed2bc5dae Cleaning machines and the cleanbot now scrubs instead of washes, wiping forensics (#52983) 2020-08-18 22:17:51 -03:00
Tad Hardesty 291d7ac376 Fix the poll menu from breaking the join menu when the DB is misconfigured (#52949)
The returns if the DB is connected but the query errors mean the new player panel is never shown. This is a problem.
2020-08-18 22:08:27 -03:00
NightRed 7e4c62c4db Floor smoothing group (#52960) 2020-08-18 22:02:43 -03:00
skoglol 1137100999 Adds an admin force wardec button to the antag panel. (#52967)
If nukies have spawned, the war button exists and war has not been declared, the check antag panel now has a button to force war. This bypasses the crew and time limit. Made by admin request.
2020-08-18 22:02:11 -03:00
Jared-Fogle 2c99aca6a4 Fix random chances for slapping animations (#52976)
Slapping animations are supposed to have some form of randomness to add variety to it. However, instead of a 1 in 2 chance, the creator used the wrong proc and accidentally made it a 1 in 50 chance.
2020-08-18 21:56:14 -03:00
WarlockD 6d578a39cc Fixes eye damage overlay (#52980) 2020-08-18 21:55:12 -03:00
WarlockD 5c6da83db9 Update stat panel to give round time days. (#52986) 2020-08-18 21:52:35 -03:00
tralezab 46ec19aa81 New Event: Shuttle Catastrophe (#53003)
The shuttle runs into some kind of horrible event, and is no longer servicable. The station is given a new one!
2020-08-18 21:42:06 -03:00
Timberpoes 3ccd58639c Fix runtime with CANT_WOUND weapons that use pellet_cloud (#53001)
In /datum/component/pellet_cloud/proc/pellet_hit if the projectile's wound_bonus is CANT_WOUND, then wound_info_by_part[hit_part] never gets a value set.

This causes an issue in /datum/component/pellet_cloud/proc/finalize() where it assumes that wound_info_by_part[hit_part] has always been set to a list(x,y,z).

I added a quick if check to skip this where there's no wound info for a part.

Weapon this behaviour manifested on: DRAGnet on net mode. Due to the runtime, I didn't notice it dealing any stamina damage. This should fix that scenario as well as any other CANT_WOUND projectiles and prevent them from runtiming early.
2020-08-18 21:26:29 -03:00
tralezab 662e96e756 Clown's Tears take one bananium sheet instead of one bananium ore (#53004) 2020-08-18 20:57:34 -03:00
zxaber ffbf931e17 Fixes a runtime caused by examining a modular computer with no primary ID slot (#53009) 2020-08-18 20:51:45 -03:00
tralezab 6c79ec5823 Flyperson organs are all completely unidentifiable (#53008)
All flyperson organs have the same, generic name and description, and their icon is picked from a pool of gross, blackened organ sprites.

There's also a new organ they have that just does completely nothing. It is also disguised and looks the same as all the other organs.
2020-08-18 20:50:35 -03:00
Bampotio a334bafee9 Adds floral somatoray to botany belt (#53010)
Makes it so you can store the floral somatoray in the botany belt
2020-08-18 20:39:55 -03:00
Fikou cc9945b8a4 shuttle parts are now in shuttle part smoothing group (#53015) 2020-08-18 20:31:26 -03:00
Qustinnus f54de4a2b8 refactors resist act to be on atom level (#53016) 2020-08-18 20:30:44 -03:00
ATH1909 47d7e373b8 Patches a shuttle curse orb exploit, increases the amount of uses from 2 to 3 (#52635)
* curse you, perry the emergency escape shuttle!

* Update code/modules/antagonists/cult/cult_items.dm

Co-authored-by: Rob Bailey <actioninja@gmail.com>

Co-authored-by: Rob Bailey <actioninja@gmail.com>
2020-08-18 17:50:29 -04:00
MrMelbert 0822aed851 Removes organ accidental consumption (#52411)
* i dedicate this one to goof

* snip

* how'd this get past
2020-08-18 17:38:26 -04:00
nemvar e32c22489f Merge pull request #52895 from MrMelbert/blindmanwalking
Prevents blinded people from using camera consoles perfectly fine
2020-08-18 18:45:13 +02:00
tralezab f1541d82d4 Removes Corporate Species (#53018)
* sike! i removed corporate!

* b'gone sprites
2020-08-18 12:38:03 -04:00
uomo 28699d9716 The holodeck will no longer spawn invisible tables, and WILL spawn floor decals. (#52924)
* Fixes holodeck making invisible tables.

* Removes comment.

* Remove extra space.

* Just gets rid of overlays from forbidden vars list.

* Small map fixes for the lounge sim.
2020-08-18 07:09:20 +02:00
Jared-Fogle fa11c9c7be Messages sent by yourself no longer highlight (#52991) 2020-08-18 05:54:29 +03:00
LemonInTheDark 495d4c2412 fixes helllag from change turf being used on a turf of the same type (#53000)
Prevents horrible lag and runtime spam, makes the ash drake fight doable again, and adds a safeguard in case of other odd turf shit.
Changelog

cl
fix: The ash drake fight is winnable again, and the game will no longer die when he goes into the lava arena attack.
/cl
2020-08-18 10:34:49 +12:00