* Doubtful improvement
* Switches out all the magic numbers with defines
* Thanks travis for finally finding a real error
* properly resolves some left over conflict
About The Pull Request
All mobs in GLOB.player_list have clients attached and there is in fact a fair amount of code that is working fine without checking client on things in player_list. This pr just removes a bunch of checks for client when iterating over player_list.
About The Pull Request
Makes it so pAIs either stutter, slur, or talk like a brainlet when they're EMPed. This can be fixed by someone pressing the "Reset speech synthesis module" button on the pAI card. Additionally, adds a 40% chance for their default language to be swapped.
Readded the mute, albeit a bit shorter, due to feedback.
Idea courtesy of Rogus.
image
Why It's Good For The Game
Mutes are boring. This adds a debuff that while less severe, persists for longer and requires the help of another player to fix.
Changelog
cl
tweak: pAI speech modules have been upgraded to be more EMP resistant, but they can now malfunction on EMP.
/cl
About The Pull Request
gives knight armor and helm more fitting descs and names
fixes earth bolt name
makes knight armor actually show up in autolathe when you put the disk in instead of being in a nonexistent category
Why It's Good For The Game
fuck
Changelog
cl
fix: the knight armor and helmet now are in the imported category instead of some nonexistent one
spellcheck: earth bolt is no longer an earth_bolt
/cl
About The Pull Request
Adds shoe stealing. Grab someone who is prone while targeting a leg to steal their shoes.
Why It's Good For The Game
The single biggest loss of the slip rework was the inability to steal people's shoes that had been slipped. This rectifies that.
Changelog
cl
add: Steal shoes by grabbing someone on the floor while targeting a leg
balance: tweaked a bunch of shoe strip times
/cl
About The Pull Request
This PR finally splits up the ways that borgs are supposed to initiate inventory checks of a mobs and initiate attempts to buckle mobs to themselves (formerly, they would both happen upon click+dragging a mob onto yourself as a borg). Now a borg will only try to buckle a mob to themself if they ARE NOT on harm intent when they finish click+dragging said mob onto themself, and will only try to check a mob's inventory if they ARE on harm intent when they finish click+dragging said mob onto themself. An outsider can still buckle someone (even themself) to a borg who's on harm intent; the borg just can't do it themself.
Why It's Good For The Game
This issue is incredibly annoying to deal with as a borg (especially if you're in an area or situation where *spinning someone off of you could be risky), and I'm really surprised that it's taken this long for this control conflict to be fixed.
Changelog
cl ATHATH
tweak: If a cyborg click+drags someone onto themself, they will only try to buckle that person to themself if they (the cyborg) ARE NOT on harm intent. Attempts made by non-cyborgs to buckle themselves to cyborgs by click+dragging themselves onto said cyborgs should be unaffected by this change, even if those cyborgs are on harm intent.
tweak: If a cyborg click+drags someone onto themself, they will only attempt to check that person's inventory if they (the cyborg) ARE on harm intent.
/cl
About The Pull Request
does what says on title, becomes a securitron that can shoot people
removes ed209 cell because it doesnt do anything why does it even exist
fixes ed209 crafting using dragnets
sadly, removes lasertag mode from ed209, but ive never seen anyone use it and it made everything a lot more confusing
eds now shoot you even if youre lying down because i guess that you could rest before to avoid getting shot but im not 100% sure
Why It's Good For The Game
fixes tons of horrifying copypaste
also fixes some minor things
Changelog
cl
del: Lasertag EDs have been removed
code: EDs are now not a horrifying mess of copypasted securitron code
balance: EDs now still shoot you if you're lying down
tweak: you no longer need a battery to make an ed209
fix: fixes ed209 crafting using dragnets instead of disablers
/cl
* Blindness removes colours so you can only see if an object is near, not the fine points on it.
* Fixed up the monochromatic trait to persist when removing blindness
* Removed added trait and created new colour filter for blindness
* Blankspace Removal
* removed the src before the proc as it was not needed
* Reverts italics-span back to no color.
* Cleans up many extra spaces and indents.
* Adds 'hear' span class.
* Replaces all 'italics' used in heard messages with 'hear'.
* Makes nanites be passed down when jellypeople and slimes split
* Trying to change how nanite splitting works, currently this is broken and disallows splitting of slimes and jellypeople
* Still doesn't work, jellypeople code fails at the L1 check
* Nanites now pass on properly, but sync needs a rework. Get component might be the right way to do it after all
* preparing for revert
* Reverting, I think
* I don't know how revert works, making activation copy over as well
* Removing an unneccesary proccall
* Update medbot.dm
* romance of the three medbots
* no longer requires unique ID
* Revert "no longer requires unique ID"
This reverts commit 3349140f3779f8e694e14d1c2a170ff5d3105a56.
* sometimes i can code ok
* Update medbot.dm
* duh
* Update unsorted.dm
* Update unsorted.dm
* Fuck Git pushing and Fuck Git pulling
PR machine broke, had to resubmit
* Update food_reagents.dm
* Major fixes and error fixes for nemvar
* fixed a missing type path part
* expanded scope of protection while increasing protection needed
* spacing error
* adds new variable, pepperproof to check for immunity to pepperspray
* adds another protection variable EYESPEPPERPROOF
* Revert "adds another protection variable EYESPEPPERPROOF"
This reverts commit b9f3682f7c47a157008d565620f8cdcffece145a.
* fixes and reverts to better and easier time
* small formatting fixes
* null checking
* Update living_defense.dm
Combat defibrillator has halved recharge time. This allows it to both
stun people more quickly, and actually be able to cause a heart attack
with harm intent during the stun.
It also has unique, mediocre sprites by Me. Syndicate duffel bag
sprites altered slightly so the little med/ammo icon is tilted.
I randomly found out combat defibs could actually be used offensively
while testing things, but they were both a tad slow to recharge and had
what was practically an undocumented feature that I've never seen
anyone use. This PR points out that they can be used in combat, and
buffs them appropriately so a nuclear operative could reasonably use
it, at the cost of sacrificing their belt slot and their offhand.
* Selectively randomisable characters
* it's a list now
* this doesn't work
* it's totally fucking fucked mate big time
* it works
* so sick of this goddamn pull request and yes i know this is a retarded way to do this it didn't work the other way
* anturk forestalls the inevitable suicide
'associative lists are more performant'
* final changes anturk requested
'remove all the "in randomise" and it's ready'
About The Pull Request
removes duplicate if statement in a switch that is there for no reason. It already happens on line 95.
Why It's Good For The Game
???
Changelog
cl
code: removed duplicate code
/cl
* Turns digital camo into an element
* Removes commented out code.
* Keep forgetting this
* Update code/datums/elements/digitalcamo.dm
Co-Authored-By: Rob Bailey <actioninja@gmail.com>
* ED209's aggro when you throw things at them and no longer die to shocked grilles
* fixed an extra line
* runtimes in the waiting
* runtimes cant stop the law
About The Pull Request
Converts every single usage of playsound's vary parameter to use the boolean define instead of 1 or 0. I'm tired of people copypasting the incorrect usage.
Also changes a couple of places where a list was picked from instead of using get_sfx internal calls
This was done via regex:
(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\)) to match 1
(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\)) to match 0
full sed commands:
/(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\))/\1TRUE\2/ 1 to TRUE
/(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\))/\1FALSE\2/ 0 to FALSE
I'm not very good with regex and these could probably be optimized, but they worked.
Why It's Good For The Game
Code usability
* You can no longer give the AI laws containing IC filtered words. Adds a proc to accomplish this.
* turns proc into a define, adds it to hacked module because I forgot
About The Pull Request
Splits the previous single dmi used for all under items/uniforms into 17 separate dmis
Why It's Good For The Game
makes icon conflicts when developing much less likely.