Commit Graph

32596 Commits

Author SHA1 Message Date
TiviPlus f64085240d Fix sleep lint and use tabs in hilberthotel.dm (#53586) 2020-09-10 18:21:11 -07:00
Jared-Fogle 04a42f08b0 Add feedback for alt clicking atmos machinery (#53510)
When you alt click atmos machinery, you will usually do something along the lines of maxing out the pressure output on a pressure pump.

This adds a chat message when you do.
2020-09-11 01:43:34 +01:00
ArcaneMusic 224b87e55d Adds native chilly peppers to icebox flora. (#53544)
Now, icebox has a native plant that can be picked on the surface level, where the sunlight reaches highest, and rarely seen underground, and provides you chilly peppers. Traditionally a chili pepper mutation, the theme was close enough that I felt it'd be a good fit for the map, and helps break up the monotony of the map being ice, rock, and more ice with some harvest able flora.
2020-09-11 01:16:07 +01:00
Jared-Fogle 0c8bf36548 Remove references to old singularity machines (#53509)
Removes the singularity generator and the particle accelerator. The former had no sprite, and the latter only existed because of a leftover type path. This does not affect gameplay at all.

Removes the "Start Singularity" verb that was only intended for debug use.

Fixes #53508.
2020-09-11 01:08:43 +01:00
Jared-Fogle 55adfd3804 Fix seeing surgeries while blind (#53500)
Fixes #53295.
2020-09-11 00:28:02 +01:00
AnturK a55d5439e9 Fixes tests on master. Maybe. (#53613) 2020-09-10 19:16:41 +01:00
Emmanuel S 953e337eb3 Pod launcher renaissance squash (#52611)
Refactoring of Flex, Fix Section scrollable

Getting presets working


wip


Upgrade dependencies

preset notice, tooltip fixes, pod spawnlocation fixes


finishes UI, final polish


quells one travismoment


Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>
better var names


better vars


sound for loop


Further review addressing


runtime fixes


Update code/modules/asset_cache/asset_list_items.dm

Co-authored-by: Rohesie <rohesie@gmail.com>
More review addressing


tgui merge


why was that there


Small improvements


Small Improvements Part 2


dropoff / wall moving improvements


compile!


more fixes
2020-09-10 20:22:47 +03:00
ShizCalev 5c318c0a2f Merge pull request #53578 from msgerbs/air-alarm-fix
Fixes air alarm operating modes not working
2020-09-10 13:18:43 -04:00
ATH1909 1007abcec5 fixes a copy+paste error in synthcode (#53573)
handle_body() was called when handle_mutant_bodyparts() should have been called instead. I've fixed this issue.

I've also doc'd the disguise_fail_health variable, because the comment that's currently next to it doesn't accurately describe what the variable actually does.
2020-09-10 13:08:53 -04:00
Dennok ec914d0135 Fix portable_atmospherics runtiming on mapload (#53575) 2020-09-10 13:07:21 -04:00
LemonInTheDark 9e25e97370 Merge pull request #53013 from Ghilker/reactions-go-BRRRR
The scope of this PR is to add new and interesting stuff to the atmos crew and to bring more people to it both old and new.
This PR adds 5 new gases, a bunch of reactions (i'm still working on this but suggestions are useful), new recipes and items to the atmosians arsenal. These gases have high utility for everyone, atmosians will find them useful to do their job both as firefighters and air maintenance.
FINAL GAS NAMES (will change only if a maintainer ask about it)

Healium
Proto Nitrate
Cyrion B
Halon
Hexane

reactions avaiable in this PR: https://drive.google.com/file/d/1e6DZlBaKSCNdCADKnrH3F3aDWvl0iZr4/view

What the PR add:
-Healium: a red gas, stronger than n2o if breathed, with healing properties
-Proto Nitrate: a green inert gas if breathed but with different reactions with various gases at high temperatures
-Cyrion B: a black deadly gas if breathed that decompones very fast if exposed to N2 even at minimal amounts
-Halon: a light blue gas that when used in a fire it will suck up the O2 and will help cool the room, helping fighting the fire
-Hexane: a purple gas that has the ability to filter from the air plasma and n2o, useful to clean distro from the harmful gases quickly
-Healium Crystal: a reddish crystal that when broken will explode cooling the room and removing the plasma from the air (act like a grenade)
-Proto Nitrate Crystal: a greenish crystal that when broken will explode refilling a space with O2 and N2
-Cyrion B Crystal: a blackish crystal that when broken will explode dealing damage around it
-Metallic hydrogen recipe addition (atmosian armor and fireaxe)
-Statue of an elder atmosian (for bragging rights)
-Supermatter Interactions
-More gas interactions (Roinnel have multiple and different interactions)
-New RPD device: the pressure valve, a device that allow gas flow in a pipenet if the input pressure is higher than the set pressure it's getting atomized
-Fusion is a bit "easier" to start (minor changes to the math so that the instability is more reasonable)
-pluox can be also made without using rads
-cyrion-b bounty
-all 5 gases can be sold to cargo

More stuff needs to be added (like the SM interactions(added) and probably more reactions and breathe reactions)
Please leave suggestions and feedbacks as it helps improve the PR

Atmos desperately need more content and need to be proactive in the making of its tools, with this PR is a start to more atmos content

🆑
add: hydrogen + rads = trit
add: 5 new gases
add: Healium : made from Bz + Freon + cold, it knocks people down but have healing properties
add: Proto Nitrate : made from pluox and H2 + heat, it has different reaction with a bunch of other gases
add: Cyrion B : made from hypernoblium + stimulum around 0°C, it has heavy damage if breathed but is decomposed rapidly by N2
add: Halon : made from bz + trit + cold, it reacts with O2 at high temperature removing it and cooling the air, helping putting out fires
add: Hexane : made from bz + H2 + cold, it reacts with plasma and n2o and removes them from the air mix, filtering them.
tweak: stimulum no longer require plasma
add: canister sprites, gas sprites
add: crystal from gases formation and reaction
add: new metallic hydrogen recipes
add: elder atmosian statue
add: supermatter interactions
tweak: minor changes to fusion math to make it "easier" to start
add : pluoxium can be also made without using rads (not removing the rad production one) (this also produces a minimal amount of h2)
tweak: lowered hypernoblium min temperature of reaction
tweak: metallic hydrogen production more common
add: cyrion-b bounty
add: all 5 gases are up to selling
/🆑
2020-09-10 03:00:51 -07:00
Timberpoes 638eaaa8a2 Fix incorrect proc signature for /mob/living/proc/Life (#53565)
#52981 changed how Life() procs were called. It also forgot to 
re-define the Life proc signature after doing so. This gives Life the 
appropriate signature.

Our intended breathing mechanic of once every 4 life ticks became every 
single life tick, effectively making mobs breathe 4 times as often as 
they should. Oh, my dear Atmos subsystem, how you must be crying in 
pain!
2020-09-09 17:45:42 -07:00
81Denton e33c98380c Merge pull request #53507 from msgerbs/pubby-shuttle-fix
Fixes Pubbystation Monastery Shuttle not docking at centcom
2020-09-09 23:35:35 +02:00
81Denton fcf3c58b36 Merge pull request #53521 from ATH1909/hardsuitbuff
The gem-encrusted hardsuit no longer slows you down while you wear it.
2020-09-09 23:24:37 +02:00
Ghilker 2524baac10 Again crystal invasion fix, why edition (+ balancing because why not) (#53559)
* In the jungle, the mighty jungle the lion sleeps tonight

* AHHHHHH

* fix on the define

* even better define

* changes

* better define measurements and use

* better define name
2020-09-09 22:43:02 +02:00
msgerbs 0805bbb538 Fixes air alarm operating modes not working 2020-09-09 10:14:36 -05:00
Jared-Fogle bd8c9f5676 Removes the clogged vents event (#53549)
Removes the clogged vents, aka "backpressure surge" event. Preserves the beer nuke behavior, however.
2020-09-09 06:48:45 -03:00
Jared-Fogle de82e10649 Hulks now are able to attack monkeys (#53548) 2020-09-09 06:46:00 -03:00
msgerbs f4ea6db565 Fixes shuttle catastrophe triggering when Build Your Own Shuttle kit purchased and ghosting people (#53532)
The Shuttle Catastrophe event now checks for the /obj/docking_port/mobile/emergency/shuttle_build subtype rather than checking for a specific mobile docking port name when checking to see if it should spawn. This should keep Shuttle Catastrophe from triggering when Build Your Own Shuttle has been purchased and ghosting/qdeling everyone and everything onboard.
2020-09-09 06:43:00 -03:00
Ryll Ryll 452ea00cff No more blobs after shuttle passes point of no return (#53488)
* DIE BLOB DIE

* define for PONR

* Update code/__DEFINES/shuttles.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-09-08 20:21:54 -07:00
ATH1909 36e0206849 da dadadada da da, dada da da, dada da da, da (#53405) 2020-09-08 20:20:57 -07:00
LemonInTheDark 2c20897f00 Readds the tesla, reworks it a bit (#53072)
* Makes tesla movement nicer, fixes some atmos concerns, changes how energy is handled, and readds the tesla

* readds delam and desc

* I fucked it

* flags

* holy fuck

* Constricts the zaps that can generate power from a tesla coil

* *kick?
2020-09-08 20:16:42 -07:00
ArcaneMusic c6ed8a7fad Improves cardboard box consistency. (#53525)
* Improves cardboard box consistency

* Also gives them cardboard datum mats.
2020-09-08 20:09:01 -07:00
Whoneedspacee 2a4bf712af Fix ruins overlapping the station and away missions increasing world size (#53558)
Changes the bounds size proc from async to not. We need to make sure 
the bounds on map templates are correct before they are spawned or 
weird issues can happen. Fixes #53542. Fixes #53562.
2020-09-08 20:01:27 -07:00
ShizCalev 66df9ecff6 Merge pull request #53540 from itseasytosee/bonk
Nightmares no longer bash people over the head with the blunt end of their light eater.
2020-09-08 21:34:11 -04:00
Qustinnus 9cb35cad29 Allows you to use the ability of vatbeasts when riding them (#53266) 2020-09-08 17:58:13 -07:00
LemonInTheDark 834c87b2c9 Merge pull request #52907 from Wallemations/master
This pull request adds the neutral quirk "Tongue Tied", which relegates the user to sign language, along with both the positive and negative effects this can have. After some thought, I had decided to make it neutral due to the overall impact its effects can have.
Effects include:

    Having one hand full causes your speech to be obscured. Having both hands full makes you unable to speak at all. This also applies to the removal of said limbs.
    Obviously using your hands would hinder speech over radio, so to get around this, Nanotrasen have developed a special kind of glove for those with this speech impediment! Don't lose them though, or you'll have to create new ones.
    The deaf can understand you, and you're "immune" to being mute as long as you can sign! Of course, good luck communicating with anyone who's blind.
    Punctuation? In my visual-based language? Hell no, you better learn to read people's faces. When someone's eyebrows are raised, they are surprised/exclaiming, whilst lowering ones eyebrows indicates they are asking a question. Just like real Sign Language!

Awards players who pick it for being more aware & efficient with their inventory, whilst punishing them for carrying items in their hands 24/7. It further opens these players to new communication options & challenges, whilst giving people who go against them new hurdles & weaknesses to exploit.
2020-09-08 14:05:51 -07:00
TiviPlus c750c51edc WHY DO I KEEP BREAKING THINGS (#53557) 2020-09-08 19:23:45 +02:00
Donkie 53b212ddf2 Process procs now properly utilize deltatime when implementing rates, timers and probabilities (#52981)
* Process procs now properly use deltatime when implementing rates, timers and probabilities

* Review fixes

* Geiger counters cleanup

Made hardsuit geiger code more similar to geiger counter code
Geiger counters are more responsive now

* Moved SS*_DT defines to subsystems.dm

* Rebase fix

* Redefined the SS*_DT defines to use the subsystem wait vars

* Implemented suggested changes by @AnturK

* Commented /datum/proc/process about the deltatime stuff

* Send delta_time as a process parameter instead of the defines

Also DTfied acid_processing

* Dtfied new acid component
2020-09-08 10:24:05 +02:00
Wallemations 4f81809a9e Merge branch 'master' of https://github.com/Wallemations/tgwallstation 2020-09-07 23:43:54 -04:00
Wallemations e38c3072b2 changes deaf_message 2020-09-07 23:43:02 -04:00
Wallemations 3779dfe2a3 Merge branch 'master' into master 2020-09-07 21:42:22 -04:00
Wallemations 044665b656 removes uneeded else & changes deaf_message 2020-09-07 21:36:33 -04:00
Fikou 123450725d adds trait injector mapping helper (#53473)
adds trait injector mapping helper and updates the traits_by_type list
thanks to anturk and mso
2020-09-07 21:59:39 -03:00
Unknown f117da4de8 cronch 2020-09-07 17:59:50 -05:00
Wallemations 51770d773d swaps findtext for variables 2020-09-07 18:46:16 -04:00
LemonInTheDark 208309def9 Merge pull request #53377 from ArcaneMusic/plumbingfixesrev2
So, I may have made at least one... maybe 1.5 math errors. Namely, the reaction volume on every reagent was the full 200u. This is bad for bitcoin, as it means that you can instantly bottom out most reactions and drown someone in 1000 units of water in a single second! That's bad.

Also! On that note, vapor reaction was also transferring reagents that otherwise helped contribute to the above problem. I've yeeted this in kind, but I'm willing to do some more testing and planning to see if they were specific to the reaction volume fix first, but to be safe vapor is vape-aint.

Lastly: Gas chems were producing way, way, WAY too much gas even once the above two points were occuring. So much gas, that it was capable of filling a 8x10 tile airless room in a timed 1 minute 40 seconds. So, we've slowed the roll of the free reagents being produced by synthesizers, and brought it down to 1/5th of the reaction volume to 1/20th. That sounds like a massive leap, but trust me, you could produce millions of KPA very, VERY quickly without it, but at 1/20 it was actually sort of reasonable.

Edit: Apparently this also fixes #46413 as a result of removing the obj_react from the above gasses!

Fixes #53357. Also, prevents reagent synthesizers and showers to behave EXACTLY like gas miners, but free. Also, prevents 1000s of reagents from being multiplied through the use of showers.
Changelog

fix: Showers no longer have the vapor reaction, as before the changes.
fix: Showers no longer produce ludicrously over-scaled chemical reactions.
balance: Gas chems now produce 1/4th less gas when released into the air as before.
2020-09-07 15:12:51 -07:00
Coffee f4ea237a6f Makes highlander turn off pacifism (#53504)
Makes gaining the highlander antagonist status turn disable the pacifism quirk. It will re-enable if you lose the status, although that doesn't happen often.
2020-09-07 19:06:00 -03:00
AnturK 5d8c21e2d1 Fixes spacemandmm detected for mistakes. (#53503) 2020-09-07 19:05:22 -03:00
NightRed 0e5598ba5b Unit tests for expose_mob (#53498)
This is a set of unit tests for expose_mob.
This tests that INGEST, TOUCH, VAPOR, PATCH, INJECT are triggering on standard exposure methods.
2020-09-07 19:04:29 -03:00
msgerbs 9e705731d9 Cleans up an unused var added for smugglers satchels (#53501) 2020-09-07 19:02:17 -03:00
ArcaneMusic 2d8fee9bd0 Updates conflicts. 2020-09-07 16:58:21 -04:00
ArcaneMusic 3bddcbd506 Merge remote-tracking branch 'upstream/master' into plumbingfixesrev2 2020-09-07 16:57:20 -04:00
Jared-Fogle 4c358cd25f Performing a head transplant will now properly preserve the appearance. (#53494) 2020-09-07 17:56:16 -03:00
Kyle Spier-Swenson 97e7b9683d Fix bicon, fix asset hashes being incorrect. (#53441)
icon2html will now always show the south direction unless passed a specific direction to show. Null can be explicitly passed with an atom to use the atom's direction. This is to work around icon() returning a blank icon if passed a direction that the icon doesn't define, instead of defaulting to south like the client does. This should also cut down on the number of assets generated by shift clicks

If icon2html is given an atom with an invalid icon state, it will use the atom's compile time icon_state, so smoothed icons can show their mapper's helper icon instead of the entire dmi.

Asset cache will now copy files to disk before md5ing them, to deal with byond not always returning the correct md5 for rsc references.
2020-09-07 17:54:26 -03:00
Ryll Ryll e9ee817cb4 Fixes admin tickets displaying as improper nouns (#53485)
Admin tickets were having "the" prepended to them when displayed in the status tab, because ahelps are treated as datums and BYOND likes to help out and treat them as nouns when printed. This resolves that.
2020-09-07 17:49:14 -03:00
TiviPlus d4cdb49133 Mecha followup one (#53470)
fixes #53384
fixes #53327
fixes a bug where mechs could move too fast
fixes cooldown being inconsistent
makes strafe behavior better
fixes lights being very small

fixes #50639
fixes #47373
fixes #43605

Moved some code to the correct spots and did the varedit bitfield thing
2020-09-07 17:44:54 -03:00
YPOQ d9aff3da6e Fixes the arena shuttle (#53458)
This splits the actual arena of the arena shuttle into its own map file that is loaded onto it's own z-level. The old method of including a non-shuttle area in the shuttle map file doesn't work with the current shuttle loader. It also fixes shuttles being loaded twice when purchased which created problems with landmarks being left behind in the reserved z-level.
2020-09-07 17:24:10 -03:00
Ghilker 5543c6db46 crystal invasion balancing and fixes (Now with extra rework!) (#53399)
Refractored code so that the more_portals() proc gets called by the event instead of a CALLBACK
Balanced mobs spawn from portal and how much damage they deal
Fixed grammar stuff on crystal consume announcement
Ligthing aoe projectile now have a no_stun version for the boss rank
Lowered time needed to use the crystal stabilizer to 7 second total
Crystal mobs have TRAIT_TESLA_SHOCKIMMUNE to prevent boss from hurting himself and the other crystal mobs
Added check at start of event for presence of the supermatter crystal

New: Revamped event a bit, now instead of random portal appearing a random, there will be from 2 to 5 main portals and around those 6 more portals will appear; after that centcomm will announce the position of those new portals. Now the players will have to close those main portals before being able to stabilize the crystal because there will be a shield around it powered by those portals. Everything else will be the same (like how to close the portals and stabilize the crystal)
2020-09-07 16:52:10 -03:00
Shirbu 53df2b2fe6 Reduces the light range of all beam (lasers, disablers, emitter shots) projectiles (#53328) 2020-09-07 16:48:32 -03:00