Commit Graph

46668 Commits

Author SHA1 Message Date
WJohn fdfba8fc47 Fix movement hunger costs (#43607)
It seems it was intended to make movement cost a bit of hunger per tile,
but was actually only happening while you were floating (despite the
comment saying it should be easy).

This reverses that so it's now working as intended.

Testing shows this increases nutrition by about 5.6 per minute of
non-stop (non-floating) running movement. Walking cuts this cost by more
than half as not only do you cover fewer tiles in a minute, but walking
also costs half as much in tile-tile movement.

If you're on meth, expect to get quite hungry from zooming around the
station like a madman at 300 mph, which I think makes quite a bit of
sense.
2019-04-14 21:47:44 -07:00
AnturK 326e59dc69 Buff beetlejuice component (#43581)
Forgot to add this when I changed it to regex.
2019-04-14 21:45:04 -07:00
RaveRadbury 369933d541 pAIs eject into hands (#43592)
Currently pAIs cannot be configured for DNA and secondary directives
while inside a PDA. If I need to eject my pAI from my PDA, why would I
want to drop it on the floor, especially when it hasn't been configured?

An activated pAI is too valuable to drop from your PDA directly to the
ground.
2019-04-14 21:41:48 -07:00
Tlaltecuhtli 5cfd1c851c [ready]secway + atv nerfs (#43396)
* 1

* dont commit this

* commit this

* commit erefasdagsdbsvrsccsdsdfsdfs

* changes

* fdf

* fixes bullet_act

* obj_break

* (____Y____)
2019-04-13 16:11:24 -04:00
pireamaineach f190c0b65f Ports far too many haircuts and beards. (#43564)
* FuCK

* Adds far too many haircuts.

Help.

* Update sprite_accessories.dm

* Update human_face.dmi

* Update human_face.dmi

* Update human_face.dmi
2019-04-13 16:06:56 -04:00
YoYoBatty 9316afb40a Fix being able to build multiple terminals for SMES's (#43579) 2019-04-11 21:26:43 -07:00
YoYoBatty 1517799b92 Fix blastdoors/shutters button spam (#43577) 2019-04-11 21:25:29 -07:00
Kierany9 5b7e5ca0b7 M-M-M-MONSTER BUG (#43571) 2019-04-11 12:43:26 -04:00
AnturK 05d24f0917 Fix monkeys picking up stuff when incapacitated (#43556)
Only really relevant for items on the same tile as the monkey.
2019-04-10 19:54:13 -07:00
81Denton eb90e2a3ad Adds friendly life reaction to chemistry (#43529)
* Adds friendly life reaction to chemistry

* replaces blood with pax

* Update others.dm

* Replaces pax with sugar
2019-04-10 16:41:08 -04:00
WJohn 52637ff9ec Fixes neat/neet traits. (#43561) 2019-04-10 15:49:28 -04:00
pireamaineach b96dbc1508 Beret Resprites Mk. II (#43543)
* FuCK

* Beret Resprites

* e

* Adds the archaic and vintage berets.

* Grammar fix.

Just misspelled allegedly.

* Grammar fix.

* Modifies the beret to bring it a bit more off the eye.
2019-04-10 12:17:16 -04:00
Joey H 4fc5e8b40d Slot machines can't refund zero balance (#43558)
* Fix #43488, slot machines can't refund zero balance

* Remove braces around single line string
2019-04-10 12:15:50 +02:00
Tad Hardesty 1cae58aeab Fix weird padding issues on Character Setup screen (#43544) 2019-04-10 12:14:27 +02:00
oranges 4777e7da53 *vzdokh (#43566) 2019-04-10 12:09:16 +02:00
ShizCalev 3d00e7e32f Add cooldown to vending machine purchase messages (#43554) 2019-04-09 21:06:11 -07:00
Jordie afd3f58c20 Merge pull request #43565 from optimumtact/paperogging
Add a log for paper edits
2019-04-10 10:36:14 +10:00
AnturK fa6a01fe04 Add admin quirk command, fix and unify quirk helpers (#43553)
This whole quirk thing is painful to read and needs a full refactor.
2019-04-09 17:16:15 -07:00
oranges 1de8e39aad Add a log for paper edits
This should have been done ages ago
2019-04-09 22:48:06 +00:00
Tlaltecuhtli c565a7230b autolathe speed func is the same as protolathe (#43513)
* 1

* 2
2019-04-09 17:36:38 -04:00
nemvar dea883d4ab Give the baguette a belt sprite (#43514)
Extra mime content.
2019-04-08 22:10:07 -07:00
Tlaltecuhtli ba1f6a77cf cargo crate fix (#43493)
* 1

* alphabet

* probably a typo
2019-04-08 16:05:18 -04:00
Tad Hardesty af81aceab4 Fix chem dispensers starting with an extra power cell (#43526) 2019-04-08 15:55:40 -04:00
Kierany9 7f0b03b1b2 Update hivemind.dm (#43532) 2019-04-08 15:55:06 -04:00
Tad Hardesty a8fa220f7f Fix convert_roundtype runtiming instead of failing gracefully (#43536) 2019-04-08 15:54:49 -04:00
Tad Hardesty bbef4190f8 Fix runtime when lightning smiting non-humans (#43537) 2019-04-08 15:54:32 -04:00
Tad Hardesty b992620011 Fix runtime when setting up a sec character before atoms initialize (#43527) 2019-04-08 15:54:06 -04:00
Tad Hardesty 9c9cc9110a Improve cancellability of Run Weather admin verb (#43528) 2019-04-08 15:53:44 -04:00
Tad Hardesty c7390b28d7 Give Cyborg modules their icons in the map editor (#43509) 2019-04-08 10:39:55 +02:00
Tad Hardesty 38977aa740 Fix Alt-Click to rotate soda and booze dispensers (#43522) 2019-04-08 10:37:39 +02:00
Kyle Spier-Swenson a052185777 Captain now requires playtime as another head role (#43495)
By default (assuming the department based exp lockout config is enabled), hos requires 5 hours as security. but the captain only requires 3 hours as crew?

Seems silly. 

@iamgoofball I wonder if banned accounts still get notifications.

Somebody with more time than me: make the config for these use a keyed list for per-job overrides, rather than a flat head override.

Somebody else with more time than me: make a config that allows readying for time restricted roles anyways, but only at low priority.
2019-04-08 10:36:29 +02:00
Tad Hardesty 09949fe611 Fix welfare being given to everybody else with the same job (#43490)
* goddamn NEETs ruining my economy, fixes #42387

* Fix remaining broken call to add_neetbux
2019-04-08 10:29:51 +02:00
Kyle Spier-Swenson 2cace871d8 Handle OoM errors (#43349)
Sometimes a reason 1 restart will work to fix these for servers without
tgs3.

This works on tgs3 even though the api sleeps, this will likely not work on
tgs4. In those cases the world/Reboot call will likely still bring the
server back up to a functional point that an admin can do a tgs restart via
the verb.

There is no point in attempting to notify clients, every attempt at doing
so failed.
2019-04-08 00:03:15 -07:00
oranges c013c37a9c Merge pull request #43463 from subject217/ashwalker
Ash Walker flavor text modification
2019-04-08 09:12:04 +12:00
William Wallace c06ec19eb0 Update canister icons when connected to a port (#43518)
I found that when the valve of a canister was closed, the
.../canister/process_atmos proc would never reach its update_icon call.
I've fixed that by removing the early return and having a single
update_icon call at the end run when necessary.
2019-04-07 14:05:05 -07:00
AnturK 67deb481be Switch preloader to world proc (#43516) 2019-04-07 14:04:18 -07:00
QFMVC 8054bc34db Give space cleaner the ability to clean people (#43494)
Space cleaner sprayed, splashed or vaporised onto someone will slightly
improve their hygiene. Effective janitors can spray stinky spessmen to
stave off the stench long enough for the offender to have a shower. Space
cleaner will only stop you from stinking for a short time, unlike a shower
which will keep you fresh for much longer.

The amount of cleanliness from a single application of space cleaner is
capped, so a chemist dumping a bluespace beaker of space cleaner on their
head is not going to be as effective as a shower.

Giving janitors an extra way to help the crew is probably good, especially
because this additional mechanic can't be replaced by janiborgs or
cleanbots.
2019-04-07 00:34:53 -07:00
FloranOtten f9a07c113e Give mechs various levels of rad protection (#43452) 2019-04-06 22:45:32 -07:00
Menshin db7ddeee4a Fix the CHECK_MULTIPLE_BITFIELDS macro (#43505)
Found by TGMC people, the CHECK_MULTIPLE_BITFIELDS macro wasn't
parenthesing the == rvalue, so

CHECK_MULTIPLE_BITFIELDS(var, flag1 | flag 2)

would come as
(var & (flag 1 | flag 2)) == flag 1 | flag2

instead of
(var & (flag 1 | flag 2)) == (flag 1 | flag2)

making the check always pass when a second flag was checked.

Only /datum/component/footstep/proc/play_footstep() was using it in that
way though and it doesn't seems it was impacting it much.
2019-04-06 12:36:05 -07:00
Mickyan 772be289ce Tweak blood deficiency to be less deadly by itself (#43501)
I came to the conclusion that quirks that put you on a death timer are
dumb and boring, one such reason being they make you unable to go AFK for
any length of time but also aren't interesting to manage other than
lugging around whatever medicine you need to survive every round.

Blood loss now stops just above a survivable threshold, meaning when left
untreated even the smallest of wounds is potentially lethal, hence it's
still 2 points. Watch out for paper cuts.

Renamed just to make it a bit shorter and less spooky.
2019-04-06 12:35:27 -07:00
RaveRadbury 89f4e05079 Allow bike horn and baguette to equip to belt and back (#43471)
A lot of equipment can be placed on the back and belt slot. Much of this
equipment is job specific. Sadly, the Clown and Mime have been left out
of the fun.

Why should all the other jobs have the fun of belt and back slots?
Sometimes you want to mosey around the station like a honkin' cowboy,
your bikehorn clipped securely to your belt. Now you can. Your trusty
honkshooter is ready to go. DRAW!

Or maybe you're a Mime who wants his crusty baguette saber at his side.
EN GARDE!
2019-04-06 01:28:37 -07:00
py01 bab739ca81 Fix armblades sometimes having trouble prying open doors (#43481) 2019-04-05 15:42:09 -07:00
ShizCalev a0652c3700 Enable tac reloads for most ballistic weapons (#43466) 2019-04-04 23:51:58 -07:00
AnturK b9210e9811 Fix a few nanite runtimes (#43478)
Just some missing sanity checks.

* Fixes spreading nanites runtimes.
* Also glitch runtime.
2019-04-04 21:54:59 -07:00
Brett Williams e23cc06531 Changes Monkey Tackling to Function Like Disarm Rework (#43424)
* Fix the monkies

* pinned commit
2019-04-04 16:11:17 -04:00
oranges 627cd2bb0c Merge pull request #43484 from Militaires/clownsuit
fixes clown suit datum runtime
2019-04-04 19:10:22 +13:00
Rob Bailey a9b39afe66 [READY] Disarm Rework: Shove that Dickhead (#42958)
The War on Stun Based Combat Phase II
About The Pull Request

A massive change in gameplay that affects more than just disarm. Hopefully in an interesting way.
There's two parts to this, part 1 is that disarm's functionality has been entirely stripped out and replaced with essentially a new purpose: Shoving.
Shoving is the new action that occurs when clicking on people while in the disarm intent.
Shoving someone pushes them one tile away from you. If there is otherwise nothing blocking them, they are slowed down very slightly for 3 seconds. If you shove someone again while they are slowed, it knocks ranged weapons out of their active hand. I'm not sure about this part and may buff or remove it depending on how it works in practice.
If the blocking tile has a table on it, they're pushed onto it knocking them over for 3 seconds. If it has another human on it, it knocks them both over, the collateral victim for 1 second instead of 3. If the tile is otherwise blocked besides them, it knocks them down for 3 seconds. All knockdowns cause you to drop items, and do not stun at all and can be immediately crawled away from.
However, once knocked down, if you are shoved again it paralyzes for 4 seconds. This is the same length as the old disarm push. It cannot be chained or extended, shoving them again while they're paralyzed does not extend the length of the paralyze. Once it ends, the person will be up and moving.
Now you might be thinking, why would I want to shove someone unless they're against a wall?
Here's part 2:
Moving into someone in a hostile intent no longer pushes them. They'll stay where they are and your movement is blocked. If you want to get someone out of the way, you need to shove them.
Why It's Good For The Game

Changes a previously RNG based mechanic that was basically just spammed until you got that lucky "I win" roll into a positioning based utility that has a point to use in many situations. Livens up simple melee combat and makes fighting in confined areas more lively and unpredictable. Introduces some new epic gamer strats, I've been playing around and it's pretty fun.
Also why not try something really crazy and see what happens? If it's shit it can be reverted :^)
Changelog

Special thanks to whoneedsspace, the inventor of the singlecap, for deshitcodifying this hard.

cl
add: Disarm has been reworked, instead of an rng based system instead it pushes people away from you. If their movement is blocked it knocks them over. Shoving someone twice quickly will knock ranged weapons out of their hands.
del: Moving into humans while in a hostile intent no longer pushes them.
tweak: Passive grabs need to be resisted out of while on the ground, and can't be directly crawled out of
/cl
2019-04-04 18:58:09 +13:00
militaires 72121f2974 fixes clown suit datum runtime 2019-04-04 02:12:01 +02:00
RaveRadbury 270d76a915 Fix typo in Space Adaptation description (#43476)
INCREDIBLY CRUCIAL BUGFIX

IF IS NOT OF BUT NOW IT IS
2019-04-03 16:28:51 -07:00
FloranOtten 80ab07fad7 spellcheck (#43467) 2019-04-03 14:27:18 -04:00