From a7b70ee9ccabd53fada8ea74cf35804c49acaa06 Mon Sep 17 00:00:00 2001
From: David Baker <dbkr@users.noreply.github.com>
Date: Thu, 4 Jun 2026 18:03:10 +0100
Subject: [PATCH] More 'df' debugging in GHA workflows (#33751)

Firstly, I add4ed the df before to the wrong job. Secondly, shared
component visual tests is now flaking the same way, so add the same
there.
---
 .github/workflows/shared-component-visual-tests.yaml | 10 ++++++++++
 .github/workflows/tests.yml                          | 10 +++++-----
 2 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/shared-component-visual-tests.yaml b/.github/workflows/shared-component-visual-tests.yaml
index 6163766f98..370e726b05 100644
--- a/.github/workflows/shared-component-visual-tests.yaml
+++ b/.github/workflows/shared-component-visual-tests.yaml
@@ -21,6 +21,11 @@ jobs:
             issues: read
             pull-requests: read
         steps:
+            # Dump the disk usage before we start: this job frequently flakes with "No space left on device"
+            # so, with the one at the end too, this will let us work out how much disk has been used.
+            - name: dfbefore
+              run: df -h && df -i
+
             - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
               with:
                   persist-credentials: false
@@ -58,3 +63,8 @@ jobs:
               with:
                   name: received-images
                   path: packages/shared-components/__vis__/linux
+
+            # Dump the disk usage on failure, because this job seems to fail with disk fills sometimes
+            - name: df
+              run: df -h && df -i
+              if: ${{ failure() }}
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 544fcc4166..83a71aedde 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -37,11 +37,6 @@ jobs:
                 # Run multiple instances in parallel to speed up the tests
                 runner: [1, 2]
         steps:
-            # Dump the disk usage before we start: this job frequently flakes with "No space left on device"
-            # so, with the one at the end too, this will let us work out how much disk has been used.
-            - name: dfbefore
-              run: df -h && df -i
-
             - name: Checkout code
               uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
               with:
@@ -111,6 +106,11 @@ jobs:
                     - packages/module-api
         runs-on: ubuntu-24.04
         steps:
+            # Dump the disk usage before we start: this job frequently flakes with "No space left on device"
+            # so, with the one at the end too, this will let us work out how much disk has been used.
+            - name: dfbefore
+              run: df -h && df -i
+
             - name: Checkout code
               uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
               with: