diff --git a/dom/performance/Performance.cpp b/dom/performance/Performance.cpp index 9a1d134626..0217b20153 100755 --- a/dom/performance/Performance.cpp +++ b/dom/performance/Performance.cpp @@ -413,16 +413,16 @@ DOMHighResTimeStamp Performance::ConvertNameToTimestamp(const nsAString& aName, DOMHighResTimeStamp Performance::ResolveEndTimeForMeasure( const Optional& aEndMark, - const PerformanceMeasureOptions* aOptions, + const Maybe& aOptions, ErrorResult& aRv) { DOMHighResTimeStamp endTime; if (aEndMark.WasPassed()) { endTime = ConvertMarkToTimestampWithString(aEndMark.Value(), aRv); - } else if (aOptions != nullptr && aOptions->mEnd.WasPassed()) { + } else if (aOptions && aOptions->mEnd.WasPassed()) { endTime = ConvertMarkToTimestamp(ResolveTimestampAttribute::End, aOptions->mEnd.Value(), aRv); - } else if (aOptions != nullptr && aOptions->mStart.WasPassed() && + } else if (aOptions && aOptions->mStart.WasPassed() && aOptions->mDuration.WasPassed()) { const DOMHighResTimeStamp start = ConvertMarkToTimestamp( ResolveTimestampAttribute::Start, aOptions->mStart.Value(), aRv); @@ -447,16 +447,16 @@ Performance::ResolveEndTimeForMeasure( DOMHighResTimeStamp Performance::ResolveStartTimeForMeasure( - const nsAString* aStartMark, - const PerformanceMeasureOptions* aOptions, + const Maybe& aStartMark, + const Maybe& aOptions, ErrorResult& aRv) { DOMHighResTimeStamp startTime; - if (aOptions != nullptr && aOptions->mStart.WasPassed()) { + if (aOptions && aOptions->mStart.WasPassed()) { startTime = ConvertMarkToTimestamp(ResolveTimestampAttribute::Start, aOptions->mStart.Value(), aRv); - } else if (aOptions != nullptr && aOptions->mDuration.WasPassed() && + } else if (aOptions && aOptions->mDuration.WasPassed() && aOptions->mEnd.WasPassed()) { const DOMHighResTimeStamp duration = ConvertMarkToTimestampWithDOMHighResTimeStamp( @@ -474,7 +474,7 @@ Performance::ResolveStartTimeForMeasure( } startTime = end - duration; - } else if (aStartMark != nullptr) { + } else if (aStartMark) { startTime = ConvertMarkToTimestampWithString(*aStartMark, aRv); } else { startTime = 0; @@ -496,13 +496,14 @@ Performance::Measure(JSContext* aCx, return nullptr; } - const PerformanceMeasureOptions* options = nullptr; + // Maybe is more readable than using the union type directly. + Maybe options; if (aStartOrMeasureOptions.IsPerformanceMeasureOptions()) { - options = &aStartOrMeasureOptions.GetAsPerformanceMeasureOptions(); + options.emplace(aStartOrMeasureOptions.GetAsPerformanceMeasureOptions()); } const bool isOptionsNotEmpty = - (options != nullptr) && + options.isSome() && (!options->mDetail.isUndefined() || options->mStart.WasPassed() || options->mEnd.WasPassed() || options->mDuration.WasPassed()); if (isOptionsNotEmpty) { @@ -529,9 +530,10 @@ Performance::Measure(JSContext* aCx, return nullptr; } - const nsAString* startMark = nullptr; + // Convert to Maybe for consistency with options. + Maybe startMark; if (aStartOrMeasureOptions.IsString()) { - startMark = &aStartOrMeasureOptions.GetAsString(); + startMark.emplace(aStartOrMeasureOptions.GetAsString()); } const DOMHighResTimeStamp startTime = ResolveStartTimeForMeasure(startMark, options, aRv); @@ -540,7 +542,7 @@ Performance::Measure(JSContext* aCx, } JS::Rooted detail(aCx); - if (options != nullptr && !options->mDetail.isNullOrUndefined()) { + if (options && !options->mDetail.isNullOrUndefined()) { StructuredSerializeOptions serializeOptions; JS::Rooted valueToClone(aCx, options->mDetail); nsContentUtils::StructuredClone(aCx, GetParentObject(), valueToClone, diff --git a/dom/performance/Performance.h b/dom/performance/Performance.h index 2108e1e394..d84cf06765 100644 --- a/dom/performance/Performance.h +++ b/dom/performance/Performance.h @@ -195,11 +195,11 @@ private: DOMHighResTimeStamp ResolveEndTimeForMeasure( const Optional& aEndMark, - const PerformanceMeasureOptions* aOptions, + const Maybe& aOptions, ErrorResult& aRv); DOMHighResTimeStamp ResolveStartTimeForMeasure( - const nsAString* aStartMark, - const PerformanceMeasureOptions* aOptions, + const Maybe& aStartMark, + const Maybe& aOptions, ErrorResult& aRv); };