roytam1/UXP
1
0
Fork 0
mirror of https://github.com/roytam1/UXP.git synced 2026-05-29 16:58:28 +00:00
Code Issues Projects Releases Wiki Activity

Prevent the existance of dangling pointers upon failure of FindDataStart.

Browse Source
This commit is contained in:
Bas Schouten
2020-05-05 23:22:19 +00:00
committed by Roy Tam
parent 89ad46ab66
commit 27ea0aaf55
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/libjar/nsZipArchive.cpp
+2 -1
View File
@@ -217,16 +217,17 @@ nsresult nsZipHandle::Init(nsIFile *file, nsZipHandle **ret,
#else
handle->mNSPRFileDesc = fd.forget();
#endif
handle->mMap = map;
handle->mFile.Init(file);
handle->mTotalLen = (uint32_t) size;
handle->mFileStart = buf;
rv = handle->findDataStart();
if (NS_FAILED(rv)) {
PR_MemUnmap(buf, (uint32_t) size);
handle->mFileStart = nullptr;
PR_CloseFileMap(map);
return rv;
}
handle->mMap = map;
handle.forget(ret);
return NS_OK;
}