diff --git a/image/imgLoader.cpp b/image/imgLoader.cpp index f3e614d0a2..d8e50cb2eb 100644 --- a/image/imgLoader.cpp +++ b/image/imgLoader.cpp @@ -2489,13 +2489,6 @@ imgLoader::GetMIMETypeFromContent(nsIRequest* aRequest, uint32_t aLength, nsACString& aContentType) { - nsCOMPtr channel(do_QueryInterface(aRequest)); - if (channel) { - nsCOMPtr loadInfo = channel->GetLoadInfo(); - if (loadInfo->GetSkipContentSniffing()) { - return NS_ERROR_NOT_AVAILABLE; - } - } return GetMimeTypeFromContent((const char*)aContents, aLength, aContentType); } diff --git a/netwerk/base/nsNetUtil.cpp b/netwerk/base/nsNetUtil.cpp index ce62cfa8fc..d6db22098a 100644 --- a/netwerk/base/nsNetUtil.cpp +++ b/netwerk/base/nsNetUtil.cpp @@ -2129,6 +2129,16 @@ NS_SniffContent(const char *aSnifferType, nsIRequest *aRequest, const uint8_t *aData, uint32_t aLength, nsACString &aSniffedType) { + // In case XCTO nosniff was present, we could just skip sniffing here + nsCOMPtr channel = do_QueryInterface(aRequest); + if (channel) { + nsCOMPtr loadInfo = channel->GetLoadInfo(); + if (loadInfo->GetSkipContentSniffing()) { + aSniffedType.Truncate(); + return; + } + } + typedef nsCategoryCache ContentSnifferCache; extern ContentSnifferCache* gNetSniffers; extern ContentSnifferCache* gDataSniffers; diff --git a/netwerk/protocol/http/nsHttpChannel.cpp b/netwerk/protocol/http/nsHttpChannel.cpp index dba009ea30..c28606982e 100644 --- a/netwerk/protocol/http/nsHttpChannel.cpp +++ b/netwerk/protocol/http/nsHttpChannel.cpp @@ -1106,7 +1106,7 @@ ProcessXCTO(nsIURI* aURI, nsHttpResponseHead* aResponseHead, nsILoadInfo* aLoadI policyType == nsIContentPolicy::TYPE_SUBDOCUMENT) { // If the header XCTO nosniff is set for any browsing context, then // we set the skipContentSniffing flag on the Loadinfo. Within - // GetMIMETypeFromContent we then bail early and do not do any sniffing. + // NS_SniffContent we then bail early and do not do any sniffing. aLoadInfo->SetSkipContentSniffing(true); return NS_OK; } diff --git a/netwerk/streamconv/converters/nsUnknownDecoder.cpp b/netwerk/streamconv/converters/nsUnknownDecoder.cpp index bab9b84c98..f12f02b4f8 100644 --- a/netwerk/streamconv/converters/nsUnknownDecoder.cpp +++ b/netwerk/streamconv/converters/nsUnknownDecoder.cpp @@ -317,11 +317,9 @@ nsUnknownDecoder::GetMIMETypeFromContent(nsIRequest* aRequest, { // Note: This is only used by sniffer, therefore we do not need to lock anything here. nsCOMPtr channel(do_QueryInterface(aRequest)); - if (channel) { - nsCOMPtr loadInfo = channel->GetLoadInfo(); - if (loadInfo->GetSkipContentSniffing()) { - return NS_ERROR_NOT_AVAILABLE; - } + nsCOMPtr loadInfo = channel->GetLoadInfo(); + if (loadInfo->GetSkipContentSniffing()) { + return NS_OK; } mBuffer = const_cast(reinterpret_cast(aData)); mBufferLen = aLength; diff --git a/toolkit/components/mediasniffer/nsMediaSniffer.cpp b/toolkit/components/mediasniffer/nsMediaSniffer.cpp index 5c6fee065e..d00dea894b 100644 --- a/toolkit/components/mediasniffer/nsMediaSniffer.cpp +++ b/toolkit/components/mediasniffer/nsMediaSniffer.cpp @@ -138,10 +138,6 @@ nsMediaSniffer::GetMIMETypeFromContent(nsIRequest* aRequest, nsACString& aSniffedType) { nsCOMPtr channel = do_QueryInterface(aRequest); if (channel) { - nsCOMPtr loadInfo = channel->GetLoadInfo(); - if (loadInfo->GetSkipContentSniffing()) { - return NS_ERROR_NOT_AVAILABLE; - } nsLoadFlags loadFlags = 0; channel->GetLoadFlags(&loadFlags); if (!(loadFlags & nsIChannel::LOAD_MEDIA_SNIFFER_OVERRIDES_CONTENT_TYPE)) {