roytam1/UXP
1
0
Fork 0
mirror of https://github.com/roytam1/UXP.git synced 2026-05-29 16:58:28 +00:00
Code Issues Projects Releases Wiki Activity

[GTK3] Ignore double-click on WM without _NET_WM_MOVERESIZE support

Browse Source 
This fixes a crash with GTK3 builds used with a window manager that does not support _NET_WM_MOVERESIZE.
This commit is contained in:
trav90
2018-04-06 11:25:22 -05:00
committed by Roy Tam
parent 618138082f
commit 88757310cd
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
widget/gtk/nsWindow.cpp
+16
View File
@@ -6627,6 +6627,22 @@ nsWindow::GetDragInfo(WidgetMouseEvent* aMouseEvent,
return false;
}
if (mIsX11Display) {
// Workaround for https://bugzilla.gnome.org/show_bug.cgi?id=789054
// To avoid crashes disable double-click on WM without _NET_WM_MOVERESIZE.
// See _should_perform_ewmh_drag() at gdkwindow-x11.c
GdkScreen* screen = gdk_window_get_screen(gdk_window);
GdkAtom atom = gdk_atom_intern("_NET_WM_MOVERESIZE", FALSE);
if (!gdk_x11_screen_supports_net_wm_hint(screen, atom)) {
static unsigned int lastTimeStamp = 0;
if (lastTimeStamp != aMouseEvent->mTime) {
lastTimeStamp = aMouseEvent->mTime;
} else {
return false;
}
}
}
// FIXME: It would be nice to have the widget position at the time
// of the event, but it's relatively unlikely that the widget has
// moved since the mousedown. (On the other hand, it's quite likely