From 8bc63bffbc67b0a5850aa7dfafa8e3b379b61b3a Mon Sep 17 00:00:00 2001 From: Moonchild Date: Thu, 26 Feb 2026 08:21:45 +0100 Subject: [PATCH] [MFBT] Reduce size() calls in subspan. --- mfbt/Span.h | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/mfbt/Span.h b/mfbt/Span.h index f031a928bb..0fec610088 100644 --- a/mfbt/Span.h +++ b/mfbt/Span.h @@ -649,10 +649,11 @@ public: template MOZ_SPAN_GCC_CONSTEXPR Span Subspan() const { - MOZ_RELEASE_ASSERT(Offset <= size() && - (Count == dynamic_extent || (Offset + Count <= size()))); + const size_t len = size(); + MOZ_RELEASE_ASSERT(Offset <= len && + (Count == dynamic_extent || (Count <= len - Offset))); return { data() + Offset, - Count == dynamic_extent ? size() - Offset : Count }; + Count == dynamic_extent ? len - Offset : Count }; } /** @@ -682,11 +683,11 @@ public: index_type aStart, index_type aLength = dynamic_extent) const { - MOZ_RELEASE_ASSERT(aStart <= size() && - (aLength == dynamic_extent || - (aStart + aLength <= size()))); + const size_t len = size(); + MOZ_RELEASE_ASSERT(aStart <= len && + (aLength == dynamic_extent || (aLength <= len - aStart))); return { data() + aStart, - aLength == dynamic_extent ? size() - aStart : aLength }; + aLength == dynamic_extent ? len - aStart : aLength }; } /**