Commit Graph

77441 Commits

Author SHA1 Message Date
Timberpoes e7ff79bcbe Feex (#55144)
For whatever reason we hardcoded the health value for drills at 200 brute damage before they can gib. 200 brute damage was picked as it was double the max health of /mob/living/carbon/whatever and double the max health was like, the cap on brute damage when someone is really, really, really, really dead.

Enter simplemobs. Their max health is regularly under 100, which means a hardcoded value of 200 brute damage to trigger gibbing effects is bad. Not that it matters anyway, because simplemobs also brute damage cap at maxHealth instead of maxHealth * 2 so the only simplemobs that could be gibbed by mech drills are those with 200 or more health.

This has been changed. Simplemobs now cap out at maxHealth * 2 damage, in line with all other /mob/living while drill code has been changed to check for maxHealth * 2 when gibbing instead of a hardcoded 200.
2020-11-25 13:44:01 -08:00
tgstation-server 71e97b3c3a Automatic changelog generation for PR #55135 [ci skip] 2020-11-25 13:16:52 -08:00
Bobbahbrown 4201228541 Fixes template use for 'Report Issue' button in-game + show [s] testmerged prs (#55135)
Fixed and improved the bug report template use when the 'Report Issue' button is used in-game. It now uses the correct template location, as well as automatically filling in the round ID and testmerges.

We also now show [s] PRs that are testmerged, as ok-d by oranges, as this is an unofficial label that anyone can apply and doesn't necessitate hiding. It also makes debugging rounds where this was present but not reported more difficult.
2020-11-25 16:16:47 -05:00
tgstation-server 2cf031603a Automatic changelog generation for PR #55157 [ci skip] 2020-11-25 12:46:24 -08:00
Bobbahbrown 1b0b13a737 Replace tgalert with tgui_alert (#55157)
Adds TGUI-based alerts to replace the old tgalert system. Replaces all uses of tgalert with tgui_alert except for one, the 'Report Issue' button, as people were (understandably) concerned that this button using tgui will prevent a tgui bug from being easily reported.

These windows have a nice little progress bar indicator of how much time they have left, and will automatically close themselves after this time elapses.

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-11-25 22:46:19 +02:00
Jordan Brown 4e66e88ae8 Nerfs GBP gain (#55038)
Basically no one ever hits the lower limit and people have fucking bank at this point.
2020-11-25 19:12:56 +02:00
Aleksej Komarov 317cecf50c tgui: Fix issues detected by SonarQube (#55098)
* tgui: Fix issues detected by sonarqube

* MacOS compatibility

* Rebuild tgui
2020-11-26 00:18:57 +08:00
tgstation-server 9e0203fbfb Automatic changelog generation for PR #54747 [ci skip] 2020-11-25 04:12:17 -08:00
Ghom 4c31b0e116 CanUseTopic() refactor. (#54747)
* CanUseTopic() refactor.

* Forgot about default_can_use_topic. Tested and working.

* Update bin.dm

* no-nonsense.
2020-11-25 13:12:12 +01:00
tgstation-server 9789df0139 Automatic changelog generation for PR #55124 [ci skip] 2020-11-25 03:41:21 -08:00
Bobbahbrown 46c507e917 Moves sorting of crew console listings to clientside + refactors (#55124)
Moves the sorting of the entries within the crew console to be clientside. There's no reason to have this serverside.

I've also refactored the UI data code for the crew console in general, reduced code duplication and reduced unnecessary data transfer of nulls.
2020-11-25 13:41:16 +02:00
tgstation-server 96cbf3cac1 Automatic changelog generation for PR #55105 [ci skip] 2020-11-24 22:43:55 -08:00
prodirus e83ae87461 Fixes chem and addiction scans, null checks for addiction_list (#55105)
So #54797 changed addiction_list to instantiate as a null instead of a list. Turns out a few things relied on the list existing!
Things like health analyser/medical kiosk chem and addiction scans broke, and smokers would no longer get addicted!
Made a few places check if addiction_list is null before continuing.

(Lemon's note, refactored some code to make it cleaner/removed some unneeded loop typechecks)
2020-11-24 22:43:51 -08:00
tgstation-server 8e67e4888e Automatic changelog generation for PR #54550 [ci skip] 2020-11-24 22:37:41 -08:00
NightRed fb51b24d21 Humans have more complicated body temperatures (#54550)
This changes how carbon/humans stabilize body temperature, and changes how damage and wounds are applied based on temperature.

Humans now have a core body temperature along with body temperature. The core temperature is used for natural stabilization and what viruses like fever and shivers target by raising or lowing the core temperature of the mob.
The standard body temperature still exists and acts exactly the same for most items at this time but is now treated as surface temperature in humans.

Damage from body temperature for humans is now based on the core temperature instead of body temperature now.
Humans will now receive burn wounds when the body (surface) temperature is to high for to long.

This causes you to see alerts for the area temperature before you take damage in most cases improving visibility of dangerous situations.
2020-11-24 22:37:36 -08:00
tgstation-server 29cb20c827 Automatic changelog generation for PR #54996 [ci skip] 2020-11-24 16:18:14 -08:00
ArcaneMusic bf39caca6a Refactors Pastries into newfood. (#54996)
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
Co-authored-by: Floyd <Floydje123@hotmail.com>
2020-11-24 16:18:10 -08:00
Changelogs 859c154111 Automatic changelog compile [ci skip] 2020-11-25 00:03:30 +00:00
tgstation-server 74b8282982 Automatic changelog generation for PR #55122 [ci skip] 2020-11-24 14:54:06 -08:00
Jared-Fogle cf9ae02e39 Fixes #55112 - Swapping items no longer eats things (#55122)
Quick swapping items no longer hides them in the mobs contents
2020-11-24 14:54:01 -08:00
tgstation-server ac33f91413 Automatic changelog generation for PR #55132 [ci skip] 2020-11-24 13:27:59 -08:00
Coffee 0907752ebd Fixes lightbulb injections (#55132)
Co-authored-by: itseasytosee <55666666+itseasytosee@users.noreply.github.com>
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-11-24 13:27:55 -08:00
tgstation-server d0e5b48963 Automatic changelog generation for PR #55109 [ci skip] 2020-11-24 08:07:13 -08:00
Arkatos1 1633a13609 tgui: Safe (#55109)
This PR refactors safes and brings their UI from html to tgui based on the PR above.

Paradise has more features for safes than us, and these features were not ported along to accommodate feature freeze. Only our current safe features settings were refactored, for example number of tumblers stays 2, no extra safe information on examine and safe codes are not generated on paper for command.

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-11-24 18:07:08 +02:00
tgstation-server 0bc3f8593b Automatic changelog generation for PR #55145 [ci skip] 2020-11-24 05:27:46 -08:00
Timberpoes 191b3cde38 Prevents mecha drills from stacking do_afters on the same target. (#55145)
* Feex

* Feex 2.0 Feexlectric Feexaloo

* Whitespace purge
2020-11-24 21:27:42 +08:00
tgstation-server 467c764684 Automatic changelog generation for PR #55129 [ci skip] 2020-11-24 05:21:41 -08:00
prodirus 1f220dec0c man adds a single ? (#55129) 2020-11-24 21:21:37 +08:00
tgstation-server cf20bbc9c9 Automatic changelog generation for PR #55065 [ci skip] 2020-11-24 05:21:12 -08:00
prodirus 4b1c61bb97 Fixes dish drives spitting out components on interact. (#55065)
* stop vomiting components ok mr dishdrive

* remember to do the dishes!

* lazyadds and lazylens

* actually lazy now
2020-11-24 21:21:08 +08:00
tgstation-server e32357e6b0 Automatic changelog generation for PR #55126 [ci skip] 2020-11-24 02:31:31 -08:00
Timberpoes d40255fc02 Deconstructed computer consoles no longer delete their own circuits. (#55126)
* Feex

* Remove newline
2020-11-24 18:31:26 +08:00
tgstation-server 4fe1d6411a Automatic changelog generation for PR #55036 [ci skip] 2020-11-24 02:21:43 -08:00
Bond eab04c0631 Fixes PDA bombing have equal chances to work on PDAs without manifest access vs PDAs with it (#55036)
* Makes extra difficulty actually work

0

* Actually fixes it as of what Fikou suggested

* no space, sorry

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
2020-11-24 18:21:39 +08:00
Yenwodyah d214170810 make sure slowdown effects get removed when items are unequipped (#54947) 2020-11-24 18:21:01 +08:00
tgstation-server 1b220a5471 Automatic changelog generation for PR #54975 [ci skip] 2020-11-24 02:19:18 -08:00
antropod 97a89f75c2 Detect if ghost reentered the brain (#54975) 2020-11-24 18:19:14 +08:00
tgstation-server 58204552bd Automatic changelog generation for PR #55007 [ci skip] 2020-11-24 02:17:59 -08:00
ArcaneDefence 0940ea6a70 This makes me sad (#55007) 2020-11-24 18:17:56 +08:00
tgstation-server b173a071d7 Automatic changelog generation for PR #55045 [ci skip] 2020-11-24 02:17:12 -08:00
Bond a29c2f6754 Makes APCs not cause runtimes when placed in space (#55045) 2020-11-24 18:17:08 +08:00
tgstation-server 9c69650f2e Automatic changelog generation for PR #54914 [ci skip] 2020-11-24 02:14:48 -08:00
zxaber 9201846090 Fixes tool implant tools being storable in boxes (#54914)
* Moves storing tool implant items to use the drop hotkey rather than a dropped item event

* de-debugging
2020-11-24 18:14:44 +08:00
tgstation-server 7d64c3afea Automatic changelog generation for PR #55063 [ci skip] 2020-11-24 02:11:11 -08:00
Ghom a786c73988 Fixing the point emote being both usable and unusable (#55063) 2020-11-24 18:11:07 +08:00
tgstation-server 3f00941a85 Automatic changelog generation for PR #55067 [ci skip] 2020-11-24 02:01:58 -08:00
prodirus cb6f29808d one character fix (#55067) 2020-11-24 18:01:54 +08:00
tgstation-server 1983ae68f6 Automatic changelog generation for PR #55082 [ci skip] 2020-11-24 02:00:06 -08:00
ArcaneMusic c09a4d3251 Lowers Stasis Bed Overlay below objects to prevent overlay issues. (#55082) 2020-11-24 18:00:02 +08:00
tgstation-server 7e55b08a4f Automatic changelog generation for PR #55119 [ci skip] 2020-11-24 01:53:08 -08:00