Issue #80 - de-unify and fix up gfx/graphite2

With de-unified building we have to re-apply the fix-up
for <cstdio>, and additionally the same for <cstring>
to prevent the compiler picking the wrong versions of
standard functions.

gfx/graphite2/moz-gr-update.sh

@@ -33,9 +33,10 @@ echo "$TARBALL" >> gfx/graphite2/README.mozilla
 echo ""
 echo "See" $0 "for update procedure." >> gfx/graphite2/README.mozilla
 
-# fix up includes because of bug 721839 (cstdio) and bug 803066 (Windows.h)
-#find gfx/graphite2/ -name "*.cpp" -exec perl -p -i -e "s/<cstdio>/<stdio.h>/;s/Windows.h/windows.h/;" {} \;
-#find gfx/graphite2/ -name "*.h" -exec perl -p -i -e "s/<cstdio>/<stdio.h>/;s/Windows.h/windows.h/;" {} \;
+# fix up includes because of BZ bug 721839 (cstdio) and BZ bug 803066 (Windows.h)
+# Additional issue with inclusion of <cstring> in non-unified mode (Issue #80)
+find gfx/graphite2/ -name "*.cpp" -exec perl -p -i -e "s/<cstdio>/<stdio.h>/;s/<cstring>/<string.h>/;s/Windows.h/windows.h/;" {} \;
+find gfx/graphite2/ -name "*.h" -exec perl -p -i -e "s/<cstdio>/<stdio.h>/;s/<cstring>/<string.h>/;s/Windows.h/windows.h/;" {} \;
 
 # summarize what's been touched
 echo Updated to $RELEASE.

gfx/graphite2/src/Code.cpp

@@ -32,7 +32,7 @@ of the License or (at your option) any later version.
 #include <cassert>
 #include <cstddef>
 #include <cstdlib>
-#include <cstring>
+#include <string.h>
 #include "graphite2/Segment.h"
 #include "inc/Code.h"
 #include "inc/Face.h"
@@ -42,7 +42,7 @@ of the License or (at your option) any later version.
 #include "inc/Rule.h"
 #include "inc/Silf.h"
 
-#include <cstdio>
+#include <stdio.h>
 
 #ifdef NDEBUG
 #ifdef __GNUC__

gfx/graphite2/src/Face.cpp

@@ -24,7 +24,7 @@ Mozilla Public License (http://mozilla.org/MPL) or the GNU General Public
 License, as published by the Free Software Foundation, either version 2
 of the License or (at your option) any later version.
 */
-#include <cstring>
+#include <string.h>
 #include "graphite2/Segment.h"
 #include "inc/CmapCache.h"
 #include "inc/debug.h"

gfx/graphite2/src/FeatureMap.cpp

@@ -24,7 +24,7 @@ Mozilla Public License (http://mozilla.org/MPL) or the GNU General Public
 License, as published by the Free Software Foundation, either version 2
 of the License or (at your option) any later version.
 */
-#include <cstring>
+#include <string.h>
 
 #include "inc/Main.h"
 #include "inc/bits.h"

gfx/graphite2/src/FileFace.cpp

@@ -24,7 +24,7 @@ Mozilla Public License (http://mozilla.org/MPL) or the GNU General Public
 License, as published by the Free Software Foundation, either version 2
 of the License or (at your option) any later version.
 */
-#include <cstring>
+#include <string.h>
 #include "inc/FileFace.h"
 
 

gfx/graphite2/src/Pass.cpp

@@ -28,7 +28,7 @@ of the License or (at your option) any later version.
 #include "inc/debug.h"
 #include "inc/Endian.h"
 #include "inc/Pass.h"
-#include <cstring>
+#include <string.h>
 #include <cstdlib>
 #include <cassert>
 #include <cmath>

gfx/graphite2/src/Segment.cpp

@@ -25,7 +25,7 @@ License, as published by the Free Software Foundation, either version 2
 of the License or (at your option) any later version.
 */
 #include "inc/UtfCodec.h"
-#include <cstring>
+#include <string.h>
 #include <cstdlib>
 
 #include "inc/bits.h"

gfx/graphite2/src/TtfUtil.cpp

@@ -43,7 +43,7 @@ Description
 //#include <algorithm>
 #include <cassert>
 #include <cstddef>
-#include <cstring>
+#include <string.h>
 #include <climits>
 #include <cwchar>
 //#include <stdexcept>

gfx/graphite2/src/call_machine.cpp

@@ -33,7 +33,7 @@ of the License or (at your option) any later version.
 // opcodes) but is slower that the direct threaded interpreter by a factor of 2
 
 #include <cassert>
-#include <cstring>
+#include <string.h>
 #include <graphite2/Segment.h>
 #include "inc/Machine.h"
 #include "inc/Segment.h"

gfx/graphite2/src/direct_machine.cpp

@@ -38,7 +38,7 @@ of the License or (at your option) any later version.
 
 
 #include <cassert>
-#include <cstring>
+#include <string.h>
 #include "inc/Machine.h"
 #include "inc/Segment.h"
 #include "inc/Slot.h"

gfx/graphite2/src/gr_logging.cpp

@@ -24,7 +24,7 @@ Mozilla Public License (http://mozilla.org/MPL) or the GNU General Public
 License, as published by the Free Software Foundation, either version 2
 of the License or (at your option) any later version.
 */
-#include <cstdio>
+#include <stdio.h>
 
 #include "graphite2/Log.h"
 #include "inc/debug.h"

gfx/graphite2/src/inc/Compression.h

@@ -29,7 +29,7 @@ of the License or (at your option) any later version.
 
 #include <cassert>
 #include <cstddef>
-#include <cstring>
+#include <string.h>
 
 namespace
 {

gfx/graphite2/src/inc/Face.h

@@ -26,7 +26,7 @@ of the License or (at your option) any later version.
 */
 #pragma once
 
-#include <cstdio>
+#include <stdio.h>
 
 #include "graphite2/Font.h"
 

gfx/graphite2/src/inc/FeatureVal.h

@@ -25,7 +25,7 @@ License, as published by the Free Software Foundation, either version 2
 of the License or (at your option) any later version.
 */
 #pragma once
-#include <cstring>
+#include <string.h>
 #include <cassert>
 #include "inc/Main.h"
 #include "inc/List.h"

gfx/graphite2/src/inc/FileFace.h

@@ -32,7 +32,7 @@ of the License or (at your option) any later version.
 
 #ifndef GRAPHITE2_NFILEFACE
 
-#include <cstdio>
+#include <stdio.h>
 #include <cassert>
 
 #include "graphite2/Font.h"

gfx/graphite2/src/inc/List.h

@@ -30,7 +30,7 @@ of the License or (at your option) any later version.
 
 #include <cstddef>
 #include <cassert>
-#include <cstring>
+#include <string.h>
 #include <cstdlib>
 #include <new>
 

gfx/graphite2/src/inc/Machine.h

@@ -31,7 +31,7 @@ of the License or (at your option) any later version.
 // interface.
 
 #pragma once
-#include <cstring>
+#include <string.h>
 #include <graphite2/Types.h>
 #include "inc/Main.h"
 

gfx/graphite2/src/inc/json.h

@@ -32,7 +32,7 @@ of the License or (at your option) any later version.
 
 #include "inc/Main.h"
 #include <cassert>
-#include <cstdio>
+#include <stdio.h>
 #include "inc/List.h"
 
 namespace graphite2 {

gfx/graphite2/src/inc/locale2lcid.h

@@ -25,7 +25,7 @@ License, as published by the Free Software Foundation, either version 2
 of the License or (at your option) any later version.
 */
 #pragma once
-#include <cstring>
+#include <string.h>
 #include <cassert>
 
 #include "inc/Main.h"

gfx/graphite2/src/json.cpp

@@ -29,7 +29,7 @@ of the License or (at your option) any later version.
 
 #if !defined GRAPHITE2_NTRACING
 
-#include <cstdio>
+#include <stdio.h>
 #include <limits>
 #include "inc/json.h"
 

gfx/graphite2/src/moz.build

@@ -13,16 +13,16 @@ EXPORTS.graphite2 += [
 ]
 
 if CONFIG['GNU_CC']:
-    UNIFIED_SOURCES += [
+    SOURCES += [
         'direct_machine.cpp'
     ]
 else:
-    UNIFIED_SOURCES += [
+    SOURCES += [
         'call_machine.cpp'
     ]
 
 # This should contain all of the _SOURCES from files.mk, except *_machine.cpp
-UNIFIED_SOURCES += [
+SOURCES += [
     'CachedFace.cpp',
     'CmapCache.cpp',
     'Code.cpp',
@@ -44,6 +44,7 @@ UNIFIED_SOURCES += [
     'Intervals.cpp',
     'json.cpp',
     'Justifier.cpp',
+    'NameTable.cpp',
     'Pass.cpp',
     'Position.cpp',
     'SegCache.cpp',
@@ -57,12 +58,6 @@ UNIFIED_SOURCES += [
     'UtfCodec.cpp',
 ]
 
-# Excluded from UNIFIED_SOURCES because <cmath> from other files breaks it,
-# see bug 1272647.
-SOURCES += [
-    'NameTable.cpp',
-]
-
 # tell graphite2 not to export symbols, we'll be linking it directly with
 # thebes
 DEFINES['GRAPHITE2_STATIC'] = True