roytam1/UXP
1
0
Fork 0
mirror of https://github.com/roytam1/UXP.git synced 2026-05-26 13:58:49 +00:00
Code Issues Projects Releases Wiki Activity

Bug 1332825 - Use move semantics in MozPromise::All() and AllPromiseHolder.

Browse Source 
MozPromise::All sets up 'Then' lambdas on all sub-promises, each one
taking the resolve/reject object by value. Since this value will not be
used again in the lambda, it is safe to Move it, and from there
MozPromiseHolder::Resolve/Reject can also Move it again into the holder
storage, potentially saving two copies per Resolve/Reject. Also, once
all sub-promises have been resolved, the resolve-values can be Move'd
into the joining promise's Resolve function.
This commit is contained in:
Gerald Squelart
2023-11-19 13:10:29 +01:00
committed by roytam1
parent e0a7c35dcc
commit 543e41f3ac
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xpcom/threads/MozPromise.h
+8 -8
View File
@@ -229,35 +229,35 @@ private:
mResolveValues.SetLength(aDependentPromises);
}
void Resolve(size_t aIndex, const ResolveValueType& aResolveValue)
void Resolve(size_t aIndex, ResolveValueType&& aResolveValue)
{
if (!mPromise) {
// Already rejected.
return;
}
mResolveValues[aIndex].emplace(aResolveValue);
mResolveValues[aIndex].emplace(Move(aResolveValue));
if (--mOutstandingPromises == 0) {
nsTArray<ResolveValueType> resolveValues;
resolveValues.SetCapacity(mResolveValues.Length());
for (size_t i = 0; i < mResolveValues.Length(); ++i) {
resolveValues.AppendElement(mResolveValues[i].ref());
resolveValues.AppendElement(Move(mResolveValues[i].ref()));
}
mPromise->Resolve(resolveValues, __func__);
mPromise->Resolve(Move(resolveValues), __func__);
mPromise = nullptr;
mResolveValues.Clear();
}
}
void Reject(const RejectValueType& aRejectValue)
void Reject(RejectValueType&& aRejectValue)
{
if (!mPromise) {
// Already rejected.
return;
}
mPromise->Reject(aRejectValue, __func__);
mPromise->Reject(Move(aRejectValue), __func__);
mPromise = nullptr;
mResolveValues.Clear();
}
@@ -276,8 +276,8 @@ public:
RefPtr<AllPromiseHolder> holder = new AllPromiseHolder(aPromises.Length());
for (size_t i = 0; i < aPromises.Length(); ++i) {
aPromises[i]->Then(aProcessingThread, __func__,
[holder, i] (ResolveValueType aResolveValue) -> void { holder->Resolve(i, aResolveValue); },
[holder] (RejectValueType aRejectValue) -> void { holder->Reject(aRejectValue); }
[holder, i] (ResolveValueType aResolveValue) -> void { holder->Resolve(i, Move(aResolveValue)); },
[holder] (RejectValueType aRejectValue) -> void { holder->Reject(Move(aRejectValue)); }
);
}
return holder->Promise();