roytam1/palemoon27
1
0
Fork 0
mirror of https://github.com/roytam1/palemoon27.git synced 2026-06-01 08:29:25 +00:00
Code Issues Projects Releases Wiki Activity

Add AES256-GCM suites to secmanager.

Browse Source 
Disabled by default for known wasted performance (40%) on a suite weaker to key attacks than AES128.
This commit is contained in:
Pale Moon
2017-02-25 10:13:37 +01:00
committed by roytam1
parent 8df1603dfd
commit 36fc143339
3 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
netwerk/base/security-prefs.js
+2
View File
@@ -43,6 +43,8 @@ pref("security.ssl3.rsa_aes_256_sha", true);
pref("security.ssl3.rsa_camellia_256_sha", true);
// Cipher suites disabled by default //Reason:
pref("security.ssl3.ecdhe_ecdsa_aes_256_gcm_sha384", false); // performance
pref("security.ssl3.ecdhe_rsa_aes_256_gcm_sha384", false); // performance
pref("security.ssl3.ecdhe_rsa_des_ede3_sha", false); //3DES
pref("security.ssl3.ecdhe_rsa_rc4_128_sha", false); //RC4
pref("security.ssl3.ecdhe_ecdsa_rc4_128_sha", false); //RC4
security/manager/ssl/src/nsNSSCallbacks.cpp
+2
View File
@@ -1077,6 +1077,8 @@ AccumulateCipherSuite(Telemetry::ID probe, const SSLChannelInfo& channelInfo)
case TLS_ECDHE_ECDSA_WITH_3DES_EDE_CBC_SHA: value = 10; break;
case TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256: value = 11; break;
case TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256: value = 12; break;
case TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384: value = 13; break;
case TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384: value = 14; break;
// DHE key exchange
case TLS_DHE_RSA_WITH_AES_128_CBC_SHA: value = 21; break;
case TLS_DHE_RSA_WITH_CAMELLIA_128_CBC_SHA: value = 22; break;
security/manager/ssl/src/nsNSSComponent.cpp
+8 -4
View File
@@ -643,7 +643,12 @@ static const CipherPref sCipherPrefs[] = {
TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256, true },
{ "security.ssl3.ecdhe_rsa_chacha20_poly1305_sha256",
TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256, true },
{ "security.ssl3.ecdhe_ecdsa_aes_256_gcm_sha384",
TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, false }, // disabled for performance
{ "security.ssl3.ecdhe_rsa_aes_256_gcm_sha384",
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, false }, // disabled for performance
{ "security.ssl3.ecdhe_rsa_aes_256_sha",
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, true },
{ "security.ssl3.ecdhe_ecdsa_aes_256_sha",
@@ -668,9 +673,6 @@ static const CipherPref sCipherPrefs[] = {
TLS_RSA_WITH_AES_128_CBC_SHA, true }, // deprecated (RSA key exchange)
{ "security.ssl3.rsa_aes_256_sha",
TLS_RSA_WITH_AES_256_CBC_SHA, true }, // deprecated (RSA key exchange)
{ "security.ssl3.rsa_des_ede3_sha",
TLS_RSA_WITH_3DES_EDE_CBC_SHA, true }, // deprecated (RSA key exchange, 3DES)
// All the rest are disabled by default
// As per RFC
@@ -690,6 +692,8 @@ static const CipherPref sCipherPrefs[] = {
{"security.ssl3.rsa_fips_des_ede3_sha", SSL_RSA_FIPS_WITH_3DES_EDE_CBC_SHA, false, true },
{"security.ssl3.dhe_dss_camellia_256_sha", TLS_DHE_DSS_WITH_CAMELLIA_256_CBC_SHA, false, false },
{"security.ssl3.dhe_dss_camellia_128_sha", TLS_DHE_DSS_WITH_CAMELLIA_128_CBC_SHA, false, false },
{"security.ssl3.rsa_des_ede3_sha", TLS_RSA_WITH_3DES_EDE_CBC_SHA, false, true }, // (3DES)
// Non-ephemeral
{"security.ssl3.ecdh_ecdsa_aes_256_sha", TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA, false, false },
{"security.ssl3.ecdh_ecdsa_aes_128_sha", TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA, false, false },