roytam1/palemoon27
1
0
Fork 0
mirror of https://github.com/roytam1/palemoon27.git synced 2026-05-26 14:18:48 +00:00
Code Issues Projects Releases Wiki Activity

Hold strong pointers to view managers (DiD)

Browse Source
This commit is contained in:
wolfbeast
2016-06-14 12:04:32 +02:00
committed by roytam1
parent 1a206566ea
commit 6144dc3eb8
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
view/nsViewManager.cpp
+4 -2
View File
@@ -372,7 +372,7 @@ nsViewManager::ProcessPendingUpdatesForView(nsView* aView,
}
}
if (rootShell->GetViewManager() != this) {
return; // 'this' might have been destroyed
return; // presentation might have been torn down
}
if (aFlushDirtyRegion) {
nsAutoScriptBlocker scriptBlocker;
@@ -416,7 +416,7 @@ nsViewManager::ProcessPendingUpdatesPaint(nsIWidget* aWidget)
if (aWidget->NeedsPaint()) {
// If an ancestor widget was hidden and then shown, we could
// have a delayed resize to handle.
for (nsViewManager *vm = this; vm;
for (nsRefPtr<nsViewManager> vm = this; vm;
vm = vm->mRootView->GetParent()
? vm->mRootView->GetParent()->GetViewManager()
: nullptr) {
@@ -1069,6 +1069,7 @@ nsViewManager::ProcessPendingUpdates()
if (mPresShell) {
mPresShell->GetPresContext()->RefreshDriver()->RevokeViewManagerFlush();
nsRefPtr<nsViewManager> strongThis(this);
CallWillPaintOnObservers();
ProcessPendingUpdatesForView(mRootView, true);
@@ -1085,6 +1086,7 @@ nsViewManager::UpdateWidgetGeometry()
if (mHasPendingWidgetGeometryChanges) {
mHasPendingWidgetGeometryChanges = false;
nsRefPtr<nsViewManager> strongThis(this);
ProcessPendingUpdatesForView(mRootView, false);
}
}